From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: joro@8bytes.org, iommu@lists.linux-foundation.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/3] iommu/ipmmu-vmsa: Remove some unused register declarations
Date: Wed, 9 Oct 2019 23:03:25 +0200 [thread overview]
Message-ID: <20191009210325.GB21066@bigcity.dyn.berto.se> (raw)
In-Reply-To: <1570609609-1332-2-git-send-email-yoshihiro.shimoda.uh@renesas.com>
Hi Shimoda-san,
Thanks for your patch.
On 2019-10-09 17:26:47 +0900, Yoshihiro Shimoda wrote:
> To support different registers memory mapping hardware easily
> in the future, this patch removes some unused register
> declarations.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/iommu/ipmmu-vmsa.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c
> index 9da8309..dd554c2 100644
> --- a/drivers/iommu/ipmmu-vmsa.c
> +++ b/drivers/iommu/ipmmu-vmsa.c
> @@ -104,8 +104,6 @@ static struct ipmmu_vmsa_device *to_ipmmu(struct device *dev)
> #define IMCTR 0x0000
> #define IMCTR_TRE (1 << 17)
> #define IMCTR_AFE (1 << 16)
> -#define IMCTR_RTSEL_MASK (3 << 4)
> -#define IMCTR_RTSEL_SHIFT 4
> #define IMCTR_TREN (1 << 3)
> #define IMCTR_INTEN (1 << 2)
> #define IMCTR_FLUSH (1 << 1)
> @@ -115,7 +113,6 @@ static struct ipmmu_vmsa_device *to_ipmmu(struct device *dev)
>
> #define IMTTBCR 0x0008
> #define IMTTBCR_EAE (1 << 31)
> -#define IMTTBCR_PMB (1 << 30)
> #define IMTTBCR_SH1_NON_SHAREABLE (0 << 28) /* R-Car Gen2 only */
> #define IMTTBCR_SH1_OUTER_SHAREABLE (2 << 28) /* R-Car Gen2 only */
> #define IMTTBCR_SH1_INNER_SHAREABLE (3 << 28) /* R-Car Gen2 only */
> @@ -193,12 +190,6 @@ static struct ipmmu_vmsa_device *to_ipmmu(struct device *dev)
> #define IMELAR 0x0030 /* IMEAR on R-Car Gen2 */
> #define IMEUAR 0x0034 /* R-Car Gen3 only */
>
> -#define IMPCTR 0x0200
> -#define IMPSTR 0x0208
> -#define IMPEAR 0x020c
> -#define IMPMBA(n) (0x0280 + ((n) * 4))
> -#define IMPMBD(n) (0x02c0 + ((n) * 4))
> -
> #define IMUCTR(n) ((n) < 32 ? IMUCTR0(n) : IMUCTR32(n))
> #define IMUCTR0(n) (0x0300 + ((n) * 16))
> #define IMUCTR32(n) (0x0600 + (((n) - 32) * 16))
> @@ -206,8 +197,6 @@ static struct ipmmu_vmsa_device *to_ipmmu(struct device *dev)
> #define IMUCTR_FIXADD_MASK (0xff << 16)
> #define IMUCTR_FIXADD_SHIFT 16
> #define IMUCTR_TTSEL_MMU(n) ((n) << 4)
> -#define IMUCTR_TTSEL_PMB (8 << 4)
> -#define IMUCTR_TTSEL_MASK (15 << 4)
> #define IMUCTR_FLUSH (1 << 1)
> #define IMUCTR_MMUEN (1 << 0)
>
> --
> 2.7.4
>
--
Regards,
Niklas Söderlund
next prev parent reply other threads:[~2019-10-09 21:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 8:26 [PATCH 0/3] iommu/ipmmu-vmsa: minor updates Yoshihiro Shimoda
2019-10-09 8:26 ` [PATCH 1/3] iommu/ipmmu-vmsa: Remove some unused register declarations Yoshihiro Shimoda
2019-10-09 21:03 ` Niklas Söderlund [this message]
2019-10-11 12:10 ` Geert Uytterhoeven
2019-10-15 5:17 ` Yoshihiro Shimoda
2019-10-09 8:26 ` [PATCH 2/3] iommu/ipmmu-vmsa: Calculate context registers' offset instead of a macro Yoshihiro Shimoda
2019-10-09 21:13 ` Niklas Söderlund
2019-10-11 12:29 ` Geert Uytterhoeven
2019-10-15 5:28 ` Yoshihiro Shimoda
2019-10-09 8:26 ` [PATCH 3/3] iommu/ipmmu-vmsa: Add utlb_offset_base Yoshihiro Shimoda
2019-10-09 22:28 ` Niklas Söderlund
2019-10-11 12:32 ` Geert Uytterhoeven
2019-10-15 5:28 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009210325.GB21066@bigcity.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).