From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1170EC43331 for ; Thu, 7 Nov 2019 20:21:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CA79A2166E for ; Thu, 7 Nov 2019 20:21:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Jg9mUpxC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726640AbfKGUVG (ORCPT ); Thu, 7 Nov 2019 15:21:06 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:34030 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725823AbfKGUVG (ORCPT ); Thu, 7 Nov 2019 15:21:06 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DD03871D; Thu, 7 Nov 2019 21:21:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1573158063; bh=Mpz7w2hhtBiXiIGyYZs/Ge2dHsprOKWqvu9gZOc2idU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Jg9mUpxC7IEv72FmHtgUuBrRL4uT6VYIo10brfpRF77UCtAhgZR6ccGRz/r6IdbXc VpMZHzE856L2Y2WGdQmQvJ2BDiNXhzlyz+xkYktDYA0mP4snVDZqlqRCaaB5m4/GpN M4Hfl8l6wwbKD5FQjBfH/6qwLhG+np6od0I5bhaM= Date: Thu, 7 Nov 2019 22:20:52 +0200 From: Laurent Pinchart To: Fabrizio Castro Cc: Neil Armstrong , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Andrzej Hajda , Simon Horman , Geert Uytterhoeven , Magnus Damm , Peter Rosin , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Chris Paterson , Biju Das , Kieran Bingham , Jacopo Mondi Subject: Re: [PATCH v3 1/7] dt-bindings: display: bridge: Convert lvds-transmitter binding to json-schema Message-ID: <20191107202052.GM24983@pendragon.ideasonboard.com> References: <1573157463-14070-1-git-send-email-fabrizio.castro@bp.renesas.com> <1573157463-14070-2-git-send-email-fabrizio.castro@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1573157463-14070-2-git-send-email-fabrizio.castro@bp.renesas.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Fabrizio, Thank you for the patch. On Thu, Nov 07, 2019 at 08:10:57PM +0000, Fabrizio Castro wrote: > Convert the lvds-transmitter binding to DT schema format using > json-schema. > > Signed-off-by: Fabrizio Castro > > --- > v2->v3: > * Extracted conversion to dt-schema as per Rob's comment > v1->v2: > * Converted to dt-schema as per Neil's comment > --- > .../bindings/display/bridge/lvds-transmitter.txt | 66 ---------------- > .../bindings/display/bridge/lvds-transmitter.yaml | 91 ++++++++++++++++++++++ > 2 files changed, 91 insertions(+), 66 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > create mode 100644 Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > deleted file mode 100644 > index 60091db..0000000 > --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > +++ /dev/null > @@ -1,66 +0,0 @@ > -Parallel to LVDS Encoder > ------------------------- > - > -This binding supports the parallel to LVDS encoders that don't require any > -configuration. > - > -LVDS is a physical layer specification defined in ANSI/TIA/EIA-644-A. Multiple > -incompatible data link layers have been used over time to transmit image data > -to LVDS panels. This binding targets devices compatible with the following > -specifications only. > - > -[JEIDA] "Digital Interface Standards for Monitor", JEIDA-59-1999, February > -1999 (Version 1.0), Japan Electronic Industry Development Association (JEIDA) > -[LDI] "Open LVDS Display Interface", May 1999 (Version 0.95), National > -Semiconductor > -[VESA] "VESA Notebook Panel Standard", October 2007 (Version 1.0), Video > -Electronics Standards Association (VESA) > - > -Those devices have been marketed under the FPD-Link and FlatLink brand names > -among others. > - > - > -Required properties: > - > -- compatible: Must be "lvds-encoder" > - > - Any encoder compatible with this generic binding, but with additional > - properties not listed here, must list a device specific compatible first > - followed by this generic compatible. > - > -Required nodes: > - > -This device has two video ports. Their connections are modeled using the OF > -graph bindings specified in Documentation/devicetree/bindings/graph.txt. > - > -- Video port 0 for parallel input > -- Video port 1 for LVDS output > - > - > -Example > -------- > - > -lvds-encoder { > - compatible = "lvds-encoder"; > - > - ports { > - #address-cells = <1>; > - #size-cells = <0>; > - > - port@0 { > - reg = <0>; > - > - lvds_enc_in: endpoint { > - remote-endpoint = <&display_out_rgb>; > - }; > - }; > - > - port@1 { > - reg = <1>; > - > - lvds_enc_out: endpoint { > - remote-endpoint = <&lvds_panel_in>; > - }; > - }; > - }; > -}; > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml > new file mode 100644 > index 0000000..5be163a > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml > @@ -0,0 +1,91 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/lvds-transmitter.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Parallel to LVDS Encoder > + > +maintainers: > + - Laurent Pinchart > + > +description: | > + This binding supports the parallel to LVDS encoders that don't require any > + configuration. > + > + LVDS is a physical layer specification defined in ANSI/TIA/EIA-644-A. Multiple > + incompatible data link layers have been used over time to transmit image data > + to LVDS panels. This binding targets devices compatible with the following > + specifications only. > + > + [JEIDA] "Digital Interface Standards for Monitor", JEIDA-59-1999, February > + 1999 (Version 1.0), Japan Electronic Industry Development Association (JEIDA) > + [LDI] "Open LVDS Display Interface", May 1999 (Version 0.95), National > + Semiconductor > + [VESA] "VESA Notebook Panel Standard", October 2007 (Version 1.0), Video > + Electronics Standards Association (VESA) > + > + Those devices have been marketed under the FPD-Link and FlatLink brand names > + among others. > + > +properties: > + compatible: > + description: | > + Any encoder or decoder compatible with this generic binding, but with I think "or decoder" should be added in patch 3/7. > + additional properties not listed here, must define its own binding and > + list a device specific compatible first followed by the generic compatible s/compatible/compatible./ > + enum: > + - lvds-encoder > + How is this binding supposed to be used, should LVDS encoder bindings reference it with $ref ? If so, how do those bindings extend the compatible property ? > + ports: > + type: object > + description: | > + This device has two video ports. Their connections are modeled using the > + OF graph bindings specified in Documentation/devicetree/bindings/graph.txt > + properties: > + port@0: > + type: object > + description: | > + Port 0 is for parallel input > + > + port@1: > + type: object > + description: | > + Port 1 is for LVDS output > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - ports > + > +examples: > + - | > + lvds-encoder { > + compatible = "lvds-encoder"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + lvds_enc_in: endpoint { > + remote-endpoint = <&display_out_rgb>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + lvds_enc_out: endpoint { > + remote-endpoint = <&lvds_panel_in>; > + }; > + }; > + }; > + }; > + > +... -- Regards, Laurent Pinchart