From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AC5BC43331 for ; Thu, 7 Nov 2019 20:55:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 57BE921D6C for ; Thu, 7 Nov 2019 20:55:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="XuK82nb+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725828AbfKGUze (ORCPT ); Thu, 7 Nov 2019 15:55:34 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:35814 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725818AbfKGUzd (ORCPT ); Thu, 7 Nov 2019 15:55:33 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6E4D671D; Thu, 7 Nov 2019 21:55:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1573160131; bh=T/JTmFFKWPUIC/UNcZMUFodIIgOi+wflNsrXPviHW2w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XuK82nb+Q1K+FJVDzzYmfvW2S0k/ajGaf3N3O9VrdXbRmJ5Y4jP0h9qnPIJCqb30s 5S8M96lKYTy+8H7rzFizbPsvuEF+4sPbArZ7bdDjqNL02tO/U9SOqqROB58QURScWx LQ591kEzntMEBbp32XVyoE26SFycos1p21+5Dthk= Date: Thu, 7 Nov 2019 22:55:20 +0200 From: Laurent Pinchart To: Fabrizio Castro Cc: Neil Armstrong , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Andrzej Hajda , Simon Horman , Geert Uytterhoeven , Magnus Damm , Peter Rosin , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Chris Paterson , Biju Das , Kieran Bingham , Jacopo Mondi Subject: Re: [PATCH v3 6/7] ARM: dts: iwg20d-q7-common: Add LCD support Message-ID: <20191107205520.GR24983@pendragon.ideasonboard.com> References: <1573157463-14070-1-git-send-email-fabrizio.castro@bp.renesas.com> <1573157463-14070-7-git-send-email-fabrizio.castro@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1573157463-14070-7-git-send-email-fabrizio.castro@bp.renesas.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Fabrizio, Thank you for the patch. On Thu, Nov 07, 2019 at 08:11:02PM +0000, Fabrizio Castro wrote: > The iwg20d comes with a 7" capacitive touch screen, therefore > add support for it. > > Signed-off-by: Fabrizio Castro > > --- > v2->v3: > * No change > v1->v2: > * No change > --- > arch/arm/boot/dts/iwg20d-q7-common.dtsi | 85 ++++++++++++++++++++++++++++++++ > arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi | 1 - > 2 files changed, 85 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/iwg20d-q7-common.dtsi b/arch/arm/boot/dts/iwg20d-q7-common.dtsi > index ae75a1db..3428b8d 100644 > --- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi > +++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi > @@ -46,6 +46,49 @@ > clock-frequency = <26000000>; > }; > > + lcd_backlight: backlight { > + compatible = "pwm-backlight"; > + > + pwms = <&pwm3 0 5000000 0>; > + brightness-levels = <0 4 8 16 32 64 128 255>; > + default-brightness-level = <7>; > + enable-gpios = <&gpio5 14 GPIO_ACTIVE_HIGH>; > + }; > + > + lvds-receiver { > + compatible = "lvds-decoder"; A specific compatible string is required. I think the lvds-decoder driver should error out at probe time if only one compatible string is listed. > + powerdown = <&gpio7 25 GPIO_ACTIVE_LOW>; powerdown-gpios ? > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + lvds_receiver_in: endpoint { > + remote-endpoint = <&lvds0_out>; > + }; > + }; > + port@1 { > + reg = <1>; > + lvds_receiver_out: endpoint { > + remote-endpoint = <&panel_in>; > + }; > + }; > + }; > + }; > + > + panel { > + compatible = "edt,etm0700g0dh6", "simple-panel"; There's no "simple-panel" compatible string defined anywhere as far as I can tell. > + backlight = <&lcd_backlight>; > + > + port { > + panel_in: endpoint { > + remote-endpoint = <&lvds_receiver_out>; > + }; > + }; > + }; > + > reg_1p5v: 1p5v { > compatible = "regulator-fixed"; > regulator-name = "1P5V"; > @@ -120,6 +163,18 @@ > status = "okay"; > }; > > +&du { > + status = "okay"; > +}; > + > +&gpio2 { > + touch-interrupt { > + gpio-hog; > + gpios = <12 GPIO_ACTIVE_LOW>; > + input; > + }; Do you need this, with the touchpanel@38 node already listing the interrupt ? > +}; > + > &hsusb { > status = "okay"; > pinctrl-0 = <&usb0_pins>; > @@ -147,6 +202,25 @@ > VDDIO-supply = <®_3p3v>; > VDDD-supply = <®_1p5v>; > }; > + > + touch: touchpanel@38 { > + compatible = "edt,edt-ft5406"; > + reg = <0x38>; > + interrupt-parent = <&gpio2>; > + interrupts = <12 IRQ_TYPE_EDGE_FALLING>; > + }; > +}; > + > +&lvds0 { > + status = "okay"; > + > + ports { > + port@1 { > + lvds0_out: endpoint { > + remote-endpoint = <&lvds_receiver_in>; > + }; > + }; > + }; > }; > > &pci0 { > @@ -180,6 +254,11 @@ > function = "i2c2"; > }; > > + pwm3_pins: pwm3 { > + groups = "pwm3"; > + function = "pwm3"; > + }; > + > scif0_pins: scif0 { > groups = "scif0_data_d"; > function = "scif0"; > @@ -218,6 +297,12 @@ > }; > }; > > +&pwm3 { > + pinctrl-0 = <&pwm3_pins>; > + pinctrl-names = "default"; > + status = "okay"; > +}; > + > &rcar_sound { > pinctrl-0 = <&sound_pins>; > pinctrl-names = "default"; > diff --git a/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi b/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi > index 0e99df2..ede2e0c 100644 > --- a/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi > +++ b/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi > @@ -39,7 +39,6 @@ > &du { > pinctrl-0 = <&du_pins>; > pinctrl-names = "default"; > - status = "okay"; > > ports { > port@0 { -- Regards, Laurent Pinchart