From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09A6CC43603 for ; Mon, 16 Dec 2019 22:42:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C41CB24672 for ; Mon, 16 Dec 2019 22:42:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="tbm69dh1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726470AbfLPWmR (ORCPT ); Mon, 16 Dec 2019 17:42:17 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:60140 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726448AbfLPWmR (ORCPT ); Mon, 16 Dec 2019 17:42:17 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 85142A34; Mon, 16 Dec 2019 23:42:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1576536135; bh=HQOOFuO73uBCXhZTD2LvNfWr1SsGgPTr7tQlB2ovT6M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tbm69dh1bV40mJDuPDwwXYv21tLCsEoiVRKo+02BZT8d3LA8ov19g/wH+0/HYtfs8 YsO/AbisdGwlN2Gz6k0g1n12rT9FhFeZ0MLIph9xH0C4Jr1JPKPyrrpPa/p9I5A4tS kqJlE6nuNlV5nNPyei5KUl9g89E77DSoa2059laM= Date: Tue, 17 Dec 2019 00:42:04 +0200 From: Laurent Pinchart To: Jacopo Mondi Cc: kieran.bingham+renesas@ideasonboard.com, niklas.soderlund@ragnatech.se, linux-renesas-soc@vger.kernel.org Subject: Re: [RFC 05/11] fixup! dt-bindings: media: i2c: Add bindings for IMI RDACM20 Message-ID: <20191216224204.GJ4856@pendragon.ideasonboard.com> References: <20191216171620.372683-1-jacopo+renesas@jmondi.org> <20191216171620.372683-6-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191216171620.372683-6-jacopo+renesas@jmondi.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Jacopo, Thank you for the patch. On Mon, Dec 16, 2019 at 06:16:14PM +0100, Jacopo Mondi wrote: > --- > .../bindings/media/i2c/imi,rdacm20.txt | 66 ---------- > .../bindings/media/i2c/imi,rdacm20.yaml | 113 ++++++++++++++++++ > 2 files changed, 113 insertions(+), 66 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/media/i2c/imi,rdacm20.txt > create mode 100644 Documentation/devicetree/bindings/media/i2c/imi,rdacm20.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/imi,rdacm20.txt b/Documentation/devicetree/bindings/media/i2c/imi,rdacm20.txt > deleted file mode 100644 > index 4731aafed63f..000000000000 > --- a/Documentation/devicetree/bindings/media/i2c/imi,rdacm20.txt > +++ /dev/null > @@ -1,66 +0,0 @@ > -IMI D&D RDACM20 Automotive Camera Platform > ------------------------------------------- > - > -The IMI D&D RDACM20 is a GMSL-compatible camera designed for automotive > -applications. It encloses a Maxim Integrated MAX9271 GMSL serializer, an > -Omnivision OV10635 camera sensor and an embedded MCU, and connects to a remote > -GMSL endpoint through a coaxial cable. > - > - IMI RDACM20 > - --------------- -------------------------------- > -| GMSL | <--- Video Stream | <- Video--------\ | > -| |< ====== GMSL Link ======== >|MAX9271<- I2C bus-> <-->OV10635 | > -| de-serializer | <--- I2C messages ---> | \<-->MCU | > - --------------- -------------------------------- > - > -The RDACM20 transmits video data generated by the embedded camera sensor on the > -GMSL serial channel to a remote GMSL de-serializer, as well as it receives and > -transmits I2C messages encapsulated in the GMSL bidirectional control channel. > - > -All I2C traffic received on the GMSL link not directed to the serializer is > -propagated on the local I2C bus to the embedded camera sensor and MCU. All > -I2C traffic generated on the local I2C bus not directed to the serializer is > -propagated to the remote de-serializer encapsulated in the GMSL control channel. > - > -The RDACM20 DT node should be a direct child of the GMSL Deserializer's I2C bus > -corresponding to the GMSL link that the camera is attached to. > - > -Required Properties: > - > -- compatible: Shall be "imi,rdacm20". > -- reg: I2C device addresses, the first to be assigned to the serializer > - the second to be assigned to the camera sensor. An optional third address can > - be provided to specify the MCU address if present. > - > -Connection to the remote GMSL endpoint are modelled using the OF graph bindings > -in accordance with the video interface bindings defined in > -Documentation/devicetree/bindings/media/video-interfaces.txt. > - > -The device node contains a single "port" child node with a single "endpoint" > -sub-device. > - > -Required endpoint properties: > - > -- remote-endpoint: phandle to the remote GMSL endpoint sub-node in the remote > - node port. > - > -Example: > -------- > - > - i2c@0 { > - #address-cells = <1>; > - #size-cells = <0>; > - reg = <0>; > - > - camera@51 { > - compatible = "imi,rdacm20"; > - reg = <0x31 0x41 0x51>; > - > - port { > - rdacm20_out0: endpoint { > - remote-endpoint = <&max9286_in0>; > - }; > - }; > - > - }; > - }; > diff --git a/Documentation/devicetree/bindings/media/i2c/imi,rdacm20.yaml b/Documentation/devicetree/bindings/media/i2c/imi,rdacm20.yaml > new file mode 100644 > index 000000000000..76740e285f44 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/imi,rdacm20.yaml > @@ -0,0 +1,113 @@ > +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause > +# Copyright (C) 2019 Renesas Electronics Corp. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/imi,rdacm20.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: IMI D&D RDACM20 Automotive Camera Platform > + > +maintainers: > + - Jacopo Mondi > + - Kieran Bingham > + - Laurent Pinchart > + - Niklas Söderlund > + > +description: -| > + The IMI D&D RDACM20 is a GMSL-compatible camera designed for automotive > + applications. It encloses a Maxim Integrated MAX9271 GMSL serializer, an > + Omnivision OV10635 camera sensor and an embedded MCU, and connects to a remote > + GMSL endpoint through a coaxial cable. > + > + IMI RDACM20 > + +---------------+ +--------------------------------+ > + | GMSL | <- Video Stream | <- Video--------\ | > + | |< === GMSL Link ====== >|MAX9271<- I2C bus-> <-->OV10635 | > + | de-serializer | <- I2C messages -> | \<-->MCU | > + +---------------+ +--------------------------------+ > + > + The RDACM20 transmits video data generated by the embedded camera sensor on > + the GMSL serial channel to a remote GMSL de-serializer, as well as it receives > + and transmits I2C messages encapsulated in the GMSL bidirectional control > + channel. > + > + All I2C traffic received on the GMSL link not directed to the serializer is > + propagated on the local I2C bus to the embedded camera sensor and MCU. All I2C > + traffic generated on the local I2C bus not directed to the serializer is > + propagated to the remote de-serializer encapsulated in the GMSL control > + channel. > + > + The RDACM20 DT node should be a direct child of the GMSL Deserializer's I2C > + bus corresponding to the GMSL link that the camera is attached to. > + > +properties: > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 Are those two properties needed ? > + > + compatible: > + const: imi,rdacm20 > + > + reg: > + description: -| > + I2C device addresses, the first to be assigned to the serializer the > + second to be assigned to the camera sensor. An optional third address can > + be provided to specify the MCU address if present. > + minItems: 2 > + maxItems: 3 > + > + port: > + type: object > + additionalProperties: false > + description: -| > + Connection to the remote GMSL endpoint are modelled using the OF graph > + bindings in accordance with the video interface bindings defined in > + Documentation/devicetree/bindings/media/video-interfaces.txt. > + > + The device node contains a single "port" child node with a single > + "endpoint" sub-device. > + > + properties: > + endpoint: > + type: object > + additionalProperties: false > + > + properties: > + remote-endpoint: > + description: -| > + phandle to the remote GMSL endpoint sub-node in the remote node > + port. > + maxItems: 1 > + > + required: > + - remote-endpoint > + > + required: > + - endpoint > + > +required: > + - compatible > + - reg > + - port > + > +examples: > + - | > + i2c@e66d8000 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + reg = <0 0xe66d8000 0 0x40>; > + > + camera@31 { > + compatible = "imi,rdacm20"; > + reg = <0x31>, <0x41>, <0x51>; > + > + port { > + rdacm20_out0: endpoint { > + remote-endpoint = <&max9286_in0>; > + }; > + }; > + }; > + }; -- Regards, Laurent Pinchart