Linux-Renesas-SoC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ARM: dts: renesas: Group tuples in operating-points properties
@ 2019-12-31 14:16 Geert Uytterhoeven
  2020-01-07 23:56 ` Niklas Söderlund
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2019-12-31 14:16 UTC (permalink / raw)
  To: Magnus Damm; +Cc: linux-renesas-soc, devicetree, Geert Uytterhoeven

To improve human readability and enable automatic validation, the tuples
in the "operating-points" properties of CPU nodes should be grouped.

Fix this by grouping the tuples of these properties using angle brackets
in the DTS files for all Renesas SoCs that don't already do so.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/boot/dts/r8a73a4-ape6evm.dts | 7 ++-----
 arch/arm/boot/dts/sh73a0-kzm9g.dts    | 9 +++------
 2 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/arch/arm/boot/dts/r8a73a4-ape6evm.dts b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
index 1fbf45082726af36..9eea57d069c227a7 100644
--- a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
+++ b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
@@ -238,11 +238,8 @@
 
 &cpu0 {
 	cpu0-supply = <&vdd_dvfs>;
-	operating-points = <
-		/* kHz  uV */
-		1950000 1115000
-		1462500  995000
-	>;
+	operating-points = <1950000 1115000>,	/* kHz  uV */
+			   <1462500  995000>;
 	voltage-tolerance = <1>; /* 1% */
 };
 
diff --git a/arch/arm/boot/dts/sh73a0-kzm9g.dts b/arch/arm/boot/dts/sh73a0-kzm9g.dts
index 5fa9d3d9cd36a146..1c9dfe9f10e552da 100644
--- a/arch/arm/boot/dts/sh73a0-kzm9g.dts
+++ b/arch/arm/boot/dts/sh73a0-kzm9g.dts
@@ -25,12 +25,9 @@
 	cpus {
 		cpu@0 {
 			cpu0-supply = <&vdd_dvfs>;
-			operating-points = <
-				/* kHz  uV */
-				1196000 1315000
-				 598000 1175000
-				 398667 1065000
-			>;
+			operating-points = <1196000 1315000>,	/* kHz  uV */
+					   < 598000 1175000>,
+					   < 398667 1065000>;
 			voltage-tolerance = <1>; /* 1% */
 		};
 	};
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: renesas: Group tuples in operating-points properties
  2019-12-31 14:16 [PATCH] ARM: dts: renesas: Group tuples in operating-points properties Geert Uytterhoeven
@ 2020-01-07 23:56 ` Niklas Söderlund
  0 siblings, 0 replies; 2+ messages in thread
From: Niklas Söderlund @ 2020-01-07 23:56 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Magnus Damm, linux-renesas-soc, devicetree

Hi Geert,

Thanks for your work.

On 2019-12-31 15:16:42 +0100, Geert Uytterhoeven wrote:
> To improve human readability and enable automatic validation, the tuples
> in the "operating-points" properties of CPU nodes should be grouped.
> 
> Fix this by grouping the tuples of these properties using angle brackets
> in the DTS files for all Renesas SoCs that don't already do so.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> ---
>  arch/arm/boot/dts/r8a73a4-ape6evm.dts | 7 ++-----
>  arch/arm/boot/dts/sh73a0-kzm9g.dts    | 9 +++------
>  2 files changed, 5 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/r8a73a4-ape6evm.dts b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> index 1fbf45082726af36..9eea57d069c227a7 100644
> --- a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> +++ b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> @@ -238,11 +238,8 @@
>  
>  &cpu0 {
>  	cpu0-supply = <&vdd_dvfs>;
> -	operating-points = <
> -		/* kHz  uV */
> -		1950000 1115000
> -		1462500  995000
> -	>;
> +	operating-points = <1950000 1115000>,	/* kHz  uV */
> +			   <1462500  995000>;
>  	voltage-tolerance = <1>; /* 1% */
>  };
>  
> diff --git a/arch/arm/boot/dts/sh73a0-kzm9g.dts b/arch/arm/boot/dts/sh73a0-kzm9g.dts
> index 5fa9d3d9cd36a146..1c9dfe9f10e552da 100644
> --- a/arch/arm/boot/dts/sh73a0-kzm9g.dts
> +++ b/arch/arm/boot/dts/sh73a0-kzm9g.dts
> @@ -25,12 +25,9 @@
>  	cpus {
>  		cpu@0 {
>  			cpu0-supply = <&vdd_dvfs>;
> -			operating-points = <
> -				/* kHz  uV */
> -				1196000 1315000
> -				 598000 1175000
> -				 398667 1065000
> -			>;
> +			operating-points = <1196000 1315000>,	/* kHz  uV */
> +					   < 598000 1175000>,
> +					   < 398667 1065000>;
>  			voltage-tolerance = <1>; /* 1% */
>  		};
>  	};
> -- 
> 2.17.1
> 

-- 
Regards,
Niklas Söderlund

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-31 14:16 [PATCH] ARM: dts: renesas: Group tuples in operating-points properties Geert Uytterhoeven
2020-01-07 23:56 ` Niklas Söderlund

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org
	public-inbox-index linux-renesas-soc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git