From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 00/13] pinctrl: sh-pfc: checker: Various improvements
Date: Fri, 10 Jan 2020 21:29:50 +0100 [thread overview]
Message-ID: <20200110202950.GA695049@oden.dyn.berto.se> (raw)
In-Reply-To: <20200110131927.1029-1-geert+renesas@glider.be>
Hi Geert,
Neat series. I always worry when my eyes start to cross each other when
looking at the big tables I will make mistakes like this ;-)
On 2020-01-10 14:19:14 +0100, Geert Uytterhoeven wrote:
> Hi all,
>
> This patch series contains various improvements for the builtin pin
> control table runtime checks of the Renesas Pin Function Controller
> driver. These checks are enabled with CONFIG_DEBUG_PINCTRL=y, which can
> be combined with CONFIG_COMPILE_TEST=y to increase coverage to all
> Renesas ARM and SuperH SoCs..
>
> Note that all issues detected by this have already been fixed in "[PATCH
> 0/6] pinctrl: sh-pfc: More miscellenaous fixes"[1], and are now part of
> linux-next.
>
> I plan to queue this in sh-pfc-for-v5.7.
With the fix you point out yourself in 13/13 for
CONFIG_PINCTRL_SH_FUNC_GPIO=n feel free to add
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
For the whole series.
>
> Thanks for your comments!
>
> [1] https://lore.kernel.org/linux-renesas-soc/20191218194812.12741-1-geert+renesas@glider.be/
>
> Geert Uytterhoeven (13):
> pinctrl: sh-pfc: checker: Move data before code
> pinctrl: sh-pfc: checker: Add helpers for reporting
> pinctrl: sh-pfc: checker: Add helper for safe name comparison
> pinctrl: sh-pfc: checker: Add check for config register conflicts
> pinctrl: sh-pfc: checker: Add check for enum ID conflicts
> pinctrl: sh-pfc: checker: Improve pin checks
> pinctrl: sh-pfc: checker: Improve pin function checks
> pinctrl: sh-pfc: checker: Improve pin group checks
> pinctrl: sh-pfc: checker: Add drive strength register checks
> pinctrl: sh-pfc: checker: Add bias register checks
> pinctrl: sh-pfc: checker: Add ioctrl register checks
> pinctrl: sh-pfc: checker: Add data register checks
> pinctrl: sh-pfc: checker: Add function GPIO checks
>
> drivers/pinctrl/sh-pfc/core.c | 312 +++++++++++++++++++++++++++-------
> 1 file changed, 250 insertions(+), 62 deletions(-)
>
> --
> 2.17.1
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
Regards,
Niklas Söderlund
next prev parent reply other threads:[~2020-01-10 20:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 13:19 [PATCH 00/13] pinctrl: sh-pfc: checker: Various improvements Geert Uytterhoeven
2020-01-10 13:19 ` [PATCH 01/13] pinctrl: sh-pfc: checker: Move data before code Geert Uytterhoeven
2020-01-10 13:19 ` [PATCH 02/13] pinctrl: sh-pfc: checker: Add helpers for reporting Geert Uytterhoeven
2020-01-10 13:19 ` [PATCH 03/13] pinctrl: sh-pfc: checker: Add helper for safe name comparison Geert Uytterhoeven
2020-01-10 13:19 ` [PATCH 04/13] pinctrl: sh-pfc: checker: Add check for config register conflicts Geert Uytterhoeven
2020-01-10 13:19 ` [PATCH 05/13] pinctrl: sh-pfc: checker: Add check for enum ID conflicts Geert Uytterhoeven
2020-01-10 13:19 ` [PATCH 06/13] pinctrl: sh-pfc: checker: Improve pin checks Geert Uytterhoeven
2020-01-10 13:19 ` [PATCH 07/13] pinctrl: sh-pfc: checker: Improve pin function checks Geert Uytterhoeven
2020-01-10 13:19 ` [PATCH 08/13] pinctrl: sh-pfc: checker: Improve pin group checks Geert Uytterhoeven
2020-01-10 13:19 ` [PATCH 09/13] pinctrl: sh-pfc: checker: Add drive strength register checks Geert Uytterhoeven
2020-01-10 13:19 ` [PATCH 10/13] pinctrl: sh-pfc: checker: Add bias " Geert Uytterhoeven
2020-01-10 13:19 ` [PATCH 11/13] pinctrl: sh-pfc: checker: Add ioctrl " Geert Uytterhoeven
2020-01-10 13:19 ` [PATCH 12/13] pinctrl: sh-pfc: checker: Add data " Geert Uytterhoeven
2020-01-10 13:19 ` [PATCH 13/13] pinctrl: sh-pfc: checker: Add function GPIO checks Geert Uytterhoeven
2020-01-10 13:22 ` Geert Uytterhoeven
2020-01-10 20:29 ` Niklas Söderlund [this message]
2020-02-10 13:46 ` [PATCH 00/13] pinctrl: sh-pfc: checker: Various improvements Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110202950.GA695049@oden.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).