From: Jacopo Mondi <jacopo@jmondi.org>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: linux-renesas-soc@vger.kernel.org,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 1/2] max9286: Split out async registration
Date: Thu, 13 Feb 2020 12:41:12 +0100 [thread overview]
Message-ID: <20200213114112.b6cbskal5ek24uj6@uno.localdomain> (raw)
In-Reply-To: <fef3b258-97b6-8a6a-71ce-f6d44450300b@ideasonboard.com>
[-- Attachment #1: Type: text/plain, Size: 2266 bytes --]
Hi Kieran,
On Thu, Feb 13, 2020 at 10:27:11AM +0000, Kieran Bingham wrote:
> On 13/02/2020 10:20, Jacopo Mondi wrote:
> > Hi Kieran,
> >
> > On Thu, Feb 13, 2020 at 10:07:18AM +0000, Kieran Bingham wrote:
> >> Hi Jacopo,
> >>
> >> On 13/02/2020 09:46, Jacopo Mondi wrote:
> >>> Hi Kieran,
> >>> very nice thanks for handling this
> >>
> >> :-)
> >>
> >>> Just a few minors
> >>
> >> :-s hehe
> >>
> >
> > Turned out to be lengthier than expected :)
> >
> >>>
> >>> On Wed, Feb 12, 2020 at 05:37:26PM +0000, Kieran Bingham wrote:
> >>>> Move all the V4L2 Subdev Async registration so that it can only happen once
> >>>> we know we will not need to -EPROBE_DEFER...
> >>>>
> >>>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> >>>> ---
> >>>> drivers/media/i2c/max9286.c | 88 +++++++++++++++++++++++--------------
> >>>> 1 file changed, 55 insertions(+), 33 deletions(-)
> >>>>
> >>>> diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
> >>>> index 1b4ff3533795..03c5fa232b6d 100644
> >>>> --- a/drivers/media/i2c/max9286.c
> >>>> +++ b/drivers/media/i2c/max9286.c
> >>>> @@ -503,6 +503,49 @@ static const struct v4l2_async_notifier_operations max9286_notify_ops = {
> >>>> .unbind = max9286_notify_unbind,
> >>>> };
> >>>>
> >>>> +static int max9286_v4l2_async_register(struct max9286_priv *priv)
> >>>
> >>> Could you capture in the function name this actually deals with
> >>> notifiers ? Like max9286_notifier_register() or similar...
> >>
> >> I'd like to keep the 'v4l2' in there somewhere...
> >>
> >> max9286_v4l2_notifier_register() ?
> >>
> >> But then maybe even that could be confused with the notifiers/async
> >> handling for the max9286 itself.
> >>
> >> My aim was that max9286_v4l2_async_{un,}register() dealt with subdevices
> >> connected to the max9286 only ...
> >
> > To me async_register() calls for dealing with registering our own
> > subdev to the async framework, not collecting remote asds and adding
> > it our subnotifier. As you wish, it's really just a suggestion.
>
>
> So would you like to see the async registration between the max9286 and
> the connected CSI2 receiver handled in this pair of functions too?
>
No no, I was just bikeshedding on function names, no worries :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-02-13 11:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 17:37 [PATCH 0/2] max9286: Refactor V4L2 support to prevent EPROBE_DEFER failures Kieran Bingham
2020-02-12 17:37 ` [PATCH 1/2] max9286: Split out async registration Kieran Bingham
2020-02-12 17:39 ` Kieran Bingham
2020-02-13 9:46 ` Jacopo Mondi
2020-02-13 10:07 ` Kieran Bingham
2020-02-13 10:15 ` Kieran Bingham
2020-02-13 10:20 ` Jacopo Mondi
2020-02-13 10:27 ` Kieran Bingham
2020-02-13 11:41 ` Jacopo Mondi [this message]
2020-02-12 17:37 ` [PATCH 2/2] max9286: Collect all V4L2 registrations Kieran Bingham
2020-02-13 10:21 ` [PATCH] max9286: balance v4l2_async refcnting Kieran Bingham
2020-02-13 13:06 ` Kieran Bingham
2020-02-13 13:11 ` Jacopo Mondi
2020-02-13 13:28 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213114112.b6cbskal5ek24uj6@uno.localdomain \
--to=jacopo@jmondi.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).