From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26A1BC352A3 for ; Sat, 15 Feb 2020 05:36:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DD0222082F for ; Sat, 15 Feb 2020 05:36:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cIxrqNRp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725829AbgBOFgK (ORCPT ); Sat, 15 Feb 2020 00:36:10 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:40817 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725774AbgBOFgK (ORCPT ); Sat, 15 Feb 2020 00:36:10 -0500 Received: by mail-pf1-f195.google.com with SMTP id q8so5996523pfh.7 for ; Fri, 14 Feb 2020 21:36:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=umSLSqFdcTUcW15IlOni/Tuec1i7imfq7Q7J9RYYX4g=; b=cIxrqNRp65WCtK+fiYn9g3PVPZKXWCeUB0uFKNIzbK215QX3Al36Ke7lSPKliczQPG zRn7Bi6DqLKPjlqWNiNyIv1hfnOjroG9dJAo7zBVoxdcOscAu96nnIAHZ0M1KbXjm0Sl ZR04ZlFB/h9Rx1G6+2XpmHZ6qc00E2hKTf9RBjGMhvM/S7iYiuAY2TTttm/rFAuLs3bq Tl4EPCrQfsVTe0Oz0o9vN+XxWzhv+LiQ+CYz/xTgBuLMVClebtR7iuNxNAyHBtWlm0Wp bHYgpgS19tzczImghBSGzs7yS4YbFHy+7+42F6gNr1Xyalax7P6gX0gNY6JBKTkCYKiJ SqhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=umSLSqFdcTUcW15IlOni/Tuec1i7imfq7Q7J9RYYX4g=; b=hLEH0AUHKrzbZtSqmxnd7YgeTeJh1wu+wJUzQoqxS66iz/vIF+b9Ibgw/x43DF+ac8 2fZos0nDWOioppYekJW+65TVno5u3vAbeVcAJ0DWcHk6OTGOzdL+MPnWlEmFOOqWbJos +BaJj3gymrQWIWnxiU7mDrhUQNWKU8akIW1suMPdBwjEJmbWFa6hWMF9XFUq/vFetzCc KVodRlmuR0yWlYgDDd1qdZE0jGJmsUT+u5mmAQ2vLatwCot6OXfR6duOEMVqKfdPHDZT QhhRS1aKIlwnMFsRqSNhLDYSWoyYF5JzntKzo62IhbJqpiRmyB4LT2FiEM+AyQA+u0WO vPSA== X-Gm-Message-State: APjAAAVzGXCks7pgudlJtr3+thHTe+//Ic2NUC8QlcLI0UcjCX2w7I+i hGYW5ZzPP3p+bhZkGGk2KqZ2iw== X-Google-Smtp-Source: APXvYqzk4mzSWnD3eisseNOAoKEFSWYJ3iXu/MnMV3x1ieUnd9jyOy7C/UGmCSr9X/1fRkBJKg6m3w== X-Received: by 2002:a62:6842:: with SMTP id d63mr6945184pfc.113.1581744969478; Fri, 14 Feb 2020 21:36:09 -0800 (PST) Received: from ripper (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id q12sm8411743pfh.158.2020.02.14.21.36.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2020 21:36:08 -0800 (PST) Date: Fri, 14 Feb 2020 21:35:17 -0800 From: Bjorn Andersson To: Matti Vaittinen Cc: mazziesaccount@gmail.com, Linus Walleij , Eric Anholt , Stefan Wahren , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Sean Wang , Matthias Brugger , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Chen-Yu Tsai , Paul Cercueil , Neil Armstrong , Heiko Stuebner , Geert Uytterhoeven , Patrice Chotard , Maxime Coquelin , Alexandre Torgue , Andy Gross , linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-oxnas@groups.io, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION Message-ID: <20200215053517.GN955802@ripper> References: <20191112141819.GA22076@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191112141819.GA22076@localhost.localdomain> Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Tue 12 Nov 06:18 PST 2019, Matti Vaittinen wrote: > diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c > index 763da0be10d6..8844ca1261d5 100644 > --- a/drivers/pinctrl/qcom/pinctrl-msm.c > +++ b/drivers/pinctrl/qcom/pinctrl-msm.c > @@ -485,8 +485,8 @@ static int msm_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) > > val = msm_readl_ctl(pctrl, g); > > - /* 0 = output, 1 = input */ > - return val & BIT(g->oe_bit) ? 0 : 1; > + return val & BIT(g->oe_bit) ? GPIO_LINE_DIRECTION_OUT : > + GPIO_LINE_DIRECTION_IN; For pinctrl-msm: Reviewed-by: Bjorn Andersson > } Regards, Bjorn