From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: "Helen Koike" <helen.koike@collabora.com>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Subject: Re: [PATCH v4 2/3] rcar-vin: Make use of V4L2_CAP_IO_MC
Date: Wed, 11 Mar 2020 03:11:24 +0200 [thread overview]
Message-ID: <20200311011124.GD4871@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200306163935.805333-3-niklas.soderlund@ragnatech.se>
Hi Niklas,
Thank you for the patch.
On Fri, Mar 06, 2020 at 05:39:34PM +0100, Niklas Söderlund wrote:
> From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>
> Set the V4L2_CAP_IO_MC capability flag and remove the driver specific
> vidioc_enum_input, vidioc_g_input and vidioc_s_input callbacks for the
> media controller enabled part of the driver.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/platform/rcar-vin/rcar-v4l2.c | 17 +----------------
> 1 file changed, 1 insertion(+), 16 deletions(-)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c b/drivers/media/platform/rcar-vin/rcar-v4l2.c
> index 5151a3cd8a6e6754..96ddd36619167fd5 100644
> --- a/drivers/media/platform/rcar-vin/rcar-v4l2.c
> +++ b/drivers/media/platform/rcar-vin/rcar-v4l2.c
> @@ -767,18 +767,6 @@ static int rvin_mc_s_fmt_vid_cap(struct file *file, void *priv,
> return 0;
> }
>
> -static int rvin_mc_enum_input(struct file *file, void *priv,
> - struct v4l2_input *i)
> -{
> - if (i->index != 0)
> - return -EINVAL;
> -
> - i->type = V4L2_INPUT_TYPE_CAMERA;
> - strscpy(i->name, "Camera", sizeof(i->name));
> -
> - return 0;
> -}
> -
> static const struct v4l2_ioctl_ops rvin_mc_ioctl_ops = {
> .vidioc_querycap = rvin_querycap,
> .vidioc_try_fmt_vid_cap = rvin_mc_try_fmt_vid_cap,
> @@ -786,10 +774,6 @@ static const struct v4l2_ioctl_ops rvin_mc_ioctl_ops = {
> .vidioc_s_fmt_vid_cap = rvin_mc_s_fmt_vid_cap,
> .vidioc_enum_fmt_vid_cap = rvin_enum_fmt_vid_cap,
>
> - .vidioc_enum_input = rvin_mc_enum_input,
> - .vidioc_g_input = rvin_g_input,
> - .vidioc_s_input = rvin_s_input,
> -
> .vidioc_reqbufs = vb2_ioctl_reqbufs,
> .vidioc_create_bufs = vb2_ioctl_create_bufs,
> .vidioc_querybuf = vb2_ioctl_querybuf,
> @@ -961,6 +945,7 @@ int rvin_v4l2_register(struct rvin_dev *vin)
> vin->format.colorspace = RVIN_DEFAULT_COLORSPACE;
>
> if (vin->info->use_mc) {
> + vdev->device_caps |= V4L2_CAP_IO_MC;
> vdev->ioctl_ops = &rvin_mc_ioctl_ops;
> } else {
> vdev->ioctl_ops = &rvin_ioctl_ops;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-03-11 1:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 16:39 [PATCH v4 0/3] v4l2-dev/ioctl: Add V4L2_CAP_IO_MC Niklas Söderlund
2020-03-06 16:39 ` [PATCH v4 1/3] " Niklas Söderlund
2020-03-09 13:47 ` Sakari Ailus
2020-03-09 13:53 ` Hans Verkuil
2020-03-09 13:56 ` Sakari Ailus
2020-03-09 14:10 ` Hans Verkuil
2020-03-09 14:22 ` Sakari Ailus
2020-03-09 13:52 ` Sakari Ailus
2020-03-11 1:10 ` Laurent Pinchart
2020-03-06 16:39 ` [PATCH v4 2/3] rcar-vin: Make use of V4L2_CAP_IO_MC Niklas Söderlund
2020-03-11 1:11 ` Laurent Pinchart [this message]
2020-03-06 16:39 ` [PATCH v4 3/3] staging/intel-ipu3: " Niklas Söderlund
2020-03-09 13:53 ` Sakari Ailus
2020-03-11 1:12 ` Laurent Pinchart
2020-03-09 13:25 ` [PATCH v4 0/3] v4l2-dev/ioctl: Add V4L2_CAP_IO_MC Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311011124.GD4871@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=niklas.soderlund@ragnatech.se \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).