From: Wolfram Sang <wsa@the-dreams.de>
To: linux-spi@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
Mark Brown <broonie@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: [PATCH] spi: acpi: remove superfluous parameter check
Date: Thu, 12 Mar 2020 14:45:07 +0100 [thread overview]
Message-ID: <20200312134507.10000-1-wsa@the-dreams.de> (raw)
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
to_spi_device() already checks 'dev'. No need to do it before calling
it.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Found while fiddling with bus_find_device_by_acpi_dev() in the I2C
subsystem.
drivers/spi/spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 755221bc3745..75978b6c5834 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -4034,7 +4034,7 @@ static struct spi_device *acpi_spi_find_device_by_adev(struct acpi_device *adev)
struct device *dev;
dev = bus_find_device_by_acpi_dev(&spi_bus_type, adev);
- return dev ? to_spi_device(dev) : NULL;
+ return to_spi_device(dev);
}
static int acpi_spi_notify(struct notifier_block *nb, unsigned long value,
--
2.20.1
next reply other threads:[~2020-03-12 13:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 13:45 Wolfram Sang [this message]
2020-03-12 14:14 ` [PATCH] spi: acpi: remove superfluous parameter check Geert Uytterhoeven
2020-03-12 14:28 ` Niklas Söderlund
2020-03-12 17:38 ` Applied "spi: acpi: remove superfluous parameter check" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312134507.10000-1-wsa@the-dreams.de \
--to=wsa@the-dreams.de \
--cc=broonie@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).