From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E19BAC10DCE for ; Thu, 12 Mar 2020 14:28:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B696720650 for ; Thu, 12 Mar 2020 14:28:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech-se.20150623.gappssmtp.com header.i=@ragnatech-se.20150623.gappssmtp.com header.b="WlUjE7ee" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727534AbgCLO2q (ORCPT ); Thu, 12 Mar 2020 10:28:46 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:42278 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727518AbgCLO2q (ORCPT ); Thu, 12 Mar 2020 10:28:46 -0400 Received: by mail-lj1-f193.google.com with SMTP id q19so6638274ljp.9 for ; Thu, 12 Mar 2020 07:28:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=wkUnkIL0e/rtPLFDdVkLiF07+cIlvDNfDcO1JSkyZI4=; b=WlUjE7eepBgGbA4RoEeoesjQgHfWlYXpCSFWO57dJ5D5WTglPRmgkTtessjbP7tjVu YzJo4NS1WtRUcvO/ZGPv0sXNpEXGyfYNJOUA3OsKcWZA4s75vSBOPvLGx4tmuLUa8R3T kAiquNcyy15hGvGi1IxIXXFokro4xVA6lrRW6QzI543Au22Ye57AeEYwdl0dbtV14plW 3ibxOhDEcbSezDd4D/LQQdCjIYOSeDy7DcN7EbjwSVb/7NUq/sJ52g+aAULLrmAfcP4z smrGuivoeBRLW1mDqa4V0NA5uuKbeL5ScOIS2YqmYtvI5oCV8npdXZzPPmbe/JHKC3H6 GE0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=wkUnkIL0e/rtPLFDdVkLiF07+cIlvDNfDcO1JSkyZI4=; b=Cjnxlxt1jx9lobymNpEwyP8qwVUkX9UqmfAXcd1+EmNfbtFJSNf1omLwbDySjrem8b YtD1Tz21id0awoUt6Ukz4pX4Oi1F3lt3hIppY9Vf2i4BmM9F0Mrptmn5FELyZs9Vdw6V 7bmBw3pu3+HdFcim2xScqlfzTa2cXYgwFN1HUebY9xwgnMvaz60X10LPi5SObAHg9VQp +xO2HG3B5hoogvGMtcRNvKd8X9OiIzG/wy+lKMCT3SRaxELnacWCZmBibpBXPhnEaDX1 TDPbfpgO9WB5xHwpud1dBAKdhKHUTSN+bpI08pVMcEln+onf9q/6jQPwRJkWqrPxSnuo F9Cg== X-Gm-Message-State: ANhLgQ3gPc0q/lYBCj7c6jLzVfPMqDiLDXC6jfSk3kh5y/ykBM/ZYkBH dciR0KnU732gXShm8HOoWXWR6w== X-Google-Smtp-Source: ADFU+vtRZ9aSvDfEDAe4PWAVfE2EXngpJ4HRI4zpaR769zc92kWMK2r5W3q4475q4O5Ki8zlATdXyQ== X-Received: by 2002:a2e:2e13:: with SMTP id u19mr4473390lju.3.1584023322663; Thu, 12 Mar 2020 07:28:42 -0700 (PDT) Received: from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138]) by smtp.gmail.com with ESMTPSA id x13sm14807277lfq.97.2020.03.12.07.28.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2020 07:28:41 -0700 (PDT) Date: Thu, 12 Mar 2020 15:28:41 +0100 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Wolfram Sang Cc: linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Mark Brown , Wolfram Sang Subject: Re: [PATCH] spi: acpi: remove superfluous parameter check Message-ID: <20200312142841.GC791432@oden.dyn.berto.se> References: <20200312134507.10000-1-wsa@the-dreams.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200312134507.10000-1-wsa@the-dreams.de> Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Wolfram, Thanks for your work. On 2020-03-12 14:45:07 +0100, Wolfram Sang wrote: > From: Wolfram Sang > > to_spi_device() already checks 'dev'. No need to do it before calling > it. > > Signed-off-by: Wolfram Sang Reviewed-by: Niklas Söderlund > --- > > Found while fiddling with bus_find_device_by_acpi_dev() in the I2C > subsystem. > > drivers/spi/spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index 755221bc3745..75978b6c5834 100644 > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -4034,7 +4034,7 @@ static struct spi_device *acpi_spi_find_device_by_adev(struct acpi_device *adev) > struct device *dev; > > dev = bus_find_device_by_acpi_dev(&spi_bus_type, adev); > - return dev ? to_spi_device(dev) : NULL; > + return to_spi_device(dev); > } > > static int acpi_spi_notify(struct notifier_block *nb, unsigned long value, > -- > 2.20.1 > -- Regards, Niklas Söderlund