From: Wolfram Sang <wsa@the-dreams.de>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: "Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH RFT 1/3] mmc: renesas_sdhi: refactor calculation of best TAP
Date: Tue, 7 Apr 2020 17:06:03 +0200 [thread overview]
Message-ID: <20200407150603.GB4308@ninjato> (raw)
In-Reply-To: <TYAPR01MB4544AD566F267EB89F479C3CD8CF0@TYAPR01MB4544.jpnprd01.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 426 bytes --]
Hi Shimoda-san,
> + if (re - 1 - rs + 1 > tap_cnt) { // "if (re - rs > tap_cnt)" is more better?
Oops, looks really like an off-by-one error on my side :( Yes, I think
're - rs' is good here...
> + tap_end = re - 1;
... plain 'tap_end = re;' here ...
> + tap_start = rs;
> + tap_cnt = tap_end - tap_start + 1;
... and drop the '+ 1' here.
I will double check, and resend soon.
Thank you very much!
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-04-07 15:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 9:31 [PATCH RFT 0/3] mmc: renesas_sdhi: improve TAP selection if all TAPs are good Wolfram Sang
2020-03-06 9:31 ` [PATCH RFT 1/3] mmc: renesas_sdhi: refactor calculation of best TAP Wolfram Sang
2020-03-26 7:04 ` Yoshihiro Shimoda
2020-04-07 15:06 ` Wolfram Sang [this message]
2020-03-06 9:31 ` [PATCH RFT 2/3] mmc: renesas_sdhi: clarify handling of selecting TAPs Wolfram Sang
2020-03-26 7:06 ` Yoshihiro Shimoda
2020-03-06 9:31 ` [PATCH RFT 3/3] mmc: renesas_sdhi: improve TAP selection if all TAPs are good Wolfram Sang
2020-03-26 7:14 ` Yoshihiro Shimoda
2020-03-26 8:38 ` [PATCH RFT 0/3] " Yoshihiro Shimoda
2020-04-07 15:07 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200407150603.GB4308@ninjato \
--to=wsa@the-dreams.de \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).