From: Andrew Lunn <andrew@lunn.ch>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
David Jander <david@protonic.nl>,
"David S. Miller" <davem@davemloft.net>,
Sascha Hauer <kernel@pengutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Philippe Schenker <philippe.schenker@toradex.com>,
Russell King <linux@armlinux.org.uk>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY
Date: Tue, 28 Apr 2020 17:47:18 +0200 [thread overview]
Message-ID: <20200428154718.GA24923@lunn.ch> (raw)
In-Reply-To: <CAMuHMdU1ZmSm_tjtWxoFNako2fzmranGVz5qqD2YRNEFRjX0Sw@mail.gmail.com>
On Tue, Apr 28, 2020 at 05:28:30PM +0200, Geert Uytterhoeven wrote:
> This triggers on Renesas Salvator-X(S):
>
> Micrel KSZ9031 Gigabit PHY e6800000.ethernet-ffffffff:00:
> *-skew-ps values should be used only with phy-mode = "rgmii"
>
> which uses:
>
> phy-mode = "rgmii-txid";
>
> and:
>
> rxc-skew-ps = <1500>;
>
> If I understand Documentation/devicetree/bindings/net/ethernet-controller.yaml
> correctly:
Hi Geert
Checking for skews which might contradict the PHY-mode is new. I think
this is the first PHY driver to do it. So i'm not too surprised it has
triggered a warning, or there is contradictory documentation.
Your use cases is reasonable. Have the normal transmit delay, and a
bit shorted receive delay. So we should allow it. It just makes the
validation code more complex :-(
Andrew
next prev parent reply other threads:[~2020-04-28 15:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200422072137.8517-1-o.rempel@pengutronix.de>
2020-04-28 15:28 ` [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY Geert Uytterhoeven
2020-04-28 15:47 ` Andrew Lunn [this message]
2020-04-28 16:16 ` Philippe Schenker
2020-04-29 8:45 ` Geert Uytterhoeven
2020-04-29 9:26 ` Oleksij Rempel
2020-05-27 19:11 ` Geert Uytterhoeven
2020-05-27 20:52 ` Andrew Lunn
2020-05-28 13:10 ` Geert Uytterhoeven
2020-05-28 16:08 ` Andrew Lunn
2020-05-29 4:59 ` Oleksij Rempel
2020-05-29 10:17 ` Geert Uytterhoeven
2020-05-28 8:20 ` Philippe Schenker
2020-05-28 12:51 ` Geert Uytterhoeven
2020-05-28 23:31 ` Florian Fainelli
2020-04-29 10:02 ` Philippe Schenker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428154718.GA24923@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=david@protonic.nl \
--cc=f.fainelli@gmail.com \
--cc=geert@linux-m68k.org \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=philippe.schenker@toradex.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).