From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38989C47254 for ; Fri, 1 May 2020 21:52:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07CEC216FD for ; Fri, 1 May 2020 21:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588369951; bh=1D8RX5PJmzztVI5nfEj33i+vmKP0DavgpDBKvVSk568=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=g4DowKsHUSPcBEDAapbp40bTbtt5wcGukdrEerOIB7ElnF5lWD7LutaiCx4tPhpOu ZobpbHxtVZtg9mE1bSSHkw/MuFXm3Eqca8Yf72vG2Kw5AHMsdPS2DUOoLpzhEqWo+2 7YyQBrELD4P3mDWLDwnofro4iZxRww0HumD7sWcc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726809AbgEAVwa (ORCPT ); Fri, 1 May 2020 17:52:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:53038 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726344AbgEAVwa (ORCPT ); Fri, 1 May 2020 17:52:30 -0400 Received: from localhost (mobile-166-175-184-168.mycingular.net [166.175.184.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DD3192166E; Fri, 1 May 2020 21:52:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588369950; bh=1D8RX5PJmzztVI5nfEj33i+vmKP0DavgpDBKvVSk568=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=2LiI5Q41sZ7IuVg7kSvKqmCGXVMVME7kMGXqKF2+jaeheYWJL/4CIvP5pvEGDXguJ wtJz99iTMpRUQ+gy5D9c3J/4iuMiojxBSic2TWDEQLCoECxlkHf1Z4Fu0nOMy+70Vh KetefdBdu87qgfpUH29HuJem5emKyLn+lmCOFnkY= Date: Fri, 1 May 2020 16:52:28 -0500 From: Bjorn Helgaas To: Lorenzo Pieralisi Cc: marek.vasut@gmail.com, linux-pci@vger.kernel.org, Marek Vasut , Bjorn Helgaas , Geert Uytterhoeven , Wolfram Sang , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] PCI: pcie-rcar: Cache PHY init function pointer Message-ID: <20200501215228.GA136733@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200428083231.GC12459@e121166-lin.cambridge.arm.com> Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Tue, Apr 28, 2020 at 09:32:31AM +0100, Lorenzo Pieralisi wrote: > On Sun, Apr 26, 2020 at 02:31:47PM +0200, marek.vasut@gmail.com wrote: > > From: Marek Vasut > > > > The PHY initialization function pointer does not change during the > > lifetime of the driver instance, it is therefore sufficient to get > > the pointer in .probe(), cache it in driver private data, and just > > call the function through the cached pointer in .resume(). > > > > Signed-off-by: Marek Vasut > > Cc: Bjorn Helgaas > > Cc: Lorenzo Pieralisi > > Cc: Geert Uytterhoeven > > Cc: Wolfram Sang > > Cc: linux-renesas-soc@vger.kernel.org > > --- > > NOTE: Based on git://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git > > branch pci/rcar > > NOTE: The driver tag is now 'pcie-rcar' to distinguish it from pci-rcar-gen2.c > > --- > > drivers/pci/controller/pcie-rcar.c | 10 ++++------ > > 1 file changed, 4 insertions(+), 6 deletions(-) > > Squashed in https://patchwork.kernel.org/patch/11438665 > > Do you want me to rename the $SUBJECT (and the branch name while at it) > in the patches in my pci/rcar branch ("PCI: pcie-rcar: ...") to start > the commit subject tag renaming from this cycle (and in the interim you > send a rename for the drivers files ?) My vote is a tag of "rcar" for the pcie-rcar driver because almost all new drivers are PCIe, and none of the others use "pcie-" in the tag. For pci-rcar-gen2.c, we could use "rcar-gen2" (already used by the last 5 commits, last touched over two years ago). It's slightly confusing to use "gen2" to refer to some internal R-Car thing instead of PCIe Gen 2, so we could use something like "rcar-pci", but I'm not sure it's worth it. Bjorn