linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: timer: renesas: ostm: Convert to json-schema
@ 2020-04-27 19:32 Geert Uytterhoeven
  2020-04-28  2:29 ` Niklas Söderlund
  2020-05-12  1:57 ` Rob Herring
  0 siblings, 2 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2020-04-27 19:32 UTC (permalink / raw)
  To: Daniel Lezcano, Thomas Gleixner, Rob Herring, Chris Brandt
  Cc: devicetree, linux-renesas-soc, linux-kernel, Geert Uytterhoeven

Convert the Renesas OS Timer (OSTM) Device Tree binding documentation to
json-schema.

Document missing properties.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
For a clean dtbs_check, this depends on "[PATCH] ARM: dts: r7s9210: Remove
bogus clock-names from OSTM nodes"
(https://lore.kernel.org/r/20200427192932.28967-1-geert+renesas@glider.be)
which I intend to queue as a fix for v5.7.

 .../bindings/timer/renesas,ostm.txt           | 31 ----------
 .../bindings/timer/renesas,ostm.yaml          | 59 +++++++++++++++++++
 2 files changed, 59 insertions(+), 31 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/timer/renesas,ostm.txt
 create mode 100644 Documentation/devicetree/bindings/timer/renesas,ostm.yaml

diff --git a/Documentation/devicetree/bindings/timer/renesas,ostm.txt b/Documentation/devicetree/bindings/timer/renesas,ostm.txt
deleted file mode 100644
index 81a78f8bcf170a82..0000000000000000
--- a/Documentation/devicetree/bindings/timer/renesas,ostm.txt
+++ /dev/null
@@ -1,31 +0,0 @@
-* Renesas OS Timer (OSTM)
-
-The OSTM is a multi-channel 32-bit timer/counter with fixed clock
-source that can operate in either interval count down timer or free-running
-compare match mode.
-
-Channels are independent from each other.
-
-Required Properties:
-
-  - compatible: must be one or more of the following:
-    - "renesas,r7s72100-ostm" for the R7S72100 (RZ/A1) OSTM
-    - "renesas,r7s9210-ostm" for the R7S9210 (RZ/A2) OSTM
-    - "renesas,ostm" for any OSTM
-		This is a fallback for the above renesas,*-ostm entries
-
-  - reg: base address and length of the register block for a timer channel.
-
-  - interrupts: interrupt specifier for the timer channel.
-
-  - clocks: clock specifier for the timer channel.
-
-Example: R7S72100 (RZ/A1H) OSTM node
-
-	ostm0: timer@fcfec000 {
-		compatible = "renesas,r7s72100-ostm", "renesas,ostm";
-		reg = <0xfcfec000 0x30>;
-		interrupts = <GIC_SPI 102 IRQ_TYPE_EDGE_RISING>;
-		clocks = <&mstp5_clks R7S72100_CLK_OSTM0>;
-		power-domains = <&cpg_clocks>;
-	};
diff --git a/Documentation/devicetree/bindings/timer/renesas,ostm.yaml b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
new file mode 100644
index 0000000000000000..600d47ab7d58570f
--- /dev/null
+++ b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/timer/renesas,ostm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Renesas OS Timer (OSTM)
+
+maintainers:
+  - Chris Brandt <chris.brandt@renesas.com>
+  - Geert Uytterhoeven <geert+renesas@glider.be>
+
+description:
+  The OSTM is a multi-channel 32-bit timer/counter with fixed clock source that
+  can operate in either interval count down timer or free-running compare match
+  mode.
+
+  Channels are independent from each other.
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - renesas,r7s72100-ostm # RZ/A1H
+          - renesas,r7s9210-ostm  # RZ/A2M
+      - const: renesas,ostm       # Generic
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  power-domains:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - power-domains
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/r7s72100-clock.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    ostm0: timer@fcfec000 {
+            compatible = "renesas,r7s72100-ostm", "renesas,ostm";
+            reg = <0xfcfec000 0x30>;
+            interrupts = <GIC_SPI 102 IRQ_TYPE_EDGE_RISING>;
+            clocks = <&mstp5_clks R7S72100_CLK_OSTM0>;
+            power-domains = <&cpg_clocks>;
+    };
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: timer: renesas: ostm: Convert to json-schema
  2020-04-27 19:32 [PATCH] dt-bindings: timer: renesas: ostm: Convert to json-schema Geert Uytterhoeven
@ 2020-04-28  2:29 ` Niklas Söderlund
  2020-04-28  2:31   ` Niklas Söderlund
  2020-05-12  1:57 ` Rob Herring
  1 sibling, 1 reply; 4+ messages in thread
From: Niklas Söderlund @ 2020-04-28  2:29 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Daniel Lezcano, Thomas Gleixner, Rob Herring, Chris Brandt,
	devicetree, linux-renesas-soc, linux-kernel

Hi Geert,

Thanks for your patch.

On 2020-04-27 21:32:24 +0200, Geert Uytterhoeven wrote:
> Convert the Renesas OS Timer (OSTM) Device Tree binding documentation to
> json-schema.
> 
> Document missing properties.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

> ---
> For a clean dtbs_check, this depends on "[PATCH] ARM: dts: r7s9210: Remove
> bogus clock-names from OSTM nodes"
> (https://lore.kernel.org/r/20200427192932.28967-1-geert+renesas@glider.be)
> which I intend to queue as a fix for v5.7.
> 
>  .../bindings/timer/renesas,ostm.txt           | 31 ----------
>  .../bindings/timer/renesas,ostm.yaml          | 59 +++++++++++++++++++
>  2 files changed, 59 insertions(+), 31 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/timer/renesas,ostm.txt
>  create mode 100644 Documentation/devicetree/bindings/timer/renesas,ostm.yaml
> 
> diff --git a/Documentation/devicetree/bindings/timer/renesas,ostm.txt b/Documentation/devicetree/bindings/timer/renesas,ostm.txt
> deleted file mode 100644
> index 81a78f8bcf170a82..0000000000000000
> --- a/Documentation/devicetree/bindings/timer/renesas,ostm.txt
> +++ /dev/null
> @@ -1,31 +0,0 @@
> -* Renesas OS Timer (OSTM)
> -
> -The OSTM is a multi-channel 32-bit timer/counter with fixed clock
> -source that can operate in either interval count down timer or free-running
> -compare match mode.
> -
> -Channels are independent from each other.
> -
> -Required Properties:
> -
> -  - compatible: must be one or more of the following:
> -    - "renesas,r7s72100-ostm" for the R7S72100 (RZ/A1) OSTM
> -    - "renesas,r7s9210-ostm" for the R7S9210 (RZ/A2) OSTM
> -    - "renesas,ostm" for any OSTM
> -		This is a fallback for the above renesas,*-ostm entries
> -
> -  - reg: base address and length of the register block for a timer channel.
> -
> -  - interrupts: interrupt specifier for the timer channel.
> -
> -  - clocks: clock specifier for the timer channel.
> -
> -Example: R7S72100 (RZ/A1H) OSTM node
> -
> -	ostm0: timer@fcfec000 {
> -		compatible = "renesas,r7s72100-ostm", "renesas,ostm";
> -		reg = <0xfcfec000 0x30>;
> -		interrupts = <GIC_SPI 102 IRQ_TYPE_EDGE_RISING>;
> -		clocks = <&mstp5_clks R7S72100_CLK_OSTM0>;
> -		power-domains = <&cpg_clocks>;
> -	};
> diff --git a/Documentation/devicetree/bindings/timer/renesas,ostm.yaml b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
> new file mode 100644
> index 0000000000000000..600d47ab7d58570f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/timer/renesas,ostm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas OS Timer (OSTM)
> +
> +maintainers:
> +  - Chris Brandt <chris.brandt@renesas.com>
> +  - Geert Uytterhoeven <geert+renesas@glider.be>
> +
> +description:
> +  The OSTM is a multi-channel 32-bit timer/counter with fixed clock source that
> +  can operate in either interval count down timer or free-running compare match
> +  mode.
> +
> +  Channels are independent from each other.
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - renesas,r7s72100-ostm # RZ/A1H
> +          - renesas,r7s9210-ostm  # RZ/A2M
> +      - const: renesas,ostm       # Generic
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  power-domains:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - power-domains
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/r7s72100-clock.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    ostm0: timer@fcfec000 {
> +            compatible = "renesas,r7s72100-ostm", "renesas,ostm";
> +            reg = <0xfcfec000 0x30>;
> +            interrupts = <GIC_SPI 102 IRQ_TYPE_EDGE_RISING>;
> +            clocks = <&mstp5_clks R7S72100_CLK_OSTM0>;
> +            power-domains = <&cpg_clocks>;
> +    };
> -- 
> 2.17.1
> 

-- 
Regards,
Niklas Söderlund

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: timer: renesas: ostm: Convert to json-schema
  2020-04-28  2:29 ` Niklas Söderlund
@ 2020-04-28  2:31   ` Niklas Söderlund
  0 siblings, 0 replies; 4+ messages in thread
From: Niklas Söderlund @ 2020-04-28  2:31 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Daniel Lezcano, Thomas Gleixner, Rob Herring, Chris Brandt,
	devicetree, linux-renesas-soc, linux-kernel

Hi (again) Geert,

On 2020-04-28 04:29:05 +0200, Niklas Söderlund wrote:
> Hi Geert,
> 
> Thanks for your patch.
> 
> On 2020-04-27 21:32:24 +0200, Geert Uytterhoeven wrote:
> > Convert the Renesas OS Timer (OSTM) Device Tree binding documentation to
> > json-schema.
> > 
> > Document missing properties.
> > 
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

Sometimes I type quicker then I think (which is not such a difficult 
taks), that should have been.

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> 
> > ---
> > For a clean dtbs_check, this depends on "[PATCH] ARM: dts: r7s9210: Remove
> > bogus clock-names from OSTM nodes"
> > (https://lore.kernel.org/r/20200427192932.28967-1-geert+renesas@glider.be)
> > which I intend to queue as a fix for v5.7.
> > 
> >  .../bindings/timer/renesas,ostm.txt           | 31 ----------
> >  .../bindings/timer/renesas,ostm.yaml          | 59 +++++++++++++++++++
> >  2 files changed, 59 insertions(+), 31 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/timer/renesas,ostm.txt
> >  create mode 100644 Documentation/devicetree/bindings/timer/renesas,ostm.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/timer/renesas,ostm.txt b/Documentation/devicetree/bindings/timer/renesas,ostm.txt
> > deleted file mode 100644
> > index 81a78f8bcf170a82..0000000000000000
> > --- a/Documentation/devicetree/bindings/timer/renesas,ostm.txt
> > +++ /dev/null
> > @@ -1,31 +0,0 @@
> > -* Renesas OS Timer (OSTM)
> > -
> > -The OSTM is a multi-channel 32-bit timer/counter with fixed clock
> > -source that can operate in either interval count down timer or free-running
> > -compare match mode.
> > -
> > -Channels are independent from each other.
> > -
> > -Required Properties:
> > -
> > -  - compatible: must be one or more of the following:
> > -    - "renesas,r7s72100-ostm" for the R7S72100 (RZ/A1) OSTM
> > -    - "renesas,r7s9210-ostm" for the R7S9210 (RZ/A2) OSTM
> > -    - "renesas,ostm" for any OSTM
> > -		This is a fallback for the above renesas,*-ostm entries
> > -
> > -  - reg: base address and length of the register block for a timer channel.
> > -
> > -  - interrupts: interrupt specifier for the timer channel.
> > -
> > -  - clocks: clock specifier for the timer channel.
> > -
> > -Example: R7S72100 (RZ/A1H) OSTM node
> > -
> > -	ostm0: timer@fcfec000 {
> > -		compatible = "renesas,r7s72100-ostm", "renesas,ostm";
> > -		reg = <0xfcfec000 0x30>;
> > -		interrupts = <GIC_SPI 102 IRQ_TYPE_EDGE_RISING>;
> > -		clocks = <&mstp5_clks R7S72100_CLK_OSTM0>;
> > -		power-domains = <&cpg_clocks>;
> > -	};
> > diff --git a/Documentation/devicetree/bindings/timer/renesas,ostm.yaml b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
> > new file mode 100644
> > index 0000000000000000..600d47ab7d58570f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
> > @@ -0,0 +1,59 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/timer/renesas,ostm.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Renesas OS Timer (OSTM)
> > +
> > +maintainers:
> > +  - Chris Brandt <chris.brandt@renesas.com>
> > +  - Geert Uytterhoeven <geert+renesas@glider.be>
> > +
> > +description:
> > +  The OSTM is a multi-channel 32-bit timer/counter with fixed clock source that
> > +  can operate in either interval count down timer or free-running compare match
> > +  mode.
> > +
> > +  Channels are independent from each other.
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - renesas,r7s72100-ostm # RZ/A1H
> > +          - renesas,r7s9210-ostm  # RZ/A2M
> > +      - const: renesas,ostm       # Generic
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  power-domains:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - clocks
> > +  - power-domains
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/r7s72100-clock.h>
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    ostm0: timer@fcfec000 {
> > +            compatible = "renesas,r7s72100-ostm", "renesas,ostm";
> > +            reg = <0xfcfec000 0x30>;
> > +            interrupts = <GIC_SPI 102 IRQ_TYPE_EDGE_RISING>;
> > +            clocks = <&mstp5_clks R7S72100_CLK_OSTM0>;
> > +            power-domains = <&cpg_clocks>;
> > +    };
> > -- 
> > 2.17.1
> > 
> 
> -- 
> Regards,
> Niklas Söderlund

-- 
Regards,
Niklas Söderlund

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: timer: renesas: ostm: Convert to json-schema
  2020-04-27 19:32 [PATCH] dt-bindings: timer: renesas: ostm: Convert to json-schema Geert Uytterhoeven
  2020-04-28  2:29 ` Niklas Söderlund
@ 2020-05-12  1:57 ` Rob Herring
  1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2020-05-12  1:57 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Rob Herring, linux-renesas-soc, Chris Brandt, Thomas Gleixner,
	Daniel Lezcano, linux-kernel, devicetree

On Mon, 27 Apr 2020 21:32:24 +0200, Geert Uytterhoeven wrote:
> Convert the Renesas OS Timer (OSTM) Device Tree binding documentation to
> json-schema.
> 
> Document missing properties.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> For a clean dtbs_check, this depends on "[PATCH] ARM: dts: r7s9210: Remove
> bogus clock-names from OSTM nodes"
> (https://lore.kernel.org/r/20200427192932.28967-1-geert+renesas@glider.be)
> which I intend to queue as a fix for v5.7.
> 
>  .../bindings/timer/renesas,ostm.txt           | 31 ----------
>  .../bindings/timer/renesas,ostm.yaml          | 59 +++++++++++++++++++
>  2 files changed, 59 insertions(+), 31 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/timer/renesas,ostm.txt
>  create mode 100644 Documentation/devicetree/bindings/timer/renesas,ostm.yaml
> 

Applied, thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-05-12  1:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-27 19:32 [PATCH] dt-bindings: timer: renesas: ostm: Convert to json-schema Geert Uytterhoeven
2020-04-28  2:29 ` Niklas Söderlund
2020-04-28  2:31   ` Niklas Söderlund
2020-05-12  1:57 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).