From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: linux-renesas-soc@vger.kernel.org
Cc: "Kieran Bingham" <kieran.bingham@ideasonboard.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Jacopo Mondi" <jacopo@jmondi.org>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Hyun Kwon" <hyunk@xilinx.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>
Subject: [PATCH v9 2/3] fixes! [max9286]: Don't provide GPIO names
Date: Thu, 14 May 2020 15:00:15 +0100 [thread overview]
Message-ID: <20200514140016.1445489-3-kieran.bingham+renesas@ideasonboard.com> (raw)
In-Reply-To: <20200514140016.1445489-1-kieran.bingham+renesas@ideasonboard.com>
The GPIO line names are fairly unhelpful, other than describing
them as out lines only ... but otherwise ...
Having multiple gpio devices with the same names reports conflicts.
so lets just remove them.
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
drivers/media/i2c/max9286.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
index c8ca1245df4b..66201dc4b7f7 100644
--- a/drivers/media/i2c/max9286.c
+++ b/drivers/media/i2c/max9286.c
@@ -1019,11 +1019,6 @@ static int max9286_register_gpio(struct max9286_priv *priv)
struct gpio_chip *gpio = &priv->gpio;
int ret;
- static const char * const names[] = {
- "GPIO0OUT",
- "GPIO1OUT",
- };
-
/* Configure the GPIO */
gpio->label = dev_name(dev);
gpio->parent = dev;
@@ -1034,7 +1029,6 @@ static int max9286_register_gpio(struct max9286_priv *priv)
gpio->set = max9286_gpio_set;
gpio->get = max9286_gpio_get;
gpio->can_sleep = true;
- gpio->names = names;
/* GPIO values default to high */
priv->gpio_state = BIT(0) | BIT(1);
--
2.25.1
next prev parent reply other threads:[~2020-05-14 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 14:00 [PATCH v9.1 0/3] MAX9286 fixups Kieran Bingham
2020-05-14 14:00 ` [PATCH v9.1 1/3] fixes! [max9286]: Use the same default mbus_fmt everywhere Kieran Bingham
2020-05-14 14:00 ` Kieran Bingham [this message]
2020-05-14 14:00 ` [PATCH v9 3/3] fixes! [max9286]: Fix dev->of_node refcnting Kieran Bingham
2020-05-16 14:25 ` [PATCH v9.1 0/3] MAX9286 fixups Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514140016.1445489-3-kieran.bingham+renesas@ideasonboard.com \
--to=kieran.bingham+renesas@ideasonboard.com \
--cc=hyunk@xilinx.com \
--cc=jacopo@jmondi.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=niklas.soderlund@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).