From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 217ECC433DF for ; Tue, 19 May 2020 11:57:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 097D4207D8 for ; Tue, 19 May 2020 11:57:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728773AbgESL5m (ORCPT ); Tue, 19 May 2020 07:57:42 -0400 Received: from mga12.intel.com ([192.55.52.136]:18100 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726949AbgESL5m (ORCPT ); Tue, 19 May 2020 07:57:42 -0400 IronPort-SDR: F5YMKoU+qMHz1kUB8YfHDcjFhoLUYYLyGBP/VUD3srrqJfDKukutqK2Es39oaWn9Gi0u18cHo0 wOx2S9xuUhgA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2020 04:57:42 -0700 IronPort-SDR: YBmlirqP1mfDY2/shxRL2nz01uQVfsC6fFTTtPR/n2bkG/ZnhNOR6vu9dTc262VIJWmiUccltJ OFYuh7X3uZnQ== X-IronPort-AV: E=Sophos;i="5.73,410,1583222400"; d="scan'208";a="439594040" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2020 04:57:37 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id BBB2920CEF; Tue, 19 May 2020 14:57:35 +0300 (EEST) Date: Tue, 19 May 2020 14:57:35 +0300 From: Sakari Ailus To: Roman Kovalivskyi Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Luis Oliveira , Niklas =?iso-8859-1?Q?S=F6derlund?= , Jacopo Mondi , Michael Rodin , Mauro Carvalho Chehab , Hugues Fruchet , Maxime Ripard , Adam Ford , Todor Tomov , Suresh Udipi , Andrew Gabbasov , Eugeniu Rosca , Dave Stevenson Subject: Re: [PATCH v2 4/6] media: ov5647: Use gpiod_set_value_cansleep Message-ID: <20200519115735.GL20066@paasikivi.fi.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Tue, May 19, 2020 at 04:16:19AM +0300, Roman Kovalivskyi wrote: > From: Dave Stevenson > > All calls to the gpio library are in contexts that can sleep, > therefore there is no issue with having those GPIOs controlled > by controllers which require sleeping (eg I2C GPIO expanders). > > Switch to using gpiod_set_value_cansleep instead of gpiod_set_value > to avoid triggering the warning in gpiolib should the GPIO > controller need to sleep. > > Signed-off-by: Dave Stevenson > Signed-off-by: Roman Kovalivskyi This needs to be merged with the 2nd patch. -- Sakari Ailus