From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE372C433EB for ; Sun, 21 Jun 2020 08:27:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A8592487F for ; Sun, 21 Jun 2020 08:27:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729527AbgFUI1v (ORCPT ); Sun, 21 Jun 2020 04:27:51 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:57612 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729526AbgFUI1v (ORCPT ); Sun, 21 Jun 2020 04:27:51 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id C1FD020028; Sun, 21 Jun 2020 10:27:47 +0200 (CEST) Date: Sun, 21 Jun 2020 10:27:46 +0200 From: Sam Ravnborg To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Jernej Skrabec , Neil Armstrong , Jonas Karlman , Kieran Bingham , linux-renesas-soc@vger.kernel.org, Andrzej Hajda , Thomas Zimmermann Subject: Re: [PATCH 09/27] drm: edid: Constify connector argument to infoframe functions Message-ID: <20200621082746.GL74146@ravnborg.org> References: <20200526011505.31884-1-laurent.pinchart+renesas@ideasonboard.com> <20200526011505.31884-10-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200526011505.31884-10-laurent.pinchart+renesas@ideasonboard.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=edQTgYMH c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=P1BnusSwAAAA:8 a=7gkXJVJtAAAA:8 a=e5mUnYsNAAAA:8 a=7bcR2ZnlydvOFXS2xQoA:9 a=CjuIK1q_8ugA:10 a=D0XLA9XvdZm18NrgonBM:22 a=E9Po1WZjFZOl8hwRPBS3:22 a=Vxmtnl_E_bksehYqCbjh:22 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Tue, May 26, 2020 at 04:14:47AM +0300, Laurent Pinchart wrote: > The drm_hdmi_avi_infoframe_from_display_mode(), > drm_hdmi_vendor_infoframe_from_display_mode() and > drm_hdmi_avi_infoframe_quant_range() functions take a drm_connector that > they don't modify. Mark it as const. > > Signed-off-by: Laurent Pinchart Acked-by: Sam Ravnborg > --- > drivers/gpu/drm/drm_edid.c | 12 ++++++------ > include/drm/drm_edid.h | 6 +++--- > 2 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 3bd95c4b02eb..e6b26f16c21f 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -5365,7 +5365,7 @@ void drm_set_preferred_mode(struct drm_connector *connector, > } > EXPORT_SYMBOL(drm_set_preferred_mode); > > -static bool is_hdmi2_sink(struct drm_connector *connector) > +static bool is_hdmi2_sink(const struct drm_connector *connector) > { > /* > * FIXME: sil-sii8620 doesn't have a connector around when > @@ -5450,7 +5450,7 @@ drm_hdmi_infoframe_set_hdr_metadata(struct hdmi_drm_infoframe *frame, > } > EXPORT_SYMBOL(drm_hdmi_infoframe_set_hdr_metadata); > > -static u8 drm_mode_hdmi_vic(struct drm_connector *connector, > +static u8 drm_mode_hdmi_vic(const struct drm_connector *connector, > const struct drm_display_mode *mode) > { > bool has_hdmi_infoframe = connector ? > @@ -5466,7 +5466,7 @@ static u8 drm_mode_hdmi_vic(struct drm_connector *connector, > return drm_match_hdmi_mode(mode); > } > > -static u8 drm_mode_cea_vic(struct drm_connector *connector, > +static u8 drm_mode_cea_vic(const struct drm_connector *connector, > const struct drm_display_mode *mode) > { > u8 vic; > @@ -5504,7 +5504,7 @@ static u8 drm_mode_cea_vic(struct drm_connector *connector, > */ > int > drm_hdmi_avi_infoframe_from_display_mode(struct hdmi_avi_infoframe *frame, > - struct drm_connector *connector, > + const struct drm_connector *connector, > const struct drm_display_mode *mode) > { > enum hdmi_picture_aspect picture_aspect; > @@ -5651,7 +5651,7 @@ EXPORT_SYMBOL(drm_hdmi_avi_infoframe_colorspace); > */ > void > drm_hdmi_avi_infoframe_quant_range(struct hdmi_avi_infoframe *frame, > - struct drm_connector *connector, > + const struct drm_connector *connector, > const struct drm_display_mode *mode, > enum hdmi_quantization_range rgb_quant_range) > { > @@ -5755,7 +5755,7 @@ s3d_structure_from_display_mode(const struct drm_display_mode *mode) > */ > int > drm_hdmi_vendor_infoframe_from_display_mode(struct hdmi_vendor_infoframe *frame, > - struct drm_connector *connector, > + const struct drm_connector *connector, > const struct drm_display_mode *mode) > { > /* > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > index 34b15e3d070c..43254319ab19 100644 > --- a/include/drm/drm_edid.h > +++ b/include/drm/drm_edid.h > @@ -361,11 +361,11 @@ drm_load_edid_firmware(struct drm_connector *connector) > > int > drm_hdmi_avi_infoframe_from_display_mode(struct hdmi_avi_infoframe *frame, > - struct drm_connector *connector, > + const struct drm_connector *connector, > const struct drm_display_mode *mode); > int > drm_hdmi_vendor_infoframe_from_display_mode(struct hdmi_vendor_infoframe *frame, > - struct drm_connector *connector, > + const struct drm_connector *connector, > const struct drm_display_mode *mode); > > void > @@ -378,7 +378,7 @@ drm_hdmi_avi_infoframe_bars(struct hdmi_avi_infoframe *frame, > > void > drm_hdmi_avi_infoframe_quant_range(struct hdmi_avi_infoframe *frame, > - struct drm_connector *connector, > + const struct drm_connector *connector, > const struct drm_display_mode *mode, > enum hdmi_quantization_range rgb_quant_range); > > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel