From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2484C433E1 for ; Tue, 30 Jun 2020 20:49:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C009220772 for ; Tue, 30 Jun 2020 20:49:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech-se.20150623.gappssmtp.com header.i=@ragnatech-se.20150623.gappssmtp.com header.b="JXQFgrWP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726096AbgF3UtX (ORCPT ); Tue, 30 Jun 2020 16:49:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726119AbgF3UtW (ORCPT ); Tue, 30 Jun 2020 16:49:22 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2EE1C03E979 for ; Tue, 30 Jun 2020 13:49:21 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id 9so24231360ljc.8 for ; Tue, 30 Jun 2020 13:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=xvMzBYx/+eZkL1U4iAm8DZ6iRc4MRD6poHIjEeZk1I0=; b=JXQFgrWPHof0j3cDBxYmxzEqX9RoavpSkASuonw6dNEvCOEvPn6X2dMDaw063EBgEQ KYGF46P6F52DF0TNrG7OrpNghsS8Ls3+ozRCcOWE+PRp4wsxTvwvUX6Xgy7UlVRbT/gU 82vG4ANNWRsprwLsb9SYwpZnKTrVt+JUaHCISqJZGGfDuJxy5Nl24LfxZ3NWdYSYwfoG xO3FrjHlpPN3NT8+jl85xT64F0jnPOuR8LgSWG9xSn65OMEifV73tw0WfZm6FArgHmMP Uj4fpkYzuK8FVBsDLRO3ID5ZQbhmgTsAxE36chU8KC0ny2Je80/vq31H68vWx63swFWX oEDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=xvMzBYx/+eZkL1U4iAm8DZ6iRc4MRD6poHIjEeZk1I0=; b=o7AvzlybA648OnH4Uz0IDOyE1W/fSDcxP/0dVSY5lMwVQH5BPsrn9Tg3vsyvd8FiNR rUze3dt7m0loBQ7fe/QCZNRnrskMOcKafNxp13UQ7i7YhisJQkYUzrolY1jVFfAgNgqt 8snPX8QJjNSHhDJiVctu18ri1HPYhSHos8WMZ2lHlof6jvTH1Rz9D9ZuSHQvxsrFoOCL EYcZQXx++KG0r9BCVJ+NrZ0HvSyPX9PVsmjKnnzdbfMOkCKVqjUMDrotFWR4wq8TZXHa pQe8tDxq4U+jDH+W9vqpwYaLrBV4pCRUKEBsUbiqn64N3ZmrNpW4gDGb+WR7vk6LM40X 0EuA== X-Gm-Message-State: AOAM532hvNm9dSUPPH4S320Gf5b3YkiPfGFc3IwME2suhCg6LgkeBlw0 eZBUsxVSsLE6JEFLwI85Ww+aJg== X-Google-Smtp-Source: ABdhPJyvN++jQvWmhL1Nhi4QY7ErV0bsXsbkHZP2JNUtRN07KQpUgLR60RQJZ/BTWYqFLoid4vKvUg== X-Received: by 2002:a2e:580f:: with SMTP id m15mr11054422ljb.357.1593550159379; Tue, 30 Jun 2020 13:49:19 -0700 (PDT) Received: from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203]) by smtp.gmail.com with ESMTPSA id q1sm1195630lfp.42.2020.06.30.13.49.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 13:49:18 -0700 (PDT) Date: Tue, 30 Jun 2020 22:49:18 +0200 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Rob Herring Subject: Re: [PATCH v2 1/8] dt-bindings: media: renesas,fcp: Convert binding to YAML Message-ID: <20200630204918.GA2365286@oden.dyn.berto.se> References: <20200621004734.28602-1-laurent.pinchart+renesas@ideasonboard.com> <20200621004734.28602-2-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200621004734.28602-2-laurent.pinchart+renesas@ideasonboard.com> Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Laurent, Thanks for your work. On 2020-06-21 03:47:27 +0300, Laurent Pinchart wrote: > Convert the Renesas R-Car FCP text binding to YAML. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Geert Uytterhoeven > --- > Changes since v1: > > - Simplify comments on compatible strings > - Update MAINTAINERS > --- > .../devicetree/bindings/media/renesas,fcp.txt | 34 ----------- > .../bindings/media/renesas,fcp.yaml | 56 +++++++++++++++++++ > MAINTAINERS | 2 +- > 3 files changed, 57 insertions(+), 35 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.txt > create mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.yaml > > diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt > deleted file mode 100644 > index 79c37395b396..000000000000 > --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt > +++ /dev/null > @@ -1,34 +0,0 @@ > -Renesas R-Car Frame Compression Processor (FCP) > ------------------------------------------------ > - > -The FCP is a companion module of video processing modules in the Renesas R-Car > -Gen3 and RZ/G2 SoCs. It provides data compression and decompression, data > -caching, and conversion of AXI transactions in order to reduce the memory > -bandwidth. > - > -There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and FCP > -for FDP (FCPF). Their configuration and behaviour depend on the module they > -are paired with. These DT bindings currently support the FCPV and FCPF. > - > - - compatible: Must be one or more of the following > - > - - "renesas,fcpv" for generic compatible 'FCP for VSP' > - - "renesas,fcpf" for generic compatible 'FCP for FDP' > - > - - reg: the register base and size for the device registers > - - clocks: Reference to the functional clock > - > -Optional properties: > - - power-domains : power-domain property defined with a power domain specifier > - to respective power domain. > - > - > -Device node example > -------------------- > - > - fcpvd1: fcp@fea2f000 { > - compatible = "renesas,fcpv"; > - reg = <0 0xfea2f000 0 0x200>; > - clocks = <&cpg CPG_MOD 602>; > - power-domains = <&sysc R8A7795_PD_A3VP>; > - }; > diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml > new file mode 100644 > index 000000000000..9241bf3c5efc > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/renesas,fcp.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas R-Car Frame Compression Processor (FCP) > + > +maintainers: > + - Laurent Pinchart > + > +description: | > + The FCP is a companion module of video processing modules in the Renesas > + R-Car Gen3 and RZ/G2 SoCs. It provides data compression and decompression, > + data caching, and conversion of AXI transactions in order to reduce the > + memory bandwidth. > + > + There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and > + FCP for FDP (FCPF). Their configuration and behaviour depend on the module > + they are paired with. These DT bindings currently support the FCPV and FCPF. > + > +properties: > + compatible: > + enum: > + - renesas,fcpv # FCP for VSP > + - renesas,fcpf # FCP for FDP > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + > +additionalProperties: false > + > +examples: > + # R8A7790 (R-Car H2) VSP1-S Hum, R8A7790 is H2 but the example below is from H3 R8A7795[01] is it not? With this fixed, Reviewed-by: Niklas Söderlund > + - | > + #include > + #include > + > + fcp@fea2f000 { > + compatible = "renesas,fcpv"; > + reg = <0xfea2f000 0x200>; > + clocks = <&cpg CPG_MOD 602>; > + power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > + }; > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 68f21d46614c..660ed6606de2 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -10700,7 +10700,7 @@ L: linux-media@vger.kernel.org > L: linux-renesas-soc@vger.kernel.org > S: Supported > T: git git://linuxtv.org/media_tree.git > -F: Documentation/devicetree/bindings/media/renesas,fcp.txt > +F: Documentation/devicetree/bindings/media/renesas,fcp.yaml > F: drivers/media/platform/rcar-fcp.c > F: include/media/rcar-fcp.h > > -- > Regards, > > Laurent Pinchart > -- Regards, Niklas Söderlund