From: Rob Herring <robh@kernel.org>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: devicetree@vger.kernel.org, slongerbeam@gmail.com,
linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com,
linux-renesas-soc@vger.kernel.org,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
linux-omap@vger.kernel.org, "Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-stm32@st-md-mailman.stormreply.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>, "Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Tero Kristo" <t-kristo@ti.com>, "Nishanth Menon" <nm@ti.com>
Subject: Re: [PATCH 05/13] dt-bindings: media: ov5640: Make bus-type mandatory
Date: Mon, 20 Jul 2020 13:45:38 -0600 [thread overview]
Message-ID: <20200720194538.GA2872607@bogus> (raw)
In-Reply-To: <20200717132859.237120-6-jacopo+renesas@jmondi.org>
On Fri, Jul 17, 2020 at 03:28:51PM +0200, Jacopo Mondi wrote:
> The ov5640 driver supports both a parallel data interface and a
> CSI-2 serial data interface.
>
> Depending on which interface is in use, the required endpoint
> properties are different. In order to be able to validate if a
> device node is compliant with the dt-schema bindings, start by
> making the bus-type a mandatory property, and add it to all the
> existing users of ov5640 in mainline DTS.
You can't really make a property required on an existing binding. That
breaks compatibility. Are all the users of the below boards okay with
that?
There should be a default defined if 'bus-type' is not present.
>
> On top of this, endpoint properties validation will be implemented,
> conditionally to the reported bus type.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> Documentation/devicetree/bindings/media/i2c/ov5640.yaml | 6 ++++++
> arch/arm/boot/dts/dra72-evm-common.dtsi | 1 +
> arch/arm/boot/dts/dra76-evm.dts | 1 +
> arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi | 1 +
> arch/arm/boot/dts/imx6qdl-icore.dtsi | 1 +
> arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 1 +
> arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 1 +
> arch/arm/boot/dts/stm32mp157c-ev1.dts | 1 +
> arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts | 1 +
> arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts | 1 +
> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 1 +
> arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 1 +
> 12 files changed, 17 insertions(+)
next prev parent reply other threads:[~2020-07-20 19:45 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 13:28 [PATCH 00/13] dt-bindings: media: ov5640: Convert to json-schema Jacopo Mondi
2020-07-17 13:28 ` [PATCH 01/13] " Jacopo Mondi
2020-07-17 19:28 ` Laurent Pinchart
2020-07-20 16:32 ` Rob Herring
2020-07-17 13:28 ` [PATCH 02/13] arm64: dts: qcom: apq8016-sbc: Fix CSI-2 lanes routing Jacopo Mondi
2020-07-17 19:35 ` Laurent Pinchart
2020-07-22 8:14 ` Loic Poulain
2020-07-22 8:34 ` Jacopo Mondi
2020-07-17 13:28 ` [PATCH 03/13] dt-bindings: media: ov5640: Do not limit rotation Jacopo Mondi
2020-07-17 19:38 ` Laurent Pinchart
2020-07-20 19:36 ` Rob Herring
2020-07-17 13:28 ` [PATCH 04/13] dt-bindings: media: ti,cal: Remove sensor from example Jacopo Mondi
2020-07-17 19:39 ` Laurent Pinchart
2020-07-23 20:57 ` Rob Herring
2020-07-17 13:28 ` [PATCH 05/13] dt-bindings: media: ov5640: Make bus-type mandatory Jacopo Mondi
2020-07-17 15:48 ` Fabio Estevam
2020-07-17 19:48 ` Laurent Pinchart
2020-07-20 19:45 ` Rob Herring [this message]
2020-07-17 13:28 ` [PATCH 06/13] dt-bindings: media: ov5640: Require ep properties Jacopo Mondi
2020-07-17 19:50 ` Laurent Pinchart
2020-07-17 13:28 ` [PATCH 07/13] dt-bindings: media: ov5640: Remove clock-lanes Jacopo Mondi
2020-07-17 20:48 ` Laurent Pinchart
2020-07-20 19:47 ` Rob Herring
2020-07-17 13:28 ` [PATCH 08/13] dt-bindings: media: ov5640: Remove data-shift Jacopo Mondi
2020-07-17 20:57 ` Laurent Pinchart
2020-07-23 22:22 ` Sakari Ailus
2020-07-23 23:15 ` Laurent Pinchart
2020-07-25 21:18 ` Sakari Ailus
2020-07-25 21:31 ` Laurent Pinchart
2020-07-29 14:29 ` Sakari Ailus
2020-07-29 14:46 ` Laurent Pinchart
2020-07-30 16:22 ` Sakari Ailus
2020-07-30 16:32 ` Laurent Pinchart
2020-07-30 16:43 ` Sakari Ailus
2020-07-17 13:28 ` [PATCH 09/13] dt-bindings: media: ov5640: Add default for synch signals Jacopo Mondi
2020-07-17 20:59 ` Laurent Pinchart
2020-07-20 19:50 ` Rob Herring
2020-07-17 13:28 ` [PATCH 10/13] dt-bindings: media: ov5640: Demote DVP required properties Jacopo Mondi
2020-07-17 21:00 ` Laurent Pinchart
2020-07-17 13:28 ` [PATCH 11/13] media: i2c: ov5640: Initialize DVP polarities as default Jacopo Mondi
2020-07-17 21:02 ` Laurent Pinchart
2020-07-17 13:28 ` [PATCH 12/13] MAINTAINERS: ov5640: Add bindings file Jacopo Mondi
2020-07-17 21:03 ` Laurent Pinchart
2020-07-17 13:28 ` [PATCH 13/13] dt-bindings: media: ov5640: Add myself as co-maintainer Jacopo Mondi
2020-07-17 21:03 ` Laurent Pinchart
2020-07-17 19:31 ` [PATCH 00/13] dt-bindings: media: ov5640: Convert to json-schema Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720194538.GA2872607@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=bcousson@baylibre.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jacopo+renesas@jmondi.org \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-imx@nxp.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mripard@kernel.org \
--cc=nm@ti.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=slongerbeam@gmail.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).