From: Niklas <niklas.soderlund@ragnatech.se>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Biju Das <biju.das.jz@bp.renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Prabhakar <prabhakar.csengg@gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: media: renesas,vin: Document renesas-vin-ycbcr-8b-g property
Date: Fri, 24 Jul 2020 21:37:52 +0200 [thread overview]
Message-ID: <20200724193752.GE2729799@oden.dyn.berto.se> (raw)
In-Reply-To: <1595602732-25582-2-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com>
Hi Lad,
Thanks for your patch.
On 2020-07-24 15:58:51 +0100, Lad Prabhakar wrote:
> Add a DT property "renesas-vin-ycbcr-8b-g" to select YCbCr422 8-bit data
> input pins.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> Documentation/devicetree/bindings/media/renesas,vin.yaml | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,vin.yaml b/Documentation/devicetree/bindings/media/renesas,vin.yaml
> index 53c0a72..7dfb781 100644
> --- a/Documentation/devicetree/bindings/media/renesas,vin.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,vin.yaml
> @@ -106,6 +106,12 @@ properties:
>
> remote-endpoint: true
>
> + renesas-vin-ycbcr-8b-g:
I think the preferred format for vendor specific properties are
"<vendor>,<property>".
This nit apart I'm not sure a property is the right way here. Could it
not be possible on some designs to have two different sensors one wired
to DATA[7:0] and the other to DATA[15:8] and by controlling the
VNDRM2_YDS register at runtime switch between the two? If so adding a DT
property to hard-code one of the two options would prevent this. I fear
we need to think of a runtime way to deal with this.
The best way to do that I think is to extend the port@0 node to allow
for two endpoints, one for each of the two possible parallel sensors.
This would then have to be expressed in the media graph and selection if
YDS should be set or not depend on which media links are enabled.
> + type: boolean
> + description:
> + If present this property specifies to selects VIN_G[7:0] as data pins for YCbCr422 8-bit data.
> + default: false
> +
> required:
> - remote-endpoint
>
> @@ -168,6 +174,13 @@ properties:
>
> remote-endpoint: true
>
> + renesas-vin-ycbcr-8b-g:
> + type: boolean
> + description:
> + If present this property specifies to selects VIN_G[7:0] as data pins for
> + YCbCr422 8-bit data.
> + default: false
> +
> required:
> - remote-endpoint
>
> --
> 2.7.4
>
--
Regards,
Niklas Söderlund
next prev parent reply other threads:[~2020-07-24 19:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 14:58 [PATCH 0/2] media: rcar-vin: Add support to select data pins Lad Prabhakar
2020-07-24 14:58 ` [PATCH 1/2] dt-bindings: media: renesas,vin: Document renesas-vin-ycbcr-8b-g property Lad Prabhakar
2020-07-24 19:37 ` Niklas [this message]
2020-07-24 21:11 ` Lad, Prabhakar
2020-07-25 8:11 ` Niklas
2020-07-25 22:23 ` Lad, Prabhakar
2020-07-31 20:19 ` Rob Herring
2020-08-01 9:17 ` Niklas
2020-08-03 9:31 ` Geert Uytterhoeven
2020-07-24 14:58 ` [PATCH 2/2] media: rcar-vin: Add support to read " Lad Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724193752.GE2729799@oden.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=biju.das.jz@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).