From: David Miller <davem@davemloft.net>
To: ashiduka@fujitsu.com
Cc: sergei.shtylyov@gmail.com, kuba@kernel.org,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3] ravb: Fixed to be able to unload modules
Date: Thu, 20 Aug 2020 16:52:44 -0700 (PDT) [thread overview]
Message-ID: <20200820.165244.540878641387937530.davem@davemloft.net> (raw)
In-Reply-To: <20200820094307.3977-1-ashiduka@fujitsu.com>
From: Yuusuke Ashizuka <ashiduka@fujitsu.com>
Date: Thu, 20 Aug 2020 18:43:07 +0900
> When this driver is built as a module, I cannot rmmod it after insmoding
> it.
> This is because that this driver calls ravb_mdio_init() at the time of
> probe, and module->refcnt is incremented by alloc_mdio_bitbang() called
> after that.
> Therefore, even if ifup is not performed, the driver is in use and rmmod
> cannot be performed.
>
> $ lsmod
> Module Size Used by
> ravb 40960 1
> $ rmmod ravb
> rmmod: ERROR: Module ravb is in use
>
> Call ravb_mdio_init() at open and free_mdio_bitbang() at close, thereby
> rmmod is possible in the ifdown state.
>
> Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
> Signed-off-by: Yuusuke Ashizuka <ashiduka@fujitsu.com>
> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>
> ---
> Changes in v3:
> - Update the commit subject and description.
> - Add Fixes c156633f1353.
> - Add Reviewed-by Sergei.
> https://patchwork.kernel.org/patch/11692719/
>
> Changes in v2:
> - Fix build error
This is OK as a short term bug fix for sure.
But longer term, we should always be able to rmmod a networking
device driver even if it is UP.
Supplementary references from MDIO make this not possible.
What would need to happen is that MDIO would stop taking references to
the network device driver module, and it would register a netdevice
notifier that would do the necessary detachmentand resource release
during an unregister attempt.
That's how ipv4, ipv6, etc. deal with references to the device via
routes, assigned protocol addresses, etc.
next prev parent reply other threads:[~2020-08-21 0:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 9:43 [PATCH v3] ravb: Fixed to be able to unload modules Yuusuke Ashizuka
2020-08-20 10:03 ` Sergei Shtylyov
2020-08-20 12:29 ` Sergei Shtylyov
2020-08-20 12:31 ` Sergei Shtylyov
2020-08-20 23:52 ` David Miller [this message]
2020-08-24 22:38 ` David Miller
2020-09-16 9:31 ` Geert Uytterhoeven
2020-09-21 13:16 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820.165244.540878641387937530.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ashiduka@fujitsu.com \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).