From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: Re: [PATCH v2][next] PCI: rcar-gen2: Use fallthrough pseudo-keyword
Date: Mon, 7 Sep 2020 15:18:21 +0100 [thread overview]
Message-ID: <20200907141821.GA9474@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20200722032851.GA4251@embeddedor>
On Tue, Jul 21, 2020 at 10:28:51PM -0500, Gustavo A. R. Silva wrote:
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1].
>
> [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> Changes in v2:
> - Update URL. Use proper URL to Linux v5.7 documentation.
> - Add Geert's Reviewed-by tag.
> - Update changelog text.
>
> drivers/pci/controller/pci-rcar-gen2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to pci/rcar, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/pci-rcar-gen2.c b/drivers/pci/controller/pci-rcar-gen2.c
> index 326171cb1a97..2ec7093a7588 100644
> --- a/drivers/pci/controller/pci-rcar-gen2.c
> +++ b/drivers/pci/controller/pci-rcar-gen2.c
> @@ -228,7 +228,7 @@ static int rcar_pci_setup(int nr, struct pci_sys_data *sys)
> pr_warn("unknown window size %ld - defaulting to 256M\n",
> priv->window_size);
> priv->window_size = SZ_256M;
> - /* fall-through */
> + fallthrough;
> case SZ_256M:
> val |= RCAR_USBCTR_PCIAHB_WIN1_256M;
> break;
> --
> 2.27.0
>
prev parent reply other threads:[~2020-09-07 14:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 3:28 [PATCH v2][next] PCI: rcar-gen2: Use fallthrough pseudo-keyword Gustavo A. R. Silva
2020-07-31 9:08 ` Yoshihiro Shimoda
2020-09-07 14:18 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907141821.GA9474@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=geert+renesas@glider.be \
--cc=gustavo@embeddedor.com \
--cc=gustavoars@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=robh@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).