From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 472C7C43465 for ; Thu, 17 Sep 2020 20:12:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BC632087D for ; Thu, 17 Sep 2020 20:12:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="gXtNWWra" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726687AbgIQUMh (ORCPT ); Thu, 17 Sep 2020 16:12:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725874AbgIQUMh (ORCPT ); Thu, 17 Sep 2020 16:12:37 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEA91C06174A; Thu, 17 Sep 2020 13:12:36 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7270FFD1; Thu, 17 Sep 2020 22:12:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1600373554; bh=ImtDkhOM3E58XUZj9vjsNqp730R4NQ3rMHUu/Xaa14E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gXtNWWraWwEmJdkNh1LFbj1LUPr5Rh6c2/gqhc04TotlmCEVMe9driHUsSEp7s6IV v0lgY95h6Z5kaJoqD7Viq+KMIl50T/q4bx5UMjGwUaP1gbIrkc4dOJceRtJNIijJj8 rmxsypz7uhzzO3+03nbKH86AhoEVZASp7Sw6kvqs= Date: Thu, 17 Sep 2020 23:12:04 +0300 From: Laurent Pinchart To: Krzysztof Kozlowski Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Manivannan Sadhasivam , Andy Gross , Bjorn Andersson , Palmer Dabbelt , Paul Walmsley , Hoan Tran , Serge Semin , Masahiro Yamada , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Niklas =?utf-8?Q?S=C3=B6derlund?= , Mauro Carvalho Chehab , Charles Keepax , Richard Fitzgerald , Lee Jones , Maxime Coquelin , Alexandre Torgue , Andreas =?utf-8?Q?F=C3=A4rber?= , Maxime Ripard , Chen-Yu Tsai , Matthias Brugger , Geert Uytterhoeven , Liam Girdwood , Mark Brown , Chris Packham , Anson Huang , Sungbo Eo , Stefan Agner , Srinivas Kandagatla , Magnus Damm , Yash Shah , Paul Kocialkowski , - , Matti Vaittinen , Amelie Delaunay , Cristian Ciocaltea , Paul Cercueil , Andy Teng , Sean Wang , Sricharan R , Chris Brandt , Jaroslav Kysela , Takashi Iwai , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-unisoc@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-media@vger.kernel.org, alsa-devel@alsa-project.org, linux-stm32@st-md-mailman.stormreply.com, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v2 09/13] dt-bindings: pinctrl: include common schema in GPIO controllers Message-ID: <20200917201204.GG3969@pendragon.ideasonboard.com> References: <20200917165301.23100-1-krzk@kernel.org> <20200917165301.23100-10-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200917165301.23100-10-krzk@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Krzysztof, Thank you for the patch. On Thu, Sep 17, 2020 at 06:52:57PM +0200, Krzysztof Kozlowski wrote: > Include the common GPIO schema in GPIO controllers to be sure all common > properties are properly validated. Shouldn't we delete the properties that are now redundant from these schemas ? > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. New patch > --- > .../devicetree/bindings/pinctrl/actions,s500-pinctrl.yaml | 3 +++ > .../bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml | 1 + > .../devicetree/bindings/pinctrl/cirrus,lochnagar.yaml | 3 +++ > Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml | 3 +++ > .../devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml | 3 +++ > Documentation/devicetree/bindings/pinctrl/pinctrl-mt8192.yaml | 3 +++ > .../devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml | 3 +++ > .../devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 3 +++ > .../devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 3 +++ > .../devicetree/bindings/pinctrl/renesas,rza2-pinctrl.yaml | 3 +++ > .../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 3 +++ > 11 files changed, 31 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/actions,s500-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/actions,s500-pinctrl.yaml > index 33391d30c00c..51bfc214bba6 100644 > --- a/Documentation/devicetree/bindings/pinctrl/actions,s500-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/actions,s500-pinctrl.yaml > @@ -15,6 +15,9 @@ description: | > GPIO function selection & GPIO attributes configuration. Please refer to > pinctrl-bindings.txt in this directory for common binding part and usage. > > +allOf: > + - $ref: /schemas/gpio/gpio-common.yaml# > + > properties: > compatible: > const: actions,s500-pinctrl > diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > index 7556be6e2754..55662f8d1f94 100644 > --- a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > @@ -143,6 +143,7 @@ allOf: > # boards are defining it at the moment so it would generate a lot of > # warnings. > > + - $ref: /schemas/gpio/gpio-common.yaml# > - if: > properties: > compatible: > diff --git a/Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.yaml b/Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.yaml > index 420d74856032..ed478b0ed4cc 100644 > --- a/Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.yaml > @@ -31,6 +31,9 @@ description: | > This binding must be part of the Lochnagar MFD binding: > [4] ../mfd/cirrus,lochnagar.yaml > > +allOf: > + - $ref: /schemas/gpio/gpio-common.yaml# > + > properties: > compatible: > enum: > diff --git a/Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml > index 44c04d11ae4c..ffa64832b4f9 100644 > --- a/Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml > @@ -59,6 +59,9 @@ properties: > patternProperties: > "^gpio@[0-9]$": > type: object > + allOf: > + - $ref: /schemas/gpio/gpio-common.yaml# > + > properties: > compatible: > enum: > diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml > index 152c151c27ad..7d0a4cb96f39 100644 > --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml > @@ -14,6 +14,9 @@ description: |+ > required property: > - compatible: "syscon" > > +allOf: > + - $ref: /schemas/gpio/gpio-common.yaml# > + > properties: > compatible: > const: mediatek,mt6779-pinctrl > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8192.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8192.yaml > index 5556def6b99b..bc8bc0ac1926 100644 > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8192.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8192.yaml > @@ -12,6 +12,9 @@ maintainers: > description: | > The Mediatek's Pin controller is used to control SoC pins. > > +allOf: > + - $ref: /schemas/gpio/gpio-common.yaml# > + > properties: > compatible: > const: mediatek,mt8192-pinctrl > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml > index c64c93206817..22a6b80b4c0e 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml > @@ -13,6 +13,9 @@ description: | > This binding describes the Top Level Mode Multiplexer block found in the > IPQ6018 platform. > > +allOf: > + - $ref: /schemas/gpio/gpio-common.yaml# > + > properties: > compatible: > const: qcom,ipq6018-pinctrl > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml > index 1f0f5757f9e1..9855d859fe61 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml > @@ -13,6 +13,9 @@ description: | > This binding describes the Top Level Mode Multiplexer block found in the > MSM8226 platform. > > +allOf: > + - $ref: /schemas/gpio/gpio-common.yaml# > + > properties: > compatible: > const: qcom,msm8226-pinctrl > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml > index 8508c57522fd..e5757b6ced40 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml > @@ -13,6 +13,9 @@ description: | > This binding describes the Top Level Mode Multiplexer block found in the > SM8250 platform. > > +allOf: > + - $ref: /schemas/gpio/gpio-common.yaml# > + > properties: > compatible: > const: qcom,sm8250-pinctrl > diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rza2-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rza2-pinctrl.yaml > index b7911a994f3a..4d7bf4340262 100644 > --- a/Documentation/devicetree/bindings/pinctrl/renesas,rza2-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rza2-pinctrl.yaml > @@ -10,6 +10,9 @@ maintainers: > - Chris Brandt > - Geert Uytterhoeven > > +allOf: > + - $ref: /schemas/gpio/gpio-common.yaml# > + > description: > The Renesas SoCs of the RZ/A2 series feature a combined Pin and GPIO > controller. > diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml > index 72877544ca78..28b861362ba0 100644 > --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml > @@ -56,6 +56,9 @@ properties: > patternProperties: > '^gpio@[0-9a-f]*$': > type: object > + allOf: > + - $ref: /schemas/gpio/gpio-common.yaml# > + > properties: > gpio-controller: true > '#gpio-cells': -- Regards, Laurent Pinchart