From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7175C43463 for ; Thu, 17 Sep 2020 20:13:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9034320795 for ; Thu, 17 Sep 2020 20:13:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ghKM0GYx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726328AbgIQUNp (ORCPT ); Thu, 17 Sep 2020 16:13:45 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:55816 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726244AbgIQUNp (ORCPT ); Thu, 17 Sep 2020 16:13:45 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E541EFED; Thu, 17 Sep 2020 22:13:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1600373621; bh=Lgq9PKRDYhVRmNU7RasyOZL9cSKALVzKVkOgyrxq3OM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ghKM0GYxCHRhO2OzSWfqAhvO7iCRt7cu1MM1uolJIk+nsQMPRL7i+oqzAG17EDXFX hXLgKqL8giZLAXpZS4JYEwCm7oygNVuf1gJW1iEqCumOXugar6+RcBIw2vSYE1k5Ma eNzDgBcqBKHUcXSs2SWfCLHPqVWYAO4XJE6hsiWs= Date: Thu, 17 Sep 2020 23:13:11 +0300 From: Laurent Pinchart To: Krzysztof Kozlowski Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Manivannan Sadhasivam , Andy Gross , Bjorn Andersson , Palmer Dabbelt , Paul Walmsley , Hoan Tran , Serge Semin , Masahiro Yamada , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Niklas =?utf-8?Q?S=C3=B6derlund?= , Mauro Carvalho Chehab , Charles Keepax , Richard Fitzgerald , Lee Jones , Maxime Coquelin , Alexandre Torgue , Andreas =?utf-8?Q?F=C3=A4rber?= , Maxime Ripard , Chen-Yu Tsai , Matthias Brugger , Geert Uytterhoeven , Liam Girdwood , Mark Brown , Chris Packham , Anson Huang , Sungbo Eo , Stefan Agner , Srinivas Kandagatla , Magnus Damm , Yash Shah , Paul Kocialkowski , - , Matti Vaittinen , Amelie Delaunay , Cristian Ciocaltea , Paul Cercueil , Andy Teng , Sean Wang , Sricharan R , Chris Brandt , Jaroslav Kysela , Takashi Iwai , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-unisoc@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-media@vger.kernel.org, alsa-devel@alsa-project.org, linux-stm32@st-md-mailman.stormreply.com, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v2 02/13] dt-bindings: gpio: include common schema in GPIO controllers Message-ID: <20200917201311.GH3969@pendragon.ideasonboard.com> References: <20200917165301.23100-1-krzk@kernel.org> <20200917165301.23100-3-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200917165301.23100-3-krzk@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Krzysztof, Thank you for the patch. On Thu, Sep 17, 2020 at 06:52:50PM +0200, Krzysztof Kozlowski wrote: > Include the common GPIO schema in GPIO controllers to be sure all common > properties are properly validated. Same comment as for patch 09/13, shouldn't we delete redundant properties from all these schemas ? > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. Fix gpio-mxs.yaml > 2. Add snps,dw-apb-gpio.yaml > --- > .../devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml | 3 +++ > Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml | 3 +++ > Documentation/devicetree/bindings/gpio/gpio-mxs.yaml | 4 ++++ > Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml | 3 +++ > Documentation/devicetree/bindings/gpio/gpio-rda.yaml | 3 +++ > Documentation/devicetree/bindings/gpio/gpio-vf610.yaml | 3 +++ > Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml | 1 + > Documentation/devicetree/bindings/gpio/qcom,wcd934x-gpio.yaml | 3 +++ > Documentation/devicetree/bindings/gpio/renesas,em-gio.yaml | 3 +++ > Documentation/devicetree/bindings/gpio/renesas,rcar-gpio.yaml | 3 +++ > Documentation/devicetree/bindings/gpio/sifive,gpio.yaml | 3 +++ > Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml | 3 +++ > .../devicetree/bindings/gpio/socionext,uniphier-gpio.yaml | 3 +++ > .../devicetree/bindings/gpio/xylon,logicvc-gpio.yaml | 3 +++ > 14 files changed, 41 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml b/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml > index c213cb9ddb9f..1ac69b9c03f9 100644 > --- a/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml > @@ -13,6 +13,9 @@ description: | > This controller is the Chip Common A GPIO present on a number of Broadcom > switch ASICs with integrated SoCs. > > +allOf: > + - $ref: gpio-common.yaml# > + > properties: > compatible: > const: brcm,iproc-gpio-cca > diff --git a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml > index de0b9b5f6a70..737756e081fb 100644 > --- a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml > @@ -9,6 +9,9 @@ title: Freescale i.MX/MXC GPIO controller > maintainers: > - Anson Huang > > +allOf: > + - $ref: gpio-common.yaml# > + > properties: > compatible: > oneOf: > diff --git a/Documentation/devicetree/bindings/gpio/gpio-mxs.yaml b/Documentation/devicetree/bindings/gpio/gpio-mxs.yaml > index dfa1133f8c5e..bd0c4f329625 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio-mxs.yaml > +++ b/Documentation/devicetree/bindings/gpio/gpio-mxs.yaml > @@ -34,6 +34,10 @@ properties: > patternProperties: > "gpio@[0-9]+$": > type: object > + > + allOf: > + - $ref: gpio-common.yaml# > + > properties: > compatible: > enum: > diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml > index 338c5312a106..69b12041c893 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml > +++ b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml > @@ -9,6 +9,9 @@ title: PCA9570 I2C GPO expander > maintainers: > - Sungbo Eo > > +allOf: > + - $ref: gpio-common.yaml# > + > properties: > compatible: > enum: > diff --git a/Documentation/devicetree/bindings/gpio/gpio-rda.yaml b/Documentation/devicetree/bindings/gpio/gpio-rda.yaml > index 6ece555f074f..d70c99f463c2 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio-rda.yaml > +++ b/Documentation/devicetree/bindings/gpio/gpio-rda.yaml > @@ -9,6 +9,9 @@ title: RDA Micro GPIO controller > maintainers: > - Manivannan Sadhasivam > > +allOf: > + - $ref: gpio-common.yaml# > + > properties: > compatible: > const: rda,8810pl-gpio > diff --git a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml > index 6ac5a78ad3da..82f3e4b407d1 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml > +++ b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml > @@ -17,6 +17,9 @@ description: | > Note: Each GPIO port should have an alias correctly numbered in "aliases" > node. > > +allOf: > + - $ref: gpio-common.yaml# > + > properties: > compatible: > enum: > diff --git a/Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml b/Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml > index 4db3b8a3332c..e2b7d2d133a8 100644 > --- a/Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml > @@ -12,6 +12,7 @@ maintainers: > - Rob Herring > > allOf: > + - $ref: gpio-common.yaml# > - if: > properties: > compatible: > diff --git a/Documentation/devicetree/bindings/gpio/qcom,wcd934x-gpio.yaml b/Documentation/devicetree/bindings/gpio/qcom,wcd934x-gpio.yaml > index 32a566ec3558..2eee374e8396 100644 > --- a/Documentation/devicetree/bindings/gpio/qcom,wcd934x-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/qcom,wcd934x-gpio.yaml > @@ -13,6 +13,9 @@ description: | > Qualcomm Technologies Inc WCD9340/WCD9341 Audio Codec has integrated > gpio controller to control 5 gpios on the chip. > > +allOf: > + - $ref: gpio-common.yaml# > + > properties: > compatible: > enum: > diff --git a/Documentation/devicetree/bindings/gpio/renesas,em-gio.yaml b/Documentation/devicetree/bindings/gpio/renesas,em-gio.yaml > index 8bdef812c87c..845689807678 100644 > --- a/Documentation/devicetree/bindings/gpio/renesas,em-gio.yaml > +++ b/Documentation/devicetree/bindings/gpio/renesas,em-gio.yaml > @@ -9,6 +9,9 @@ title: Renesas EMMA Mobile General Purpose I/O Interface > maintainers: > - Magnus Damm > > +allOf: > + - $ref: gpio-common.yaml# > + > properties: > compatible: > const: renesas,em-gio > diff --git a/Documentation/devicetree/bindings/gpio/renesas,rcar-gpio.yaml b/Documentation/devicetree/bindings/gpio/renesas,rcar-gpio.yaml > index 5026662e4508..c116000d579f 100644 > --- a/Documentation/devicetree/bindings/gpio/renesas,rcar-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/renesas,rcar-gpio.yaml > @@ -9,6 +9,9 @@ title: Renesas R-Car General-Purpose Input/Output Ports (GPIO) > maintainers: > - Geert Uytterhoeven > > +allOf: > + - $ref: gpio-common.yaml# > + > properties: > compatible: > oneOf: > diff --git a/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml b/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml > index a0efd8dc2538..f2d93b40fc7e 100644 > --- a/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml > @@ -10,6 +10,9 @@ maintainers: > - Yash Shah > - Paul Walmsley > > +allOf: > + - $ref: gpio-common.yaml# > + > properties: > compatible: > items: > diff --git a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml > index b391cc1b4590..459aafe5fd47 100644 > --- a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml > @@ -49,6 +49,9 @@ properties: > patternProperties: > "^gpio-(port|controller)@[0-9a-f]+$": > type: object > + allOf: > + - $ref: gpio-common.yaml# > + > properties: > compatible: > const: snps,dw-apb-gpio-port > diff --git a/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml b/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml > index c58ff9a94f45..94a911e9c313 100644 > --- a/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml > @@ -9,6 +9,9 @@ title: UniPhier GPIO controller > maintainers: > - Masahiro Yamada > > +allOf: > + - $ref: gpio-common.yaml# > + > properties: > $nodename: > pattern: "^gpio@[0-9a-f]+$" > diff --git a/Documentation/devicetree/bindings/gpio/xylon,logicvc-gpio.yaml b/Documentation/devicetree/bindings/gpio/xylon,logicvc-gpio.yaml > index a36aec27069c..0e4581241b3f 100644 > --- a/Documentation/devicetree/bindings/gpio/xylon,logicvc-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/xylon,logicvc-gpio.yaml > @@ -23,6 +23,9 @@ description: | > - EN_VEE (power control) mapped to index 7 > - V_EN (power control) mapped to index 8 > > +allOf: > + - $ref: gpio-common.yaml# > + > properties: > $nodename: > pattern: "^gpio@[0-9a-f]+$" -- Regards, Laurent Pinchart