From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-mmc@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 5/7] i2c: rcar: : use proper DMAENGINE API for termination
Date: Wed, 23 Jun 2021 11:59:39 +0200 [thread overview]
Message-ID: <20210623095942.3325-6-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20210623095942.3325-1-wsa+renesas@sang-engineering.com>
dmaengine_terminate_all() is deprecated in favor of explicitly saying if
it should be sync or async. Here, we want dmaengine_terminate_sync()
because there is no other synchronization code in the driver to handle
an async case.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/i2c/busses/i2c-rcar.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c
index 327c092a4130..41ff327882ef 100644
--- a/drivers/i2c/busses/i2c-rcar.c
+++ b/drivers/i2c/busses/i2c-rcar.c
@@ -391,9 +391,9 @@ static void rcar_i2c_cleanup_dma(struct rcar_i2c_priv *priv)
if (priv->dma_direction == DMA_NONE)
return;
else if (priv->dma_direction == DMA_FROM_DEVICE)
- dmaengine_terminate_all(priv->dma_rx);
+ dmaengine_terminate_sync(priv->dma_rx);
else if (priv->dma_direction == DMA_TO_DEVICE)
- dmaengine_terminate_all(priv->dma_tx);
+ dmaengine_terminate_sync(priv->dma_tx);
rcar_i2c_dma_unmap(priv);
}
--
2.30.2
next prev parent reply other threads:[~2021-06-23 9:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 9:59 [PATCH 0/7] i2c: use proper DMAENGINE API for termination Wolfram Sang
2021-06-23 9:59 ` [PATCH 1/7] i2c: at91-master: : " Wolfram Sang
2021-07-13 9:07 ` Codrin.Ciubotariu
2021-08-11 13:24 ` Wolfram Sang
2021-08-11 13:34 ` Codrin.Ciubotariu
2021-06-23 9:59 ` [PATCH 2/7] i2c: imx: " Wolfram Sang
2021-06-25 12:06 ` Oleksij Rempel
2021-08-11 13:24 ` Wolfram Sang
2021-06-23 9:59 ` [PATCH 3/7] i2c: mxs: " Wolfram Sang
2021-08-11 13:24 ` Wolfram Sang
2021-06-23 9:59 ` [PATCH 4/7] i2c: qup: " Wolfram Sang
2021-08-11 13:24 ` Wolfram Sang
2021-06-23 9:59 ` Wolfram Sang [this message]
2021-06-23 14:02 ` [PATCH 5/7] i2c: rcar: " Geert Uytterhoeven
2021-06-23 14:08 ` Wolfram Sang
2021-06-23 9:59 ` [PATCH 6/7] i2c: sh_mobile: " Wolfram Sang
2021-08-11 13:24 ` Wolfram Sang
2021-06-23 9:59 ` [PATCH 7/7] i2c: stm32f7: " Wolfram Sang
2021-06-23 14:03 ` Wolfram Sang
2021-06-30 13:11 ` Alain Volmat
2021-06-30 13:48 ` Wolfram Sang
2021-08-11 13:26 ` [PATCH 0/7] i2c: " Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210623095942.3325-6-wsa+renesas@sang-engineering.com \
--to=wsa+renesas@sang-engineering.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).