From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FA28C11F65 for ; Wed, 30 Jun 2021 04:17:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 13E9D61D03 for ; Wed, 30 Jun 2021 04:17:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230213AbhF3ETd (ORCPT ); Wed, 30 Jun 2021 00:19:33 -0400 Received: from www.zeus03.de ([194.117.254.33]:59974 "EHLO mail.zeus03.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230200AbhF3ETd (ORCPT ); Wed, 30 Jun 2021 00:19:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=k1; bh=8oL9qBJzZUaUjaMCCsiWjrKJaYK YHhBgZQIKKOtoo8w=; b=Gm6CGkfwDxoQtwFkMaKHklLQVpPJxtPsWde9VyUw86G rmVN5C0miR1Q4onUPFEVh7/522abTCPKWD6mAw9BVh7fZjtA9Ajum3Y0Oda18B92 xtYY9+mnGhKRpS2Q+PgdITdeXFaJWsv2jQdheIyp2kl9hEj5F1Zt6zatnKdUowrU = Received: (qmail 719645 invoked from network); 30 Jun 2021 06:17:03 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 30 Jun 2021 06:17:03 +0200 X-UD-Smtp-Session: l3s3148p1@zvyh/vPFFtUgAwDPXwaiAGDoJRk6bv4I From: Wolfram Sang To: linux-mmc@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, Yoshihiro Shimoda , Adrian Hunter , Wolfram Sang Subject: [RFC PATCH] mmc: only print retune error when we don't check for card removal Date: Wed, 30 Jun 2021 06:16:58 +0200 Message-Id: <20210630041658.7574-1-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Skip printing a retune error when we scan for a removed card because we then expect a failed command. Signed-off-by: Wolfram Sang --- In my tests, detect_change was only set when a card was removed. Inserting a card or resuming from RPM would print an error. Did I overlook somethign or is this good to go? drivers/mmc/core/core.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index b039dcff17f8..b7e6e5640640 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c @@ -937,11 +937,13 @@ int mmc_execute_tuning(struct mmc_card *card) err = host->ops->execute_tuning(host, opcode); - if (err) + if (!err) + mmc_retune_enable(host); + + /* Only print error when we don't check for card removal */ + if (err && !host->detect_change) pr_err("%s: tuning execution failed: %d\n", mmc_hostname(host), err); - else - mmc_retune_enable(host); return err; } -- 2.30.2