linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH 0/3] pwm: Some improvements for legacy drivers
       [not found] <20210701072927.328254-1-u.kleine-koenig@pengutronix.de>
@ 2021-07-01  8:58 ` Geert Uytterhoeven
  2021-07-01 10:45   ` Uwe Kleine-König
  0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-07-01  8:58 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Thierry Reding, Lee Jones, Linux PWM List, Sascha Hauer, Linux-Renesas

Hi Uwe,

On Thu, Jul 1, 2021 at 9:29 AM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> this is the successor of my earlier patch "pwm: Ensure for legacy
> drivers that pwm->state stays consistent" that was applied shortly to
> next until Geert found a problem with it.
>
> I split the patch in three parts now: First the legacy handling is just
> moved to a separate function without any semantic change. Then a glitch
> is fixed, but without the regression I introduced initially. In the
> third and last patch the longstanding FIXME about breaking pwm->state if
> a callback fails is addressed.
>
> Uwe Kleine-König (3):
>   pwm: Move legacy driver handling into a dedicated function
>   pwm: Prevent a glitch for legacy drivers
>   pwm: Restore initial state if a legacy callback fails
>
>  drivers/pwm/core.c | 139 ++++++++++++++++++++++++++-------------------
>  1 file changed, 79 insertions(+), 60 deletions(-)

Thanks, works fine on Armadillo 800 EVA!
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

> base-commit: 6efb943b8616ec53a5e444193dccf1af9ad627b5

That's plain v5.13-rc1, which is probably not what Thierry is targeting?

The first patch applies with some fuzz on my local tree including
yesterday's pwm/for-next and a revert of the bad version.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/3] pwm: Some improvements for legacy drivers
  2021-07-01  8:58 ` [PATCH 0/3] pwm: Some improvements for legacy drivers Geert Uytterhoeven
@ 2021-07-01 10:45   ` Uwe Kleine-König
  2021-07-01 11:41     ` Geert Uytterhoeven
  0 siblings, 1 reply; 4+ messages in thread
From: Uwe Kleine-König @ 2021-07-01 10:45 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Linux-Renesas, Linux PWM List, Thierry Reding, Lee Jones, Sascha Hauer

[-- Attachment #1: Type: text/plain, Size: 1649 bytes --]

On Thu, Jul 01, 2021 at 10:58:32AM +0200, Geert Uytterhoeven wrote:
> Hi Uwe,
> 
> On Thu, Jul 1, 2021 at 9:29 AM Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> > this is the successor of my earlier patch "pwm: Ensure for legacy
> > drivers that pwm->state stays consistent" that was applied shortly to
> > next until Geert found a problem with it.
> >
> > I split the patch in three parts now: First the legacy handling is just
> > moved to a separate function without any semantic change. Then a glitch
> > is fixed, but without the regression I introduced initially. In the
> > third and last patch the longstanding FIXME about breaking pwm->state if
> > a callback fails is addressed.
> >
> > Uwe Kleine-König (3):
> >   pwm: Move legacy driver handling into a dedicated function
> >   pwm: Prevent a glitch for legacy drivers
> >   pwm: Restore initial state if a legacy callback fails
> >
> >  drivers/pwm/core.c | 139 ++++++++++++++++++++++++++-------------------
> >  1 file changed, 79 insertions(+), 60 deletions(-)
> 
> Thanks, works fine on Armadillo 800 EVA!
> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks for testing.

> > base-commit: 6efb943b8616ec53a5e444193dccf1af9ad627b5
> 
> That's plain v5.13-rc1, which is probably not what Thierry is targeting?

his for-next branch is based on v5.13-rc1 and there are no changes in it
touching drivers/pwm/core.c, so I expect this to be fine.
 
Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/3] pwm: Some improvements for legacy drivers
  2021-07-01 10:45   ` Uwe Kleine-König
@ 2021-07-01 11:41     ` Geert Uytterhoeven
  2021-07-01 12:19       ` Uwe Kleine-König
  0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-07-01 11:41 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Linux-Renesas, Linux PWM List, Thierry Reding, Lee Jones, Sascha Hauer

Hi Uwe,

On Thu, Jul 1, 2021 at 12:45 PM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> On Thu, Jul 01, 2021 at 10:58:32AM +0200, Geert Uytterhoeven wrote:
> > On Thu, Jul 1, 2021 at 9:29 AM Uwe Kleine-König
> > <u.kleine-koenig@pengutronix.de> wrote:
> > > this is the successor of my earlier patch "pwm: Ensure for legacy
> > > drivers that pwm->state stays consistent" that was applied shortly to
> > > next until Geert found a problem with it.
> > >
> > > I split the patch in three parts now: First the legacy handling is just
> > > moved to a separate function without any semantic change. Then a glitch
> > > is fixed, but without the regression I introduced initially. In the
> > > third and last patch the longstanding FIXME about breaking pwm->state if
> > > a callback fails is addressed.
> > >
> > > Uwe Kleine-König (3):
> > >   pwm: Move legacy driver handling into a dedicated function
> > >   pwm: Prevent a glitch for legacy drivers
> > >   pwm: Restore initial state if a legacy callback fails
> > >
> > >  drivers/pwm/core.c | 139 ++++++++++++++++++++++++++-------------------
> > >  1 file changed, 79 insertions(+), 60 deletions(-)
> >
> > Thanks, works fine on Armadillo 800 EVA!
> > Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Thanks for testing.
>
> > > base-commit: 6efb943b8616ec53a5e444193dccf1af9ad627b5
> >
> > That's plain v5.13-rc1, which is probably not what Thierry is targeting?
>
> his for-next branch is based on v5.13-rc1 and there are no changes in it
> touching drivers/pwm/core.c, so I expect this to be fine.

Git tends to disagree:

$ git log --oneline v5.13-rc1..pwm/for-next -- drivers/pwm/core.c
9ae241d06ef7aca8 pwm: core: Simplify some devm_*pwm*() functions
c333b936c1530e76 pwm: core: Remove unused devm_pwm_put()
e625fb70a6d21e4d pwm: core: Unify fwnode checks in the module
e5c38ba9f2813beb pwm: core: Reuse fwnode_to_pwmchip() in ACPI case
ca06616b1eed3112 pwm: core: Convert to use fwnode for matching
ad5e085c63f59391 pwm: Drop irrelevant error path from pwmchip_remove()
bcda91bf86c1ff76 pwm: Add a device-managed function to add PWM chips
9e40ee18a1dc1623 pwm: core: Support new usage_power setting in PWM state
69230cfac3d02c1b pwm: Autodetect default value for of_pwm_n_cells from
device tree
5447e7833629ee42 pwm: Drop of_pwm_simple_xlate() in favour of
of_pwm_xlate_with_flags()
cf38c978cf1d2a28 pwm: Make of_pwm_xlate_with_flags() work with #pwm-cells = <2>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/3] pwm: Some improvements for legacy drivers
  2021-07-01 11:41     ` Geert Uytterhoeven
@ 2021-07-01 12:19       ` Uwe Kleine-König
  0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2021-07-01 12:19 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Linux-Renesas, Linux PWM List, Thierry Reding, Lee Jones, Sascha Hauer

[-- Attachment #1: Type: text/plain, Size: 1605 bytes --]

Hello Geert,

On Thu, Jul 01, 2021 at 01:41:19PM +0200, Geert Uytterhoeven wrote:
> On Thu, Jul 1, 2021 at 12:45 PM Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> > his for-next branch is based on v5.13-rc1 and there are no changes in it
> > touching drivers/pwm/core.c, so I expect this to be fine.
> 
> Git tends to disagree:
> 
> $ git log --oneline v5.13-rc1..pwm/for-next -- drivers/pwm/core.c
> 9ae241d06ef7aca8 pwm: core: Simplify some devm_*pwm*() functions
> c333b936c1530e76 pwm: core: Remove unused devm_pwm_put()
> e625fb70a6d21e4d pwm: core: Unify fwnode checks in the module
> e5c38ba9f2813beb pwm: core: Reuse fwnode_to_pwmchip() in ACPI case
> ca06616b1eed3112 pwm: core: Convert to use fwnode for matching
> ad5e085c63f59391 pwm: Drop irrelevant error path from pwmchip_remove()
> bcda91bf86c1ff76 pwm: Add a device-managed function to add PWM chips
> 9e40ee18a1dc1623 pwm: core: Support new usage_power setting in PWM state
> 69230cfac3d02c1b pwm: Autodetect default value for of_pwm_n_cells from
> device tree
> 5447e7833629ee42 pwm: Drop of_pwm_simple_xlate() in favour of
> of_pwm_xlate_with_flags()
> cf38c978cf1d2a28 pwm: Make of_pwm_xlate_with_flags() work with #pwm-cells = <2>

I thought this was my command line, too, but *now* it shows some output.
I'm unable to find out what I did wrong ...  *shrug* I assume and hope
Thierry is able to cope with that.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-01 12:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210701072927.328254-1-u.kleine-koenig@pengutronix.de>
2021-07-01  8:58 ` [PATCH 0/3] pwm: Some improvements for legacy drivers Geert Uytterhoeven
2021-07-01 10:45   ` Uwe Kleine-König
2021-07-01 11:41     ` Geert Uytterhoeven
2021-07-01 12:19       ` Uwe Kleine-König

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).