linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: renesas: rzg2: Add internal rx delay
@ 2021-07-21 18:06 Biju Das
  2021-07-23 15:22 ` Geert Uytterhoeven
  0 siblings, 1 reply; 5+ messages in thread
From: Biju Das @ 2021-07-21 18:06 UTC (permalink / raw)
  To: Rob Herring
  Cc: Biju Das, Geert Uytterhoeven, Magnus Damm, linux-renesas-soc,
	devicetree, Chris Paterson, Biju Das, Prabhakar Mahadev Lad

Hihope boards use Realtek PHY. From the very beginning it use only
tx delays. However the phy driver commit bbc4d71d63549bcd003
("net: phy: realtek: fix rtl8211e rx/tx delay config") introduced
NFS mount failure. Now it needs rx delay inaddition to tx delay
for NFS mount to work. This patch fixes NFS mount failure issue
by adding MAC internal rx delay.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
index 202c4fc88bd5..dde3a07bc417 100644
--- a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
+++ b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
@@ -20,6 +20,7 @@
 	pinctrl-names = "default";
 	phy-handle = <&phy0>;
 	tx-internal-delay-ps = <2000>;
+	rx-internal-delay-ps = <1800>;
 	status = "okay";
 
 	phy0: ethernet-phy@0 {
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: dts: renesas: rzg2: Add internal rx delay
  2021-07-21 18:06 [PATCH] arm64: dts: renesas: rzg2: Add internal rx delay Biju Das
@ 2021-07-23 15:22 ` Geert Uytterhoeven
  2021-07-23 15:52   ` Biju Das
  0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2021-07-23 15:22 UTC (permalink / raw)
  To: Biju Das
  Cc: Rob Herring, Magnus Damm, Linux-Renesas,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Chris Paterson, Prabhakar Mahadev Lad

Hi Biju,

On Wed, Jul 21, 2021 at 8:06 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Hihope boards use Realtek PHY. From the very beginning it use only
> tx delays. However the phy driver commit bbc4d71d63549bcd003
> ("net: phy: realtek: fix rtl8211e rx/tx delay config") introduced
> NFS mount failure. Now it needs rx delay inaddition to tx delay
> for NFS mount to work. This patch fixes NFS mount failure issue
> by adding MAC internal rx delay.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.15.

Do you want a Fixes: tag?

> --- a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
> +++ b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
> @@ -20,6 +20,7 @@
>         pinctrl-names = "default";
>         phy-handle = <&phy0>;
>         tx-internal-delay-ps = <2000>;
> +       rx-internal-delay-ps = <1800>;
>         status = "okay";
>
>         phy0: ethernet-phy@0 {

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH] arm64: dts: renesas: rzg2: Add internal rx delay
  2021-07-23 15:22 ` Geert Uytterhoeven
@ 2021-07-23 15:52   ` Biju Das
  2021-07-23 16:00     ` Geert Uytterhoeven
  0 siblings, 1 reply; 5+ messages in thread
From: Biju Das @ 2021-07-23 15:52 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Rob Herring, Magnus Damm, Linux-Renesas,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Chris Paterson, Prabhakar Mahadev Lad

Hi Geert,

Thanks for the feedback.

> Subject: Re: [PATCH] arm64: dts: renesas: rzg2: Add internal rx delay
> 
> Hi Biju,
> 
> On Wed, Jul 21, 2021 at 8:06 PM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> > Hihope boards use Realtek PHY. From the very beginning it use only tx
> > delays. However the phy driver commit bbc4d71d63549bcd003
> > ("net: phy: realtek: fix rtl8211e rx/tx delay config") introduced NFS
> > mount failure. Now it needs rx delay inaddition to tx delay for NFS
> > mount to work. This patch fixes NFS mount failure issue by adding MAC
> > internal rx delay.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue
> in renesas-devel for v5.15.
> 
> Do you want a Fixes: tag?

It is a tricky situation. The phy patch is introduced in 5.9 and is backported to 5.8. 
But we don't have MaC internal delays on those kernels. So Fixes for 5.10+ will be ok I guess,
So that at least this fix will land on cip 5.10 kernel.

Regards,
Biju

> 
> > --- a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
> > @@ -20,6 +20,7 @@
> >         pinctrl-names = "default";
> >         phy-handle = <&phy0>;
> >         tx-internal-delay-ps = <2000>;
> > +       rx-internal-delay-ps = <1800>;
> >         status = "okay";
> >
> >         phy0: ethernet-phy@0 {
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: dts: renesas: rzg2: Add internal rx delay
  2021-07-23 15:52   ` Biju Das
@ 2021-07-23 16:00     ` Geert Uytterhoeven
  2021-07-23 16:08       ` Biju Das
  0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2021-07-23 16:00 UTC (permalink / raw)
  To: Biju Das
  Cc: Rob Herring, Magnus Damm, Linux-Renesas,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Chris Paterson, Prabhakar Mahadev Lad

Hi Biju,

On Fri, Jul 23, 2021 at 5:52 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > Subject: Re: [PATCH] arm64: dts: renesas: rzg2: Add internal rx delay
> > On Wed, Jul 21, 2021 at 8:06 PM Biju Das <biju.das.jz@bp.renesas.com>
> > wrote:
> > > Hihope boards use Realtek PHY. From the very beginning it use only tx
> > > delays. However the phy driver commit bbc4d71d63549bcd003
> > > ("net: phy: realtek: fix rtl8211e rx/tx delay config") introduced NFS
> > > mount failure. Now it needs rx delay inaddition to tx delay for NFS
> > > mount to work. This patch fixes NFS mount failure issue by adding MAC
> > > internal rx delay.
> > >
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue
> > in renesas-devel for v5.15.
> >
> > Do you want a Fixes: tag?
>
> It is a tricky situation. The phy patch is introduced in 5.9 and is backported to 5.8.
> But we don't have MaC internal delays on those kernels. So Fixes for 5.10+ will be ok I guess,
> So that at least this fix will land on cip 5.10 kernel.

Fixes: bbc4d71d63549bcd ("net: phy: realtek: fix rtl8211e rx/tx delay config")

Then the stable people are at least aware that backporting the PHY
commit can cause issues.

So after it has hit upstream, you can send the patch to stable with the
following added:

Cc: stable@vger.kernel.org # 5.10.x: a6f51f2efa742df0 ravb: Add
support for explicit internal clock delay configuration

I hope I got the syntax right. And there may be dependencies to backport,
too.

As this doesn't fix an issue introduced in v5.13 or v5.14-rc1, I'll queue
this for v5.15. CIP can still take it.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH] arm64: dts: renesas: rzg2: Add internal rx delay
  2021-07-23 16:00     ` Geert Uytterhoeven
@ 2021-07-23 16:08       ` Biju Das
  0 siblings, 0 replies; 5+ messages in thread
From: Biju Das @ 2021-07-23 16:08 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Rob Herring, Magnus Damm, Linux-Renesas,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Chris Paterson, Prabhakar Mahadev Lad

Hi Geert,

> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 23 July 2021 17:01
> To: Biju Das <biju.das.jz@bp.renesas.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Magnus Damm <magnus.damm@gmail.com>;
> Linux-Renesas <linux-renesas-soc@vger.kernel.org>; open list:OPEN FIRMWARE
> AND FLATTENED DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; Chris
> Paterson <Chris.Paterson2@renesas.com>; Prabhakar Mahadev Lad
> <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Subject: Re: [PATCH] arm64: dts: renesas: rzg2: Add internal rx delay
> 
> Hi Biju,
> 
> On Fri, Jul 23, 2021 at 5:52 PM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> > > Subject: Re: [PATCH] arm64: dts: renesas: rzg2: Add internal rx
> > > delay On Wed, Jul 21, 2021 at 8:06 PM Biju Das
> > > <biju.das.jz@bp.renesas.com>
> > > wrote:
> > > > Hihope boards use Realtek PHY. From the very beginning it use only
> > > > tx delays. However the phy driver commit bbc4d71d63549bcd003
> > > > ("net: phy: realtek: fix rtl8211e rx/tx delay config") introduced
> > > > NFS mount failure. Now it needs rx delay inaddition to tx delay
> > > > for NFS mount to work. This patch fixes NFS mount failure issue by
> > > > adding MAC internal rx delay.
> > > >
> > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > >
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will
> > > queue in renesas-devel for v5.15.
> > >
> > > Do you want a Fixes: tag?
> >
> > It is a tricky situation. The phy patch is introduced in 5.9 and is
> backported to 5.8.
> > But we don't have MaC internal delays on those kernels. So Fixes for
> > 5.10+ will be ok I guess, So that at least this fix will land on cip
> 5.10 kernel.
> 
> Fixes: bbc4d71d63549bcd ("net: phy: realtek: fix rtl8211e rx/tx delay
> config")
> 
> Then the stable people are at least aware that backporting the PHY commit
> can cause issues.

OK.

> So after it has hit upstream, you can send the patch to stable with the
> following added:
> 
> Cc: stable@vger.kernel.org # 5.10.x: a6f51f2efa742df0 ravb: Add support
> for explicit internal clock delay configuration
> 
> I hope I got the syntax right. And there may be dependencies to backport,
> too.
> 
> As this doesn't fix an issue introduced in v5.13 or v5.14-rc1, I'll queue
> this for v5.15. CIP can still take it.

Thank you. Will post the patch to stable once it hit mainline.

Regards,
Biju

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-07-23 16:08 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-21 18:06 [PATCH] arm64: dts: renesas: rzg2: Add internal rx delay Biju Das
2021-07-23 15:22 ` Geert Uytterhoeven
2021-07-23 15:52   ` Biju Das
2021-07-23 16:00     ` Geert Uytterhoeven
2021-07-23 16:08       ` Biju Das

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).