From: Sakari Ailus <sakari.ailus@iki.fi>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
linux-media@vger.kernel.org, Jacopo Mondi <jacopo@jmondi.org>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v4] media: rcar-isp: Add Renesas R-Car Image Signal Processor driver
Date: Wed, 28 Jul 2021 20:03:37 +0300 [thread overview]
Message-ID: <20210728170337.GD3@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <YQBIpRdwwd5hnMU+@oden.dyn.berto.se>
Hej Niklas,
On Tue, Jul 27, 2021 at 07:55:49PM +0200, Niklas Söderlund wrote:
...
> > > > > +static const struct v4l2_subdev_pad_ops risp_pad_ops = {
> > > > > + .set_fmt = risp_set_pad_format,
> > > > > + .get_fmt = risp_get_pad_format,
> > > >
> > > > Maybe set link_validate to v4l2_subdev_link_validate_default?
> > >
> > > I thought about that but with the multiplexed stream issue I thought it
> > > best to not to add that yet. Do you think this make sens?
> >
> > What would be the alternative? Without that, there's no guarantee
> > whatsoever what the input is. It may also enable writing user space that
> > breaks after fixing this in the driver.
>
> We still still don't have any guarantees whatsoever as we can only
> describe and validate one stream.
>
> >
> > Where in the pipeline would you have multiple streams over a single data
> > path?
>
> On Gen3 platforms without an ISP we have it on the rcar-csi2 sink pad
> and on Gen3 platforms with an ISP we have it on the rcar-isp sink pad.
> In both cases it's the IP block that separates the CSI-2 buss to the
> different capture engines.
Ok. In this case the driver may be better merged to the staging tree or
labelled experimental as its UAPI isn't stable. I wonder what Hans thinks.
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2021-07-28 17:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 7:57 [PATCH v4] media: rcar-isp: Add Renesas R-Car Image Signal Processor driver Niklas Söderlund
2021-07-27 13:16 ` Sakari Ailus
2021-07-27 13:34 ` Niklas Söderlund
2021-07-27 17:18 ` Sakari Ailus
2021-07-27 17:55 ` Niklas Söderlund
2021-07-28 17:03 ` Sakari Ailus [this message]
2021-07-28 18:04 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210728170337.GD3@valkosipuli.retiisi.eu \
--to=sakari.ailus@iki.fi \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo@jmondi.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).