* [PATCH v3 0/2] Document RZ/G2L SDHI controller bindings.
@ 2021-08-04 16:13 Biju Das
2021-08-04 16:13 ` [PATCH v3 1/2] dt-bindings: mmc: renesas,sdhi: Fix dtbs-check warning Biju Das
2021-08-04 16:13 ` [PATCH v3 2/2] dt-bindings: mmc: renesas,sdhi: Document RZ/G2L bindings Biju Das
0 siblings, 2 replies; 7+ messages in thread
From: Biju Das @ 2021-08-04 16:13 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring
Cc: Biju Das, Wolfram Sang, linux-mmc, devicetree,
Geert Uytterhoeven, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad, linux-renesas-soc
This patch series aims to document RZ/G2L SDHI controller bindings.
v2->v3:
* Created a seperate patch to fix the dtbs-warning check reported by [1].
* RZ/G2L SDHI binding patch depends up on the above the patch.
[1] https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20210804091940.23983-1-biju.das.jz@bp.renesas.com/
v1->v2:
* Fixed dtbs-check issue for RZ/A{1,2} platforms.
v1->
* newpatch
Biju Das (2):
dt-bindings: mmc: renesas,sdhi: Fix dtbs-check warning
dt-bindings: mmc: renesas,sdhi: Document RZ/G2L bindings
.../devicetree/bindings/mmc/renesas,sdhi.yaml | 119 ++++++++++++------
1 file changed, 79 insertions(+), 40 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3 1/2] dt-bindings: mmc: renesas,sdhi: Fix dtbs-check warning
2021-08-04 16:13 [PATCH v3 0/2] Document RZ/G2L SDHI controller bindings Biju Das
@ 2021-08-04 16:13 ` Biju Das
2021-08-13 17:39 ` Rob Herring
2021-08-04 16:13 ` [PATCH v3 2/2] dt-bindings: mmc: renesas,sdhi: Document RZ/G2L bindings Biju Das
1 sibling, 1 reply; 7+ messages in thread
From: Biju Das @ 2021-08-04 16:13 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring
Cc: Biju Das, Wolfram Sang, linux-mmc, devicetree,
Geert Uytterhoeven, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad, linux-renesas-soc
Fix dtbs-check warning pinctrl-names:0:'default' was expected
for r8a77470-iwg23s-sbc.dts file.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v3:
* New patch to fix the dtbs-check warnings
Ref:- https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20210804091940.23983-1-biju.das.jz@bp.renesas.com/
---
.../devicetree/bindings/mmc/renesas,sdhi.yaml | 65 ++++++++++++-------
1 file changed, 42 insertions(+), 23 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
index 677989bc5924..543eeb825dc3 100644
--- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
+++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
@@ -9,9 +9,6 @@ title: Renesas SDHI SD/MMC controller
maintainers:
- Wolfram Sang <wsa+renesas@sang-engineering.com>
-allOf:
- - $ref: "mmc-controller.yaml"
-
properties:
compatible:
oneOf:
@@ -104,14 +101,51 @@ properties:
pinctrl-1:
maxItems: 1
- pinctrl-names:
- minItems: 1
- items:
- - const: default
- - const: state_uhs
+ pinctrl-names: true
max-frequency: true
+allOf:
+ - $ref: "mmc-controller.yaml"
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: renesas,sdhi-mmc-r8a77470
+ then:
+ properties:
+ pinctrl-names:
+ items:
+ - const: state_uhs
+ else:
+ properties:
+ pinctrl-names:
+ minItems: 1
+ items:
+ - const: default
+ - const: state_uhs
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - renesas,sdhi-r7s72100
+ - renesas,sdhi-r7s9210
+ then:
+ properties:
+ clock-names:
+ items:
+ - const: core
+ - const: cd
+ required:
+ - clock-names
+ description:
+ The internal card detection logic that exists in these controllers is
+ sectioned off to be run by a separate second clock source to allow
+ the main core clock to be turned off to save power.
+
required:
- compatible
- reg
@@ -119,21 +153,6 @@ required:
- clocks
- power-domains
-if:
- properties:
- compatible:
- contains:
- enum:
- - renesas,sdhi-r7s72100
- - renesas,sdhi-r7s9210
-then:
- required:
- - clock-names
- description:
- The internal card detection logic that exists in these controllers is
- sectioned off to be run by a separate second clock source to allow
- the main core clock to be turned off to save power.
-
unevaluatedProperties: false
examples:
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v3 2/2] dt-bindings: mmc: renesas,sdhi: Document RZ/G2L bindings
2021-08-04 16:13 [PATCH v3 0/2] Document RZ/G2L SDHI controller bindings Biju Das
2021-08-04 16:13 ` [PATCH v3 1/2] dt-bindings: mmc: renesas,sdhi: Fix dtbs-check warning Biju Das
@ 2021-08-04 16:13 ` Biju Das
2021-08-13 17:41 ` Rob Herring
1 sibling, 1 reply; 7+ messages in thread
From: Biju Das @ 2021-08-04 16:13 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring
Cc: Biju Das, Wolfram Sang, linux-mmc, devicetree,
Geert Uytterhoeven, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad, linux-renesas-soc
Document RZ/G2L SDHI controller bindings.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v2->v3:
* This patch depends up on the previous patch in this series.
v1->v2:
* Fixed dtbs-check issue for RZ/A{1,2} platforms.
---
.../devicetree/bindings/mmc/renesas,sdhi.yaml | 54 +++++++++++++------
1 file changed, 37 insertions(+), 17 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
index 543eeb825dc3..e195ee5c0900 100644
--- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
+++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
@@ -44,19 +44,20 @@ properties:
- const: renesas,sdhi-mmc-r8a77470 # RZ/G1C (SDHI/MMC IP)
- items:
- enum:
- - renesas,sdhi-r8a774a1 # RZ/G2M
- - renesas,sdhi-r8a774b1 # RZ/G2N
- - renesas,sdhi-r8a774c0 # RZ/G2E
- - renesas,sdhi-r8a774e1 # RZ/G2H
- - renesas,sdhi-r8a7795 # R-Car H3
- - renesas,sdhi-r8a7796 # R-Car M3-W
- - renesas,sdhi-r8a77961 # R-Car M3-W+
- - renesas,sdhi-r8a77965 # R-Car M3-N
- - renesas,sdhi-r8a77970 # R-Car V3M
- - renesas,sdhi-r8a77980 # R-Car V3H
- - renesas,sdhi-r8a77990 # R-Car E3
- - renesas,sdhi-r8a77995 # R-Car D3
- - renesas,sdhi-r8a779a0 # R-Car V3U
+ - renesas,sdhi-r8a774a1 # RZ/G2M
+ - renesas,sdhi-r8a774b1 # RZ/G2N
+ - renesas,sdhi-r8a774c0 # RZ/G2E
+ - renesas,sdhi-r8a774e1 # RZ/G2H
+ - renesas,sdhi-r8a7795 # R-Car H3
+ - renesas,sdhi-r8a7796 # R-Car M3-W
+ - renesas,sdhi-r8a77961 # R-Car M3-W+
+ - renesas,sdhi-r8a77965 # R-Car M3-N
+ - renesas,sdhi-r8a77970 # R-Car V3M
+ - renesas,sdhi-r8a77980 # R-Car V3H
+ - renesas,sdhi-r8a77990 # R-Car E3
+ - renesas,sdhi-r8a77995 # R-Car D3
+ - renesas,sdhi-r8a779a0 # R-Car V3U
+ - renesas,sdhi-r9a07g044 # RZ/G2{L,LC}
- const: renesas,rcar-gen3-sdhi # R-Car Gen3 or RZ/G2
reg:
@@ -68,13 +69,11 @@ properties:
clocks:
minItems: 1
- maxItems: 2
+ maxItems: 4
clock-names:
minItems: 1
- items:
- - const: core
- - const: cd
+ maxItems: 4
dmas:
minItems: 4
@@ -135,6 +134,8 @@ allOf:
- renesas,sdhi-r7s9210
then:
properties:
+ clocks:
+ maxItems: 2
clock-names:
items:
- const: core
@@ -146,6 +147,25 @@ allOf:
sectioned off to be run by a separate second clock source to allow
the main core clock to be turned off to save power.
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: renesas,sdhi-r9a07g044
+ then:
+ properties:
+ clocks:
+ items:
+ - description: IMCLK, SDHI channel main clock1.
+ - description: IMCLK2, SDHI channel main clock2. When this clock is
+ turned off, external SD card detection cannot be
+ detected.
+ - description: CLK_HS, SDHI channel High speed clock which operates
+ 4 times that of SDHI channel main clock1.
+ - description: ACLK, SDHI channel bus clock.
+ required:
+ - resets
+
required:
- compatible
- reg
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: mmc: renesas,sdhi: Fix dtbs-check warning
2021-08-04 16:13 ` [PATCH v3 1/2] dt-bindings: mmc: renesas,sdhi: Fix dtbs-check warning Biju Das
@ 2021-08-13 17:39 ` Rob Herring
2021-08-13 18:03 ` Biju Das
0 siblings, 1 reply; 7+ messages in thread
From: Rob Herring @ 2021-08-13 17:39 UTC (permalink / raw)
To: Biju Das
Cc: Ulf Hansson, Wolfram Sang, linux-mmc, devicetree,
Geert Uytterhoeven, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad, linux-renesas-soc
On Wed, Aug 04, 2021 at 05:13:24PM +0100, Biju Das wrote:
> Fix dtbs-check warning pinctrl-names:0:'default' was expected
> for r8a77470-iwg23s-sbc.dts file.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v3:
> * New patch to fix the dtbs-check warnings
> Ref:- https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20210804091940.23983-1-biju.das.jz@bp.renesas.com/
> ---
> .../devicetree/bindings/mmc/renesas,sdhi.yaml | 65 ++++++++++++-------
> 1 file changed, 42 insertions(+), 23 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> index 677989bc5924..543eeb825dc3 100644
> --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> @@ -9,9 +9,6 @@ title: Renesas SDHI SD/MMC controller
> maintainers:
> - Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> -allOf:
> - - $ref: "mmc-controller.yaml"
> -
> properties:
> compatible:
> oneOf:
> @@ -104,14 +101,51 @@ properties:
> pinctrl-1:
> maxItems: 1
>
> - pinctrl-names:
> - minItems: 1
> - items:
> - - const: default
> - - const: state_uhs
> + pinctrl-names: true
>
> max-frequency: true
>
> +allOf:
> + - $ref: "mmc-controller.yaml"
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: renesas,sdhi-mmc-r8a77470
> + then:
> + properties:
> + pinctrl-names:
> + items:
> + - const: state_uhs
> + else:
> + properties:
> + pinctrl-names:
> + minItems: 1
> + items:
> + - const: default
> + - const: state_uhs
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,sdhi-r7s72100
> + - renesas,sdhi-r7s9210
> + then:
> + properties:
> + clock-names:
> + items:
> + - const: core
> + - const: cd
This is already defined in the main section, no need for it here.
> + required:
> + - clock-names
> + description:
> + The internal card detection logic that exists in these controllers is
> + sectioned off to be run by a separate second clock source to allow
> + the main core clock to be turned off to save power.
> +
> required:
> - compatible
> - reg
> @@ -119,21 +153,6 @@ required:
> - clocks
> - power-domains
>
> -if:
> - properties:
> - compatible:
> - contains:
> - enum:
> - - renesas,sdhi-r7s72100
> - - renesas,sdhi-r7s9210
> -then:
> - required:
> - - clock-names
> - description:
> - The internal card detection logic that exists in these controllers is
> - sectioned off to be run by a separate second clock source to allow
> - the main core clock to be turned off to save power.
> -
> unevaluatedProperties: false
>
> examples:
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: mmc: renesas,sdhi: Document RZ/G2L bindings
2021-08-04 16:13 ` [PATCH v3 2/2] dt-bindings: mmc: renesas,sdhi: Document RZ/G2L bindings Biju Das
@ 2021-08-13 17:41 ` Rob Herring
2021-08-13 18:10 ` Biju Das
0 siblings, 1 reply; 7+ messages in thread
From: Rob Herring @ 2021-08-13 17:41 UTC (permalink / raw)
To: Biju Das
Cc: Ulf Hansson, Wolfram Sang, linux-mmc, devicetree,
Geert Uytterhoeven, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad, linux-renesas-soc
On Wed, Aug 04, 2021 at 05:13:25PM +0100, Biju Das wrote:
> Document RZ/G2L SDHI controller bindings.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v2->v3:
> * This patch depends up on the previous patch in this series.
> v1->v2:
> * Fixed dtbs-check issue for RZ/A{1,2} platforms.
> ---
> .../devicetree/bindings/mmc/renesas,sdhi.yaml | 54 +++++++++++++------
> 1 file changed, 37 insertions(+), 17 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> index 543eeb825dc3..e195ee5c0900 100644
> --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> @@ -44,19 +44,20 @@ properties:
> - const: renesas,sdhi-mmc-r8a77470 # RZ/G1C (SDHI/MMC IP)
> - items:
> - enum:
> - - renesas,sdhi-r8a774a1 # RZ/G2M
> - - renesas,sdhi-r8a774b1 # RZ/G2N
> - - renesas,sdhi-r8a774c0 # RZ/G2E
> - - renesas,sdhi-r8a774e1 # RZ/G2H
> - - renesas,sdhi-r8a7795 # R-Car H3
> - - renesas,sdhi-r8a7796 # R-Car M3-W
> - - renesas,sdhi-r8a77961 # R-Car M3-W+
> - - renesas,sdhi-r8a77965 # R-Car M3-N
> - - renesas,sdhi-r8a77970 # R-Car V3M
> - - renesas,sdhi-r8a77980 # R-Car V3H
> - - renesas,sdhi-r8a77990 # R-Car E3
> - - renesas,sdhi-r8a77995 # R-Car D3
> - - renesas,sdhi-r8a779a0 # R-Car V3U
> + - renesas,sdhi-r8a774a1 # RZ/G2M
> + - renesas,sdhi-r8a774b1 # RZ/G2N
> + - renesas,sdhi-r8a774c0 # RZ/G2E
> + - renesas,sdhi-r8a774e1 # RZ/G2H
> + - renesas,sdhi-r8a7795 # R-Car H3
> + - renesas,sdhi-r8a7796 # R-Car M3-W
> + - renesas,sdhi-r8a77961 # R-Car M3-W+
> + - renesas,sdhi-r8a77965 # R-Car M3-N
> + - renesas,sdhi-r8a77970 # R-Car V3M
> + - renesas,sdhi-r8a77980 # R-Car V3H
> + - renesas,sdhi-r8a77990 # R-Car E3
> + - renesas,sdhi-r8a77995 # R-Car D3
> + - renesas,sdhi-r8a779a0 # R-Car V3U
> + - renesas,sdhi-r9a07g044 # RZ/G2{L,LC}
> - const: renesas,rcar-gen3-sdhi # R-Car Gen3 or RZ/G2
>
> reg:
> @@ -68,13 +69,11 @@ properties:
>
> clocks:
> minItems: 1
> - maxItems: 2
> + maxItems: 4
>
> clock-names:
> minItems: 1
> - items:
> - - const: core
> - - const: cd
> + maxItems: 4
The names need to be defined.
>
> dmas:
> minItems: 4
> @@ -135,6 +134,8 @@ allOf:
> - renesas,sdhi-r7s9210
> then:
> properties:
> + clocks:
> + maxItems: 2
> clock-names:
> items:
> - const: core
> @@ -146,6 +147,25 @@ allOf:
> sectioned off to be run by a separate second clock source to allow
> the main core clock to be turned off to save power.
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: renesas,sdhi-r9a07g044
> + then:
> + properties:
> + clocks:
> + items:
> + - description: IMCLK, SDHI channel main clock1.
> + - description: IMCLK2, SDHI channel main clock2. When this clock is
> + turned off, external SD card detection cannot be
> + detected.
> + - description: CLK_HS, SDHI channel High speed clock which operates
> + 4 times that of SDHI channel main clock1.
> + - description: ACLK, SDHI channel bus clock.
> + required:
> + - resets
> +
> required:
> - compatible
> - reg
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v3 1/2] dt-bindings: mmc: renesas,sdhi: Fix dtbs-check warning
2021-08-13 17:39 ` Rob Herring
@ 2021-08-13 18:03 ` Biju Das
0 siblings, 0 replies; 7+ messages in thread
From: Biju Das @ 2021-08-13 18:03 UTC (permalink / raw)
To: Rob Herring
Cc: Ulf Hansson, Wolfram Sang, linux-mmc, devicetree,
Geert Uytterhoeven, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad, linux-renesas-soc
Hi Rob,
Thanks for the feedback.
> Subject: Re: [PATCH v3 1/2] dt-bindings: mmc: renesas,sdhi: Fix dtbs-check
> warning
>
> On Wed, Aug 04, 2021 at 05:13:24PM +0100, Biju Das wrote:
> > Fix dtbs-check warning pinctrl-names:0:'default' was expected for
> > r8a77470-iwg23s-sbc.dts file.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> > v3:
> > * New patch to fix the dtbs-check warnings
> > Ref:-
> > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> > hwork.ozlabs.org%2Fproject%2Fdevicetree-bindings%2Fpatch%2F20210804091
> > 940.23983-1-biju.das.jz%40bp.renesas.com%2F&data=04%7C01%7Cbiju.da
> > s.jz%40bp.renesas.com%7C265c317c047442b7b49608d95e815cb6%7C53d82571da1
> > 947e49cb4625a166a4a2a%7C0%7C0%7C637644731970005717%7CUnknown%7CTWFpbGZ
> > sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3
> > D%7C1000&sdata=q4IgcCqJJPRomA3mhjkRNNdnSbgewIYAvhfBps6Y0Ng%3D&
> > reserved=0
> > ---
> > .../devicetree/bindings/mmc/renesas,sdhi.yaml | 65
> > ++++++++++++-------
> > 1 file changed, 42 insertions(+), 23 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > index 677989bc5924..543eeb825dc3 100644
> > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > @@ -9,9 +9,6 @@ title: Renesas SDHI SD/MMC controller
> > maintainers:
> > - Wolfram Sang <wsa+renesas@sang-engineering.com>
> >
> > -allOf:
> > - - $ref: "mmc-controller.yaml"
> > -
> > properties:
> > compatible:
> > oneOf:
> > @@ -104,14 +101,51 @@ properties:
> > pinctrl-1:
> > maxItems: 1
> >
> > - pinctrl-names:
> > - minItems: 1
> > - items:
> > - - const: default
> > - - const: state_uhs
> > + pinctrl-names: true
> >
> > max-frequency: true
> >
> > +allOf:
> > + - $ref: "mmc-controller.yaml"
> > +
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: renesas,sdhi-mmc-r8a77470
> > + then:
> > + properties:
> > + pinctrl-names:
> > + items:
> > + - const: state_uhs
> > + else:
> > + properties:
> > + pinctrl-names:
> > + minItems: 1
> > + items:
> > + - const: default
> > + - const: state_uhs
> > +
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - renesas,sdhi-r7s72100
> > + - renesas,sdhi-r7s9210
> > + then:
> > + properties:
> > + clock-names:
> > + items:
> > + - const: core
> > + - const: cd
>
> This is already defined in the main section, no need for it here.
Thanks missed it. Will fix it in the next version
Cheers,
Biju
>
> > + required:
> > + - clock-names
> > + description:
> > + The internal card detection logic that exists in these
> controllers is
> > + sectioned off to be run by a separate second clock source to
> allow
> > + the main core clock to be turned off to save power.
> > +
> > required:
> > - compatible
> > - reg
> > @@ -119,21 +153,6 @@ required:
> > - clocks
> > - power-domains
> >
> > -if:
> > - properties:
> > - compatible:
> > - contains:
> > - enum:
> > - - renesas,sdhi-r7s72100
> > - - renesas,sdhi-r7s9210
> > -then:
> > - required:
> > - - clock-names
> > - description:
> > - The internal card detection logic that exists in these controllers
> is
> > - sectioned off to be run by a separate second clock source to allow
> > - the main core clock to be turned off to save power.
> > -
> > unevaluatedProperties: false
> >
> > examples:
> > --
> > 2.17.1
> >
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v3 2/2] dt-bindings: mmc: renesas,sdhi: Document RZ/G2L bindings
2021-08-13 17:41 ` Rob Herring
@ 2021-08-13 18:10 ` Biju Das
0 siblings, 0 replies; 7+ messages in thread
From: Biju Das @ 2021-08-13 18:10 UTC (permalink / raw)
To: Rob Herring
Cc: Ulf Hansson, Wolfram Sang, linux-mmc, devicetree,
Geert Uytterhoeven, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad, linux-renesas-soc
Hi Rob,
Thanks for the feedback.
> Subject: Re: [PATCH v3 2/2] dt-bindings: mmc: renesas,sdhi: Document
> RZ/G2L bindings
>
> On Wed, Aug 04, 2021 at 05:13:25PM +0100, Biju Das wrote:
> > Document RZ/G2L SDHI controller bindings.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> > v2->v3:
> > * This patch depends up on the previous patch in this series.
> > v1->v2:
> > * Fixed dtbs-check issue for RZ/A{1,2} platforms.
> > ---
> > .../devicetree/bindings/mmc/renesas,sdhi.yaml | 54 +++++++++++++------
> > 1 file changed, 37 insertions(+), 17 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > index 543eeb825dc3..e195ee5c0900 100644
> > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > @@ -44,19 +44,20 @@ properties:
> > - const: renesas,sdhi-mmc-r8a77470 # RZ/G1C (SDHI/MMC IP)
> > - items:
> > - enum:
> > - - renesas,sdhi-r8a774a1 # RZ/G2M
> > - - renesas,sdhi-r8a774b1 # RZ/G2N
> > - - renesas,sdhi-r8a774c0 # RZ/G2E
> > - - renesas,sdhi-r8a774e1 # RZ/G2H
> > - - renesas,sdhi-r8a7795 # R-Car H3
> > - - renesas,sdhi-r8a7796 # R-Car M3-W
> > - - renesas,sdhi-r8a77961 # R-Car M3-W+
> > - - renesas,sdhi-r8a77965 # R-Car M3-N
> > - - renesas,sdhi-r8a77970 # R-Car V3M
> > - - renesas,sdhi-r8a77980 # R-Car V3H
> > - - renesas,sdhi-r8a77990 # R-Car E3
> > - - renesas,sdhi-r8a77995 # R-Car D3
> > - - renesas,sdhi-r8a779a0 # R-Car V3U
> > + - renesas,sdhi-r8a774a1 # RZ/G2M
> > + - renesas,sdhi-r8a774b1 # RZ/G2N
> > + - renesas,sdhi-r8a774c0 # RZ/G2E
> > + - renesas,sdhi-r8a774e1 # RZ/G2H
> > + - renesas,sdhi-r8a7795 # R-Car H3
> > + - renesas,sdhi-r8a7796 # R-Car M3-W
> > + - renesas,sdhi-r8a77961 # R-Car M3-W+
> > + - renesas,sdhi-r8a77965 # R-Car M3-N
> > + - renesas,sdhi-r8a77970 # R-Car V3M
> > + - renesas,sdhi-r8a77980 # R-Car V3H
> > + - renesas,sdhi-r8a77990 # R-Car E3
> > + - renesas,sdhi-r8a77995 # R-Car D3
> > + - renesas,sdhi-r8a779a0 # R-Car V3U
> > + - renesas,sdhi-r9a07g044 # RZ/G2{L,LC}
> > - const: renesas,rcar-gen3-sdhi # R-Car Gen3 or RZ/G2
> >
> > reg:
> > @@ -68,13 +69,11 @@ properties:
> >
> > clocks:
> > minItems: 1
> > - maxItems: 2
> > + maxItems: 4
> >
> > clock-names:
> > minItems: 1
> > - items:
> > - - const: core
> > - - const: cd
> > + maxItems: 4
>
> The names need to be defined.
Will do. Here we have 3 cases, single clock-name for majority of SoC's, Two clock-names for sdhi-r7s9210 ("core" and "cd")
and 4 clock names for sdhi-r9a07g044 ("mainclk1", "mainclk2", "hsclk" and "busclk")
Cheers,
Biju
>
> >
> > dmas:
> > minItems: 4
> > @@ -135,6 +134,8 @@ allOf:
> > - renesas,sdhi-r7s9210
> > then:
> > properties:
> > + clocks:
> > + maxItems: 2
> > clock-names:
> > items:
> > - const: core
> > @@ -146,6 +147,25 @@ allOf:
> > sectioned off to be run by a separate second clock source to
> allow
> > the main core clock to be turned off to save power.
> >
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: renesas,sdhi-r9a07g044
> > + then:
> > + properties:
> > + clocks:
> > + items:
> > + - description: IMCLK, SDHI channel main clock1.
> > + - description: IMCLK2, SDHI channel main clock2. When this
> clock is
> > + turned off, external SD card detection
> cannot be
> > + detected.
> > + - description: CLK_HS, SDHI channel High speed clock which
> operates
> > + 4 times that of SDHI channel main clock1.
> > + - description: ACLK, SDHI channel bus clock.
> > + required:
> > + - resets
> > +
> > required:
> > - compatible
> > - reg
> > --
> > 2.17.1
> >
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-08-13 18:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-04 16:13 [PATCH v3 0/2] Document RZ/G2L SDHI controller bindings Biju Das
2021-08-04 16:13 ` [PATCH v3 1/2] dt-bindings: mmc: renesas,sdhi: Fix dtbs-check warning Biju Das
2021-08-13 17:39 ` Rob Herring
2021-08-13 18:03 ` Biju Das
2021-08-04 16:13 ` [PATCH v3 2/2] dt-bindings: mmc: renesas,sdhi: Document RZ/G2L bindings Biju Das
2021-08-13 17:41 ` Rob Herring
2021-08-13 18:10 ` Biju Das
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).