From: Rob Herring <robh@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Lee Jones" <lee.jones@linaro.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Chris Paterson" <Chris.Paterson2@renesas.com>,
"Biju Das" <biju.das@bp.renesas.com>,
"Prabhakar Mahadev Lad" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: pwm: Add RZ/G2L GPT binding
Date: Tue, 17 May 2022 16:01:28 -0500 [thread overview]
Message-ID: <20220517210128.GA1630873-robh@kernel.org> (raw)
In-Reply-To: <20220510144259.9908-2-biju.das.jz@bp.renesas.com>
On Tue, May 10, 2022 at 03:42:58PM +0100, Biju Das wrote:
> Add device tree bindings for the General PWM Timer (GPT).
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> RFC->v1:
> * Added Description
> * Removed comments from reg and clock
> ---
> .../bindings/pwm/renesas,rzg2l-gpt.yaml | 131 ++++++++++++++++++
> 1 file changed, 131 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/renesas,rzg2l-gpt.yaml
>
> diff --git a/Documentation/devicetree/bindings/pwm/renesas,rzg2l-gpt.yaml b/Documentation/devicetree/bindings/pwm/renesas,rzg2l-gpt.yaml
> new file mode 100644
> index 000000000000..b57c1b256a86
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/renesas,rzg2l-gpt.yaml
> @@ -0,0 +1,131 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/renesas,rzg2l-gpt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas RZ/G2L General PWM Timer (GPT)
> +
> +maintainers:
> + - Biju Das <biju.das.jz@bp.renesas.com>
> +
> +description:
> + RZ/G2L General PWM Timer (GPT) composed of 8 channels with 32-bit timer
> + (GPT32E). It supports the following functions
> + * 32 bits × 8 channels.
You need a '|' after 'description:' if you want formatting preserved.
> + * Up-counting or down-counting (saw waves) or up/down-counting
> + (triangle waves) for each counter.
> + * Clock sources independently selectable for each channel.
> + * Two I/O pins per channel.
> + * Two output compare/input capture registers per channel.
> + * For the two output compare/input capture registers of each channel,
> + four registers are provided as buffer registers and are capable of
> + operating as comparison registers when buffering is not in use.
> + * In output compare operation, buffer switching can be at crests or
> + troughs, enabling the generation of laterally asymmetric PWM waveforms.
> + * Registers for setting up frame cycles in each channel (with capability
> + for generating interrupts at overflow or underflow)
> + * Generation of dead times in PWM operation.
> + * Synchronous starting, stopping and clearing counters for arbitrary
> + channels.
> + * Starting, stopping, clearing and up/down counters in response to input
> + level comparison.
> + * Starting, clearing, stopping and up/down counters in response to a
> + maximum of four external triggers.
> + * Output pin disable function by dead time error and detected
> + short-circuits between output pins.
> + * A/D converter start triggers can be generated (GPT32E0 to GPT32E3)
> + * Enables the noise filter for input capture and external trigger
> + operation.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - renesas,r9a07g044-gpt # RZ/G2{L,LC}
> + - renesas,r9a07g054-gpt # RZ/V2L
> + - const: renesas,rzg2l-gpt
> +
> + reg:
> + maxItems: 1
> +
> + '#pwm-cells':
> + const: 2
> + description: |
> + See pwm.yaml in this directory for a description of the cells format.
Drop. No need to describe common properties.
> +
> + interrupts:
> + items:
> + - description: GTCCRA input capture/compare match
> + - description: GTCCRB input capture/compare
> + - description: GTCCRC compare match
> + - description: GTCCRD compare match
> + - description: GTCCRE compare match
> + - description: GTCCRF compare match
> + - description: GTADTRA compare match
> + - description: GTADTRB compare match
> + - description: GTCNT overflow/GTPR compare match
> + - description: GTCNT underflow
> +
> + interrupt-names:
> + items:
> + - const: ccmpa
> + - const: ccmpb
> + - const: cmpc
> + - const: cmpd
> + - const: cmpe
> + - const: cmpf
> + - const: adtrga
> + - const: adtrgb
> + - const: ovf
> + - const: unf
> +
> + clocks:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-names
> + - clocks
> + - power-domains
> + - resets
> +
> +allOf:
> + - $ref: pwm.yaml#
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/r9a07g044-cpg.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + gpt4: pwm@10048400 {
> + compatible = "renesas,r9a07g044-gpt", "renesas,rzg2l-gpt";
> + reg = <0x10048400 0xa4>;
> + interrupts = <GIC_SPI 270 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 271 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 272 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 273 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 274 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 275 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 276 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 277 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 278 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 279 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "ccmpa", "ccmpb", "cmpc", "cmpd",
> + "cmpe", "cmpf", "adtrga", "adtrgb",
> + "ovf", "unf";
> + clocks = <&cpg CPG_MOD R9A07G044_GPT_PCLK>;
> + power-domains = <&cpg>;
> + resets = <&cpg R9A07G044_GPT_RST_C>;
> + #pwm-cells = <2>;
> + };
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2022-05-17 21:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 14:42 [PATCH 0/2] Add support for RZ/G2L GPT Biju Das
2022-05-10 14:42 ` [PATCH 1/2] dt-bindings: pwm: Add RZ/G2L GPT binding Biju Das
2022-05-16 6:51 ` Uwe Kleine-König
2022-05-16 7:02 ` Biju Das
2022-05-17 21:01 ` Rob Herring [this message]
2022-05-18 5:46 ` Biju Das
2022-05-19 9:22 ` Geert Uytterhoeven
2022-05-19 9:23 ` Geert Uytterhoeven
2022-05-10 14:42 ` [PATCH 2/2] pwm: Add support for RZ/G2L GPT Biju Das
2022-05-10 16:34 ` Uwe Kleine-König
2022-06-01 19:25 ` Biju Das
2022-06-02 7:43 ` Uwe Kleine-König
2022-06-06 12:33 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517210128.GA1630873-robh@kernel.org \
--to=robh@kernel.org \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).