From: Biju Das <biju.das.jz@bp.renesas.com>
To: Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: "Biju Das" <biju.das.jz@bp.renesas.com>,
"Vincent Mailhol" <mailhol.vincent@wanadoo.fr>,
"Stefan Mätje" <stefan.maetje@esd.eu>,
"Ulrich Hecht" <uli+renesas@fpond.eu>,
"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Fabrizio Castro" <fabrizio.castro.jz@renesas.com>,
"Chris Paterson" <Chris.Paterson2@renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: [PATCH v3 0/6] R-Car CAN FD driver enhancements
Date: Thu, 27 Oct 2022 09:21:52 +0100 [thread overview]
Message-ID: <20221027082158.95895-1-biju.das.jz@bp.renesas.com> (raw)
The CAN FD IP found on RZ/G2L SoC has some HW features different to that
of R-Car. For example, it has multiple resets, dedicated channel tx
and error interrupts, separate global rx and error interrupts compared
to shared irq for R-Car. it does not s ECC error flag registers
and clk post divider present on R-Car.
Similarly, R-Car V3U has 8 channels whereas other SoCs has only 2
channels. Currently all the HW differences are handled by comparing
with chip_id enum.
This patch series aims to replace chip_id with struct rcar_canfd_hw_info
to handle the HW feature differences and driver data present
on both IPs.
The changes are trivial and tested on RZ/G2L SMARC EVK.
This patch series depend upon[1]
[1] https://lore.kernel.org/linux-renesas-soc/20221025155657.1426948-1-biju.das.jz@bp.renesas.com/T/#t
v2->v3:
* Replaced data type of max_channels from unsigned int->u8 to save memory.
* Replaced data type of postdiv from unsigned int->u8 to save memory.
v1->v2:
* Updated commit description for R-Car V3U SoC detection using
driver data.
* Replaced data type of max_channels from u32->unsigned int.
* Replaced multi_global_irqs->shared_global_irqs to make it
positive checks.
* Replaced clk_postdiv->postdiv driver data variable.
* Simplified the calcualtion for fcan_freq.
* Replaced info->has_gerfl to gpriv->info->has_gerfl and wrapped
the ECC error flag checks inside a single if statement.
* Added Rb tag from Geert patch#1,#2,#3 and #5
Biju Das (6):
can: rcar_canfd: rcar_canfd_probe: Add struct rcar_canfd_hw_info to
driver data
can: rcar_canfd: Add max_channels to struct rcar_canfd_hw_info
can: rcar_canfd: Add shared_global_irqs to struct rcar_canfd_hw_info
can: rcar_canfd: Add postdiv to struct rcar_canfd_hw_info
can: rcar_canfd: Add multi_channel_irqs to struct rcar_canfd_hw_info
can: rcar_canfd: Add has_gerfl_eef to struct rcar_canfd_hw_info
drivers/net/can/rcar/rcar_canfd.c | 104 ++++++++++++++++++------------
1 file changed, 63 insertions(+), 41 deletions(-)
--
2.25.1
next reply other threads:[~2022-10-27 8:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 8:21 Biju Das [this message]
2022-10-27 8:21 ` [PATCH v3 1/6] can: rcar_canfd: rcar_canfd_probe: Add struct rcar_canfd_hw_info to driver data Biju Das
2022-10-27 8:21 ` [PATCH v3 2/6] can: rcar_canfd: Add max_channels to struct rcar_canfd_hw_info Biju Das
2022-10-27 8:21 ` [PATCH v3 3/6] can: rcar_canfd: Add shared_global_irqs " Biju Das
2022-10-27 8:21 ` [PATCH v3 4/6] can: rcar_canfd: Add postdiv " Biju Das
2022-10-28 9:31 ` Geert Uytterhoeven
2022-10-28 9:36 ` Biju Das
2022-10-27 8:21 ` [PATCH v3 5/6] can: rcar_canfd: Add multi_channel_irqs " Biju Das
2022-10-27 8:21 ` [PATCH v3 6/6] can: rcar_canfd: Add has_gerfl_eef " Biju Das
2022-10-28 10:12 ` Geert Uytterhoeven
2022-10-28 10:22 ` Biju Das
2022-10-28 10:24 ` Marc Kleine-Budde
2022-10-28 10:53 ` Biju Das
2022-10-31 14:57 ` Biju Das
2022-10-31 15:17 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221027082158.95895-1-biju.das.jz@bp.renesas.com \
--to=biju.das.jz@bp.renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=stefan.maetje@esd.eu \
--cc=uli+renesas@fpond.eu \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).