From: Marek Vasut <marek.vasut@gmail.com>
To: masonccyang@mxic.com.tw,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: bbrezillon@kernel.org, broonie@kernel.org,
devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms@verge.net.au>,
juliensu@mxic.com.tw, lee.jones@linaro.org,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-spi@vger.kernel.org, mark.rutland@arm.com,
robh+dt@kernel.org, zhengxunli@mxic.com.tw
Subject: Re: [PATCH v9 2/3] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver
Date: Wed, 10 Apr 2019 08:27:55 +0200 [thread overview]
Message-ID: <2095d059-8276-a01a-7c3a-da4647f7b7df@gmail.com> (raw)
In-Reply-To: <OFC7F0028A.CFF6BD04-ON482583D8.00084FA1-482583D8.0008985F@mxic.com.tw>
On 4/10/19 3:33 AM, masonccyang@mxic.com.tw wrote:
> Hi Sergei,
>
>> > +static ssize_t rpc_spi_mem_dirmap_write(struct spi_mem_dirmap_desc
> *desc,
>> > + u64 offs, size_t len, const void *buf)
>> > +{
>> > + struct rpc_spi *rpc =
>> > + spi_controller_get_devdata(desc->mem->spi->controller);
>> > + int ret;
>> > +
>> > + if (offs + desc->info.offset + len > U32_MAX)
>> > + return -EINVAL;
>> > +
>> > + if (len > RPC_WBUF_SIZE)
>> > + len = RPC_WBUF_SIZE;
>> > +
>> > + ret = rpc_spi_set_freq(rpc, desc->mem->spi->max_speed_hz);
>> > + if (ret)
>> > + return ret;
>> > +
>> > + rpc_spi_mem_set_prep_op_cfg(desc->mem->spi,
>> > + &desc->info.op_tmpl, &offs, &len);
>> > +
>> > + regmap_update_bits(rpc->regmap, RPC_CMNCR, RPC_CMNCR_MD,
> RPC_CMNCR_MD);
>> > +
>> > + regmap_write(rpc->regmap, RPC_SMDRENR, 0);
>> > +
>> > + regmap_update_bits(rpc->regmap, RPC_PHYCNT, RPC_PHYCNT_STRTIM(7) |
>> > + RPC_PHYCNT_WBUF2 | RPC_PHYCNT_WBUF,
>> > + RPC_PHYCNT_WBUF2 | RPC_PHYCNT_WBUF);
>> > +
>> > + memcpy_toio(rpc->wbuf, buf, len);
>>
>> Wait, doesn't the manual say that the whole 256-byte buffer should be
>> filled? I think that short chunks have to be written w/o WBUF (done,
> in fact,
>> by the HF driver).
>>
>
> From spi-nor.c layer always transfer 256 bytes data with page program
> command.
Does that apply even for flashes with not-256-byte pages ?
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2019-04-10 6:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 8:20 [PATCH v9 0/3] mfd: Add Renesas R-Car Gen3 RPC-IF MFD driver Mason Yang
2019-03-29 8:20 ` [PATCH v9 1/3] mfd: Add Renesas R-Car Gen3 RPC-IF MFD controller driver Mason Yang
2019-03-29 10:43 ` Marek Vasut
2019-03-29 15:12 ` Sergei Shtylyov
2019-03-29 8:20 ` [PATCH v9 2/3] spi: Add Renesas R-Car Gen3 RPC-IF SPI " Mason Yang
2019-03-29 10:44 ` Marek Vasut
2019-03-29 15:52 ` Sergei Shtylyov
[not found] ` <OF7F1B534F.B934A9FE-ON482583D0.001DC618-482583D0.001FE84B@mxic.com.tw>
2019-04-02 20:10 ` Sergei Shtylyov
[not found] ` <OFAEA16021.C7F7B095-ON482583D1.0031A13D-482583D1.00335085@mxic.com.tw>
2019-04-04 18:56 ` Sergei Shtylyov
2019-04-04 19:12 ` Boris Brezillon
2019-04-06 19:59 ` Sergei Shtylyov
2019-04-09 11:20 ` Sergei Shtylyov
2019-04-10 19:47 ` Sergei Shtylyov
2019-04-09 20:07 ` Sergei Shtylyov
[not found] ` <OFC7F0028A.CFF6BD04-ON482583D8.00084FA1-482583D8.0008985F@mxic.com.tw>
2019-04-10 6:27 ` Marek Vasut [this message]
[not found] ` <OF75EDBF48.5C308F1B-ON482583D8.0027A537-482583D8.002C0A64@mxic.com.tw>
2019-04-10 8:03 ` Marek Vasut
2019-04-10 8:11 ` Boris Brezillon
2019-04-10 17:53 ` Sergei Shtylyov
2019-04-13 16:38 ` Sergei Shtylyov
2019-04-13 16:39 ` Sergei Shtylyov
[not found] ` <OF82CE76E9.E6395EF7-ON482583DD.000E37D7-482583DD.000E5077@mxic.com.tw>
2019-04-17 18:44 ` Sergei Shtylyov
[not found] ` <OF4ABCC306.B053BA23-ON482583E0.000F480C-482583E0.000FAD4A@mxic.com.tw>
2019-04-18 19:43 ` Sergei Shtylyov
[not found] ` <OF58AAFF49.C4593DEB-ON482583E1.001D551E-482583E1.001F089D@LocalDomain>
[not found] ` <OFE74649D4.F69BB5EF-ON482583E1.0033F73F-482583E1.00344ED2@mxic.com.tw>
2019-04-22 16:44 ` Sergei Shtylyov
[not found] ` <OF58AAFF49.C4593DEB-ON482583E1.001D551E-482583E1.001F089D@mxic.com.tw>
2019-04-23 7:29 ` Geert Uytterhoeven
2019-05-14 19:06 ` Sergei Shtylyov
2019-05-14 19:13 ` Sergei Shtylyov
2019-03-29 8:20 ` [PATCH v9 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF controller bindings Mason Yang
2019-03-29 10:45 ` Marek Vasut
2019-03-29 10:49 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2095d059-8276-a01a-7c3a-da4647f7b7df@gmail.com \
--to=marek.vasut@gmail.com \
--cc=bbrezillon@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=juliensu@mxic.com.tw \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masonccyang@mxic.com.tw \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=zhengxunli@mxic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).