From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2B7EC4338F for ; Wed, 4 Aug 2021 20:50:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6F5961037 for ; Wed, 4 Aug 2021 20:50:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230495AbhHDUvA (ORCPT ); Wed, 4 Aug 2021 16:51:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230218AbhHDUu7 (ORCPT ); Wed, 4 Aug 2021 16:50:59 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58380C0613D5; Wed, 4 Aug 2021 13:50:45 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id g13so6647379lfj.12; Wed, 04 Aug 2021 13:50:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KuX2nZN6oxnkjT2+Ul+G9XcJgN0y9zUMTpdYgLkps1M=; b=aLLT2WMnJaB4DDV9rb0esrzta5Rq13NILvpwdHxvjGhlE+kLPbtxtQu2VsJd/jUuYv kZfiXsRJjhdj4Jv53r2XMsYFy90mMKmktwPPEw2rmC0d24QH2ma1IQs8upvbmqmpDf/m pCn6yGFOJfnnzYbP/jDW/SEUJE3YMjjF8SWP8fPSv2XhlxmlMa2Rc8uPG6ah9l8/0Ib/ LYpUarKcDdb2ixFZ8qDens2Wsa8/HTE/xnmPynLhZ3M+q17MhUr1I+6KJe6UKfYKhYPF n7Ys5wft1Drm+McE+wT9erDJy90CdCYnNBZWQZpWRtp85egrvOzt3KdT9WapACdhOGOT NClg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KuX2nZN6oxnkjT2+Ul+G9XcJgN0y9zUMTpdYgLkps1M=; b=Rg2RUrNVOu3/z7GM+HA3ew7K6dUYtEpVIAYlTWqFj1/FM8bS74R9kgiUWStzHjqEji J8K+lF3e/joVjzI9QaDBMjhWyVwxaz4JNmY1sgnNTAnXEdbNpRGSoOGFP94VLB57LBTc SupLgvsf6Z4y3ftrp2u44SSI2WoNPFnjKFEYS78czQrkvIjaY8ECQmb4xZkcaZPWDG3T 3V8+A7jxXwaK6RW8BNa3hsetifDakNKN/YD4hcEsFEggsXdH3f8khfc+O5NyGKSaj+ZS PbaSB8fB6VUKrA5NOIXSSUGUQexETsZCL3EExcOymaBhMmA4MV/Z1ErRRluNW98+B432 qjHw== X-Gm-Message-State: AOAM5332fRonko0h7sLfscDxIXCn5L0F1X7Pjtx6GBmGqdgSv849NYnB eoz0ZXoPo7Oy7/1kj3zQ2ys= X-Google-Smtp-Source: ABdhPJzazXFRKR4ajGz5yML6j2znPd12Aw229fJqxkzLbr8fkB0qzCN8FJTWx09o8pfA6beF3QR9QQ== X-Received: by 2002:a19:d609:: with SMTP id n9mr808225lfg.198.1628110243660; Wed, 04 Aug 2021 13:50:43 -0700 (PDT) Received: from [192.168.1.102] ([178.176.77.221]) by smtp.gmail.com with ESMTPSA id z25sm295465lfh.283.2021.08.04.13.50.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Aug 2021 13:50:43 -0700 (PDT) Subject: Re: [PATCH net-next v2 8/8] ravb: Add tx_drop_cntrs to struct ravb_hw_info To: Biju Das , "David S. Miller" , Jakub Kicinski Cc: Geert Uytterhoeven , Sergey Shtylyov , Adam Ford , Andrew Lunn , Yuusuke Ashizuka , Yoshihiro Shimoda , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Chris Paterson , Biju Das , Prabhakar Mahadev Lad References: <20210802102654.5996-1-biju.das.jz@bp.renesas.com> <20210802102654.5996-9-biju.das.jz@bp.renesas.com> From: Sergei Shtylyov Message-ID: <24d63e2c-8f3b-9f75-a917-e7dc79085c84@gmail.com> Date: Wed, 4 Aug 2021 23:50:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210802102654.5996-9-biju.das.jz@bp.renesas.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On 8/2/21 1:26 PM, Biju Das wrote: > The register for retrieving TX drop counters is present only on R-Car Gen3 > and RZ/G2L; it is not present on R-Car Gen2. > > Add the tx_drop_cntrs hw feature bit to struct ravb_hw_info, to enable this > feature specifically for R-Car Gen3 now and later extend it to RZ/G2L. > > Signed-off-by: Biju Das > Reviewed-by: Lad Prabhakar > --- > v2: > * Incorporated Andrew and Sergei's review comments for making it smaller patch > and provided detailed description. > --- > drivers/net/ethernet/renesas/ravb.h | 1 + > drivers/net/ethernet/renesas/ravb_main.c | 4 +++- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h > index 0d640dbe1eed..35fbb9f60ba8 100644 > --- a/drivers/net/ethernet/renesas/ravb.h > +++ b/drivers/net/ethernet/renesas/ravb.h > @@ -1001,6 +1001,7 @@ struct ravb_hw_info { > > /* hardware features */ > unsigned internal_delay:1; /* RAVB has internal delays */ > + unsigned tx_drop_cntrs:1; /* RAVB has TX error counters */ I suggest 'tx_counters' -- this name comes from the sh_eth driver for the same regs (but negated meaning). And please don't call the hardware RAVB. :-) [...] MBR, Sergei