From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: Jacopo Mondi <jacopo@jmondi.org>,
laurent.pinchart@ideasonboard.com,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/3] scripts/boards.sh: Fix M3-W identifier
Date: Mon, 22 Jun 2020 11:45:46 +0100 [thread overview]
Message-ID: <2628f76b-b26f-c1e1-d3e3-1809d8113cae@ideasonboard.com> (raw)
In-Reply-To: <20200622103441.GA3448812@oden.dyn.berto.se>
On 22/06/2020 11:34, Niklas Söderlund wrote:
> Hi Kieran,
>
> On 2020-06-22 10:53:12 +0100, Kieran Bingham wrote:
>> Hi Jacopo,
>>
>> On 15/06/2020 13:19, Jacopo Mondi wrote:
>>> The M3-W SoC has been renamed to r8a77960, adjust the board.sh script to
>>> identify it correctly.
>>>
>>
>> We probably don't need to keep backwards compatibility indeed ...
>
> If the cost is low, as in this case I think backwards compatibility is
> nice. More often then not do I bisect over large ranges and then it's
> nice that things like this "just work" ;-)
Ah yes, bisecting indeed would be useful here.
>
>>
>>> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
>>> ---
>>> scripts/boards.sh | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/scripts/boards.sh b/scripts/boards.sh
>>> index 0ec2981..2069494 100644
>>> --- a/scripts/boards.sh
>>> +++ b/scripts/boards.sh
>>> @@ -13,7 +13,7 @@ case $info in
>>> vins="0 1 2 3 4 5 6 7"
>>> csis="20 40 41"
>>> ;;
>>> - "Renesas Salvator-X board based on r8a7796" | \
So perhaps this line should be re-added, or the fields updated for
wildcards some how, or a better form of matching the target.
Things like the H3 could be tricky though where the ES1 and ES2
revisions (I think from what I recall) might have subtle differences.
I guess in that case it's harder to make a catch-all match, but that's
just a per-target thing to consider.
--
Kieran
>>> + "Renesas Salvator-X board based on r8a77960" | \
>>> "Renesas Salvator-X 2nd version board based on r8a77965")
>>
>> But I wonder if this script should use more 'wildcard' matching.
>> It does seem awkward to match generically in some cases though, so
>> nothing wrong with keeping things explicit for now.
>>
>> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>>
>> But now I've written that I see these patches are already integrated ...
>> never mind.
>> --
>> Kieran
>>
>>
>>> gen="gen3"
>>> vins="0 1 2 3 4 5 6 7"
>>>
>>
>
next prev parent reply other threads:[~2020-06-22 10:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200615121935.108142-1-jacopo@jmondi.org>
2020-06-15 12:19 ` [PATCH 1/3] scripts/boards.sh: Fix M3-W identifier Jacopo Mondi
2020-06-22 9:53 ` Kieran Bingham
2020-06-22 10:34 ` Niklas Söderlund
2020-06-22 10:45 ` Kieran Bingham [this message]
2020-06-15 12:19 ` [PATCH 2/3] scripts/boards.sh: Add support for M3-W+ SoC Jacopo Mondi
2020-06-15 12:19 ` [PATCH 3/3] scripts/boards.sh: Add support for E3 SoC Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2628f76b-b26f-c1e1-d3e3-1809d8113cae@ideasonboard.com \
--to=kieran.bingham+renesas@ideasonboard.com \
--cc=jacopo@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).