From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C73FC43387 for ; Sun, 16 Dec 2018 17:25:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E5212086C for ; Sun, 16 Dec 2018 17:25:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mfpMG5Er" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730496AbeLPRZu (ORCPT ); Sun, 16 Dec 2018 12:25:50 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:51151 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730449AbeLPRZu (ORCPT ); Sun, 16 Dec 2018 12:25:50 -0500 Received: by mail-wm1-f67.google.com with SMTP id n190so10155340wmd.0; Sun, 16 Dec 2018 09:25:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dv29gNdsEgaKN5VzTvn6Xaw+DARBT4jvQJ/wTsKVgSI=; b=mfpMG5ErB5ipsPtuLJEDU4ucNtlHuwFMy8QkIZ7GmKRJN3fJWY0SpQdsxLUYt1P1RW Q78fsl7dNFo4DaqL/1KOXTJlGUjhhrSQ+I7j6XCInxmFr++L9Gwa9LV7OBhsX36nQh/O b8TwO4rE7WAxEeHbGw+5TzzRTywVj9NBxiw4T+K9r8ZFYKHKLikquJC3SWLBjo9wjJLq 0ZMTl6DI7n8+4jd+rRb02mCvtmBoVrn0bkhcwKKs8NSYQI6S+Ll9rR0dUH2aygDQVCkH R04vqEddtEsXSAM+48nxWde9YPI4Jhf5S1zLZ0b3BhpiFuvryAR4rD3tjJ+rjPQ/eqoR K7Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dv29gNdsEgaKN5VzTvn6Xaw+DARBT4jvQJ/wTsKVgSI=; b=sThgo0+WR3aPwPKYUt9CNV7EudHMtdMIbvPeMwPm8a6WU32NdwxcLjI7tfZbOu4d21 mucNoEIYoVmiE5Xk5QEBp6CNr1OPwp4L2SknS0Awy5FEbAIdvpBzN5vDORMeDh5OE8Sj OF66Z8KILh7RvA+oaigNvfvdVGmSHKOdbHyH3sUeg/THCJZEG9Ic2ak2LfNJ99fIx7nu unieXsqDiEubJz+j/99DX1fWL4riln32JhHx1eJ5WIjIFfe08ScBn0uCWvoI0ttw1izU aOR9qkleoL011/AvGcBytI4XY4WpeXDmZAPxBJhkzM8fnzSOeC61LvhO1ejArF7hTqFF vx7Q== X-Gm-Message-State: AA+aEWb5UGFxerWibER2CsFySbmit61kjrE2DSI3nolAgxTv6wTJzoLS 1fUlDMgUWAhKOEg8xMiyF4c= X-Google-Smtp-Source: AFSGD/VyklwVbQoeNHj54Nug285tcY/k7A7XT1GxBBx3390NHPcIgxaz/DtFBqtiVZeH2GUuAIzuuQ== X-Received: by 2002:a1c:b70b:: with SMTP id h11mr9584726wmf.72.1544981147157; Sun, 16 Dec 2018 09:25:47 -0800 (PST) Received: from [192.168.1.4] (ip-86-49-110-70.net.upcbroadband.cz. [86.49.110.70]) by smtp.gmail.com with ESMTPSA id w16sm14778953wrp.1.2018.12.16.09.25.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 16 Dec 2018 09:25:46 -0800 (PST) Subject: Re: [PATCH 1/6] thermal: split thermal_zone_of_sensor_register{,_param}() To: Geert Uytterhoeven Cc: Eduardo Valentin , Linux PM list , Linux-Renesas , Marek Vasut , Daniel Lezcano , Wolfram Sang , Zhang Rui , Geert Uytterhoeven References: <20181212014927.25840-1-marek.vasut+renesas@gmail.com> <20181212014927.25840-2-marek.vasut+renesas@gmail.com> <20181215172351.GB10311@localhost.localdomain> <270eeb39-140f-7f55-75d3-c2a6d9ab4034@gmail.com> <076ebc8e-32a3-99bf-6d8a-7a0bae22b427@gmail.com> <09902cc4-ef25-cd36-0d4a-effeabcd233f@gmail.com> From: Marek Vasut Message-ID: <31978c47-cd1b-7c61-0d6a-09e443147b52@gmail.com> Date: Sun, 16 Dec 2018 18:25:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On 12/16/2018 09:39 AM, Geert Uytterhoeven wrote: > Hi Marek, Hi, > On Sat, Dec 15, 2018 at 9:13 PM Marek Vasut wrote: >> On 12/15/2018 09:00 PM, Geert Uytterhoeven wrote: >>> On Sat, Dec 15, 2018 at 8:07 PM Marek Vasut wrote: >>>> On 12/15/2018 07:54 PM, Geert Uytterhoeven wrote: >>>>> On Sat, Dec 15, 2018 at 7:49 PM Marek Vasut wrote: >>>>>> On 12/15/2018 07:47 PM, Geert Uytterhoeven wrote: >>>>>>> On Sat, Dec 15, 2018 at 7:38 PM Marek Vasut wrote: >>>>>>>> On 12/15/2018 06:23 PM, Eduardo Valentin wrote: >>>>>>>>> On Wed, Dec 12, 2018 at 02:49:22AM +0100, Marek Vasut wrote: >>>>>>>>>> Introduce new thermal_zone_of_sensor_register_params() function, which >>>>>>>>>> allows passing struct thermal_zone_params into it and convert original >>>>>>>>>> thermal_zone_of_sensor_register() to call it with params set to NULL. >>>>>>>>>> >>>>>>>>>> Signed-off-by: Marek Vasut >>>>>>>>> >>>>>>>>> Git complains about mismatch between From: and this SOB. >>>>>>>> >>>>>>>> I recall a discussion about gmail stripping the +foo tags from email >>>>>>>> addresses. I can add a From: tag into the patch to override this >>>>>>>> braindeath, or is there a better solution ? >>>>>>> >>>>>>> Run the "git format-patch" command from a git repo where user.email >>>>>>> is marek.vasut@gmail.com, so it will retain the original From: tag in the >>>>>>> email body, as it is different? >>>>>> >>>>>> I can also manually patch the From tags or add them, but it's all >>>>>> workarounds. >>>>> >>>>> Use a different outgoing email server? I use my ISP's. >>>> >>>> Or maybe it'd make sense to fix git to handle the +tags correctly ? >>> >>> What needs to be fixed? >>> If user.email != From, git format-patch generates a From: header, else >>> it doesn't. Doesn't that make sense? >> >> I believe the complaint here is that email address in From does not >> match email address in SoB line, because some SMTP servers scrub the >> +foo tag from From: and not from SoB-line . And yet, the SoB line is > > Some SMTP servers (Hi Gmail!) scrub the +foo tag from the From: _header_ > in the email. As the SoB is in the _body_ it is not affected. > Hence the solution is to include the correct From: in the _body_. This is basically what I said. > Git actually does that automatically, assumed your user.email config matches > the From: address that is used in your outgoing email delivery path (i.e. the > scrubbed one, when using Gmail's SMTP server). > If you lie to git in your user.email config, git cannot do the right > thing, obviously. My git user.email obviously matches the From: field , before the scrubbing, which I believe is the correct thing to do. >> from the same person/email address as the email address in From, so they >> are equal. > > If they differ, they are not equal ;-) Depends on how you define 'equal' . Here I think foo+bar@example.com should be considered equal to foo@example.com . > While many mail servers ignore +foo when delivering email to mailboxes, > this is not the case for all of them. So ignoring +foo is not the universal > solution. > >> I think git should just ignore the +foo tag in SoB line. > > Where should "git" ignore the +foo tag? Is it actually git that complains? > Eduardo: Do you mean checkpatch? ;-) Possibly. I ran checkpatch after git format-patch and it didn't complain. > I did enhance checkpatch with a check to verify that patches carry SoB tags > from their authors, as too many people got that wrong, causing complaints > from sfr in linux-next later. As usual, it's better to get things right as early > as possible in the process, to avoid rework. Aha, so maybe that enhancement needs further enhancement to scrub the +tags before the check ? > So the problem is on the patch sending side, not on the patch verification > receiving side. > Hence please fix your email setup, thanks! See above. -- Best regards, Marek Vasut