From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,URI_HEX autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45465C43387 for ; Thu, 10 Jan 2019 14:38:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F8F5214C6 for ; Thu, 10 Jan 2019 14:38:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c/JdHOTn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729177AbfAJOiK (ORCPT ); Thu, 10 Jan 2019 09:38:10 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:44723 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729001AbfAJOiK (ORCPT ); Thu, 10 Jan 2019 09:38:10 -0500 Received: by mail-wr1-f65.google.com with SMTP id z5so11604659wrt.11 for ; Thu, 10 Jan 2019 06:38:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+zBpDDhECaWA4EBkDI+7tfihYPVUH2Fx0JQFyPg7mJE=; b=c/JdHOTnP4ODfK/QPl5jPohOKusObD4Wc7AyY6wD1zWUKl7243tXVjxLOHC/vCqIC6 Hvyn8LG6ZyDRdhcJXpbkBnSYgW/2XVaof5YCjfzVmOJrZ+3KLWUVZAXKX6Xxv/mrU5AC nKSjuMoRov0hcVCiaEc/gNm52lYIATfKuzsxQHF/54Qs0se6AbAXNKWM8jPwz4X8w6UF kAyVGY8xuZhLFIbrr0RDlj7idRGpaCC86EeMBHG38gbXXsgXCWULZLg0LaeOSm2X9lB0 AdUFr1i/krTwJ378TWsYoSA1CuZYZi/2qkEFHvJ/bg3nCb43EypAbUqs0UrRFXUMJDJL TTcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+zBpDDhECaWA4EBkDI+7tfihYPVUH2Fx0JQFyPg7mJE=; b=hgleUDE+3EASPYizeYu/63qn7kdWFJlkTcvpnbBIhrhXlAjoYCW0jr7adzHIJLeHy2 qoevHWGIe4IYeqTOyVWVvVFYZkI9PTfSFse8QnjT/nCrw3RykCYZopBC1ZqoTidlvlmM NnedD1CVJt1ATenJXxx1ka++lLLM77poMOuffr80dTfa64pCdfxH03Zk3bro8hXcCsZ0 DIHyH+gRfbUFttMekH2UmhirLG+u/17KNQRY19OkhSaRKssqGbSZ+YGu3Ys/IDoFne6b k8a3/MTIdxH14NiU6LlV9JwRMtPuroqj9IbePYYqtg2G1zzyfuNWKTlVLYZj6vVGF5wv Orrg== X-Gm-Message-State: AJcUukdRc/EbVbcwONVtmU+SV0tq5VwZrVjvs9X8iuBrWM8I8EPkoKdS rkDy8G0277zhW9KO6Pdcr3Q= X-Google-Smtp-Source: ALg8bN5+Zaj68GHQzbDIi9s5CZm9At9aKhk4zbEwNfPMg1AyurajUk0zFlXufAmHxgB1STYe7exlLA== X-Received: by 2002:adf:f101:: with SMTP id r1mr9739441wro.32.1547131088035; Thu, 10 Jan 2019 06:38:08 -0800 (PST) Received: from [192.168.1.4] (ip-86-49-110-70.net.upcbroadband.cz. [86.49.110.70]) by smtp.gmail.com with ESMTPSA id x20sm22068984wme.6.2019.01.10.06.38.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Jan 2019 06:38:07 -0800 (PST) Subject: Re: [PATCH] arm64: dts: renesas: r8a77990: ebisu: Fix backlight regulator numbering To: Simon Horman , Geert Uytterhoeven Cc: Linux ARM , Linux-Renesas , Laurent Pinchart , Wolfram Sang , Marek Vasut References: <20190109140045.17449-1-marek.vasut@gmail.com> <20190109165822.tmj7qbho46f7clvg@verge.net.au> <20190110100202.4eqyge7vadlmodsy@verge.net.au> From: Marek Vasut Openpgp: preference=signencrypt Message-ID: <33d99771-695e-97ba-dfcb-25e08c91d300@gmail.com> Date: Thu, 10 Jan 2019 14:40:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <20190110100202.4eqyge7vadlmodsy@verge.net.au> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On 1/10/19 11:02 AM, Simon Horman wrote: > On Wed, Jan 09, 2019 at 05:58:23PM +0100, Simon Horman wrote: >> On Wed, Jan 09, 2019 at 04:26:25PM +0100, Geert Uytterhoeven wrote: >>> On Wed, Jan 9, 2019 at 3:01 PM wrote: >>>> From: Marek Vasut >>>> >>>> There are two regulator1 nodes in the Ebisu DTS right now, one 3.3V for >>>> the eMMC and one 12V for the backlight. This causes one to be overwritten >>>> by the other, ultimatelly resulting in inoperable eMMC, which depends on >>>> the former. Fix this by renumbering the backlight regulator to regulator2. >>>> >>>> Signed-off-by: Marek Vasut >>>> Cc: Laurent Pinchart >>>> Cc: Simon Horman >>>> Cc: Wolfram Sang >>>> Cc: linux-renesas-soc@vger.kernel.org >>>> Reported-by: Simon Horman >>>> Fixes: 9d16c4a10e07 ("arm64: dts: renesas: r8a77990: ebisu: Add backlight") >>> >>> Reviewed-by: Geert Uytterhoeven >>> >>>> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts >>>> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts >>>> @@ -191,7 +191,7 @@ >>>> clock-frequency = <24576000>; >>>> }; >>>> >>>> - reg_12p0v: regulator1 { >>>> + reg_12p0v: regulator2 { >>>> compatible = "regulator-fixed"; >>>> regulator-name = "D12.0V"; >>>> regulator-min-microvolt = <12000000>; >>> >>> Perhaps the node name should get a more descriptive suffix >>> (e.g. "regulator-12p0v"), like is already done for some of the other >>> regulators? >> >> I think I would prefer that addressed in a follow-up patch. > > Thanks for this patch. > > I have now tested it and it looks good to me. > I can now access eMMC as a block device. > > Tested-by: Simon Horman > > I plan to apply this for v5.1 as the problem appears to > be introduced in a patch queued-up for v5.1. Thanks > # dmesg | egrep "(ee160000.sd|mmc0|mmcblk0|backlight)" > [ 0.893760] pwm-backlight backlight: Linked as a consumer to regulator.3 > [ 2.901953] renesas_sdhi_internal_dmac ee160000.sd: Linked as a consumer to regulator.2 > [ 2.910262] renesas_sdhi_internal_dmac ee160000.sd: Linked as a consumer to regulator.1 > [ 2.967591] renesas_sdhi_internal_dmac ee160000.sd: mmc0 base at 0xee160000 max clock rate 200 MHz > [ 3.049943] mmc0: new HS200 MMC card at address 0001 > [ 3.055843] mmcblk0: mmc0:0001 BGSD3R 29.1 GiB > [ 3.064414] mmcblk0boot0: mmc0:0001 BGSD3R partition 1 16.0 MiB > [ 3.074888] mmcblk0boot1: mmc0:0001 BGSD3R partition 2 16.0 MiB > [ 3.081522] mmcblk0rpmb: mmc0:0001 BGSD3R partition 3 4.00 MiB, chardev (243:0) > > # dd if=/dev/mmcblk0 of=/dev/null bs=1M count=512 iflag=direct > 512+0 records in > 512+0 records out > 536870912 bytes (537 MB) copied, 14.7343 s, 36.4 MB/s > # dd if=/dev/mmcblk0 of=/dev/null bs=1M count=512 iflag=direct > 512+0 records in > 512+0 records out > 536870912 bytes (537 MB) copied, 8.46809 s, 63.4 MB/s > # dd if=/dev/mmcblk0 of=/dev/null bs=1M count=512 iflag=direct > 512+0 records in > 512+0 records out > 536870912 bytes (537 MB) copied, 14.6945 s, 36.5 MB/s Seems a bit slow to me for an HS200 card :-) Update your ATF, it has QoS updates for SDHI. -- Best regards, Marek Vasut