From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8611DC3B184 for ; Sat, 8 Feb 2020 19:07:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 60872227BF for ; Sat, 8 Feb 2020 19:07:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="w0JdVEgT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727505AbgBHTHk (ORCPT ); Sat, 8 Feb 2020 14:07:40 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:39990 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727490AbgBHTHj (ORCPT ); Sat, 8 Feb 2020 14:07:39 -0500 Received: by mail-lj1-f196.google.com with SMTP id n18so2752395ljo.7 for ; Sat, 08 Feb 2020 11:07:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=q+vjXU2SW2HOdfOFCkX7livwJmowb74J31opeMZWUCA=; b=w0JdVEgTe4SS+T8Svfog6mLAmWZXFIwgC71xGQqk2YbPV+MgtSYLwJCUnqbuKx8+Uh u50q+ll5mqnMS7iOwjH6yhEL/+AOxKXpVOH4bxJadba4hQQkudbbwW2yJbbVJ1dED4gK wrt0X/U8D0gjOIz71tSYEotpqYiQROKSBzbW38Nq6uMuBT2TNTaKFuevQjHPf28VsNhM d76Ue5OuvTSg/91VKorHegpXZpdC8A/4USXNauaeNukjXZXGDmEN/fVCi0/bnOUB/UKo Q8WtQgNlSbo2zvGBKClFIRFrKxMbg1VPI3r10Bf5XYITJw1QX3ls88Y9F7c82MgDDm67 KtHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=q+vjXU2SW2HOdfOFCkX7livwJmowb74J31opeMZWUCA=; b=W6TCapwrylV1fQqnpke3n6O/Zed/ic6IH7mdLBgsoq5XFXLsmPjNigge2BOMg7KEYG KQTa4CJOa1O7a2of0iRPdOcxdlyJCo3Ga7EpbBgENLPDdZqyW9VRFxwzCcRwbWaJqDvJ YG5qKpE6bLpSnkynRRKh9e6Lbj8+ejIjqRLn1G7caASXJacpgfqlt0A0DDdVg43FZzi2 0rY2NKj2nUZIueJwiLk77N3zf47r/7afrT59XiBQ4e3OsdUtgvpVhVQ6p4ju+kr/W1Xe 406f6xZhAtIqIAipEX+bVv/TMDW0ho1eYyyKt/1AbEd6SmDe5+5BVUO0nLKykWEyNg26 bBEg== X-Gm-Message-State: APjAAAUc3EbFPgNdf22U7iaG4mFGbBKSZIe1F627+FwLQCTl+I7c8Eui htGvUPOVAOtJ8+zIGxdti3+Ifw== X-Google-Smtp-Source: APXvYqw+hv9rxpIg4ETFyGzRDGxPLYofUNYjHEUqHuRFb3fygBzmWxL7+wK/VYmQ6OV/4Fn5/LcxYw== X-Received: by 2002:a2e:9696:: with SMTP id q22mr3229986lji.54.1581188856412; Sat, 08 Feb 2020 11:07:36 -0800 (PST) Received: from wasted.cogentembedded.com ([2a00:1fa0:48a2:c7a4:1f8a:70c9:2c66:3e73]) by smtp.gmail.com with ESMTPSA id w9sm3508790ljh.106.2020.02.08.11.07.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 08 Feb 2020 11:07:35 -0800 (PST) Subject: Re: [PATCH v4 2/6] PCI: rcar: Fix calculating mask for PCIEPAMR register To: Lad Prabhakar , Bjorn Helgaas , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Kishon Vijay Abraham I , Lorenzo Pieralisi , Arnd Bergmann , Greg Kroah-Hartman , Jingoo Han , Gustavo Pimentel , Marek Vasut , Yoshihiro Shimoda , Shawn Lin , Heiko Stuebner Cc: Andrew Murray , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Lad Prabhakar References: <20200208183641.6674-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20200208183641.6674-3-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <374e26ca-cd3d-fd12-edad-5f24622b9d3d@cogentembedded.com> Date: Sat, 8 Feb 2020 22:07:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20200208183641.6674-3-prabhakar.mahadev-lad.rj@bp.renesas.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hello! On 02/08/2020 09:36 PM, Lad Prabhakar wrote: > The mask value was calculated incorrectly for PCIEPAMR register if the > size was less the 128bytes, this patch fixes the above by adding a check Less than, perhaps? > on size. > > Signed-off-by: Lad Prabhakar [...] MBR, Sergei