linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] irqchip/renesas-irqc: Remove devm_kzalloc()/ioremap_nocache() error printing
Date: Tue, 30 Apr 2019 11:12:38 +0300	[thread overview]
Message-ID: <3ecf87e2-4e70-9159-a364-d41f1b744f7b@cogentembedded.com> (raw)
In-Reply-To: <20190429152006.22593-3-geert+renesas@glider.be>

Hello!

On 29.04.2019 18:20, Geert Uytterhoeven wrote:

> There is no need to print a message if devm_kzalloc() or

    Just kzalloc() in this case.

> ioremap_nocache() fails, as the memory allocation core already takes
> care of that.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>   drivers/irqchip/irq-renesas-irqc.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-renesas-irqc.c b/drivers/irqchip/irq-renesas-irqc.c
> index 438a063c76156d98..0955ffe12b32eb36 100644
> --- a/drivers/irqchip/irq-renesas-irqc.c
> +++ b/drivers/irqchip/irq-renesas-irqc.c
> @@ -133,7 +133,6 @@ static int irqc_probe(struct platform_device *pdev)
>   
>   	p = kzalloc(sizeof(*p), GFP_KERNEL);
>   	if (!p) {
> -		dev_err(&pdev->dev, "failed to allocate driver data\n");
>   		ret = -ENOMEM;
>   		goto err0;
>   	}
> @@ -173,7 +172,6 @@ static int irqc_probe(struct platform_device *pdev)
>   	/* ioremap IOMEM and setup read/write callbacks */
>   	p->iomem = ioremap_nocache(io->start, resource_size(io));
>   	if (!p->iomem) {
> -		dev_err(&pdev->dev, "failed to remap IOMEM\n");
>   		ret = -ENXIO;

    -ENOMEM?

[...]

MBR, Sergei

  reply	other threads:[~2019-04-30  8:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-29 15:20 [PATCH 0/5] irqchip/renesas-irqc: Miscellaneous cleanups and improvements Geert Uytterhoeven
2019-04-29 15:20 ` [PATCH 1/5] irqchip/renesas-irqc: Remove unneeded inclusion of <linux/spinlock.h> Geert Uytterhoeven
2019-05-13 12:04   ` Simon Horman
2019-04-29 15:20 ` [PATCH 2/5] irqchip/renesas-irqc: Remove devm_kzalloc()/ioremap_nocache() error printing Geert Uytterhoeven
2019-04-30  8:12   ` Sergei Shtylyov [this message]
2019-04-30 11:59     ` Geert Uytterhoeven
2019-05-13 12:04   ` Simon Horman
2019-04-29 15:20 ` [PATCH 3/5] irqchip/renesas-irqc: Add helper variable dev = &pdev->dev Geert Uytterhoeven
2019-05-13 12:15   ` Simon Horman
2019-04-29 15:20 ` [PATCH 4/5] irqchip/renesas-irqc: Replace irqc_priv.pdev by irqc_priv.dev Geert Uytterhoeven
2019-05-13 12:15   ` Simon Horman
2019-04-29 15:20 ` [PATCH 5/5] irqchip/renesas-irqc: Convert to managed initializations Geert Uytterhoeven
2019-05-13 12:15   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ecf87e2-4e70-9159-a364-d41f1b744f7b@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=geert+renesas@glider.be \
    --cc=jason@lakedaemon.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).