From: Marek Vasut <marek.vasut@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-pci <linux-pci@vger.kernel.org>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Phil Edworthy <phil.edworthy@renesas.com>,
Simon Horman <horms+renesas@verge.net.au>,
Wolfram Sang <wsa@the-dreams.de>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH V3 4/6] PCI: rcar: Replace (8 * n) with (n << 3)
Date: Mon, 25 Mar 2019 12:34:46 +0100 [thread overview]
Message-ID: <42898ac5-1385-cdad-6abc-f32096c8e74d@gmail.com> (raw)
In-Reply-To: <CAMuHMdUCWHR9zLz0Ru41860UhpUdjRvDBxDFoA5CdaAFrONJmQ@mail.gmail.com>
On 3/25/19 9:26 AM, Geert Uytterhoeven wrote:
> Hi Marek,
>
> On Sat, Mar 23, 2019 at 2:54 AM <marek.vasut@gmail.com> wrote:
>> From: Marek Vasut <marek.vasut+renesas@gmail.com>
>>
>> Replace (8 * n) with (n << 3) to make bit shift operations consistent.
>> No functional change.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>
> Thanks for your patch!
>
> Where is the inconsistency? The driver consistently uses
> 1. multiplications for bit offset calculations,
> 2. shifts for bit field extraction or insertion.
>
> While technically equivalent, I think your change makes the code harder
> to read: the values are multiplied by eight to convert from number of
> bytes to number of bits, so IMHO "BITS_PER_BYTE * n" would be more
> readable.
Sure
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2019-03-25 11:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 1:53 [PATCH V3 1/6] PCI: rcar: Clean up remaining macros defining bits marek.vasut
2019-03-23 1:53 ` [PATCH V3 2/6] PCI: rcar: Replace unsigned long with u32 in register accessors marek.vasut
2019-03-25 8:07 ` Geert Uytterhoeven
2019-03-25 11:24 ` Marek Vasut
2019-03-23 1:53 ` [PATCH V3 3/6] PCI: rcar: Replace various variable types with unsigned ones for register values marek.vasut
2019-03-25 8:14 ` Geert Uytterhoeven
2019-03-23 1:53 ` [PATCH V3 4/6] PCI: rcar: Replace (8 * n) with (n << 3) marek.vasut
2019-03-25 8:26 ` Geert Uytterhoeven
2019-03-25 11:34 ` Marek Vasut [this message]
2019-03-23 1:53 ` [PATCH V3 5/6] PCI: rcar: Clean up debug messages marek.vasut
2019-03-23 1:53 ` [PATCH V3 6/6] PCI: rcar: Fix 64bit MSI message address handling marek.vasut
2019-03-25 8:28 ` Geert Uytterhoeven
2019-03-25 8:03 ` [PATCH V3 1/6] PCI: rcar: Clean up remaining macros defining bits Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42898ac5-1385-cdad-6abc-f32096c8e74d@gmail.com \
--to=marek.vasut@gmail.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=horms+renesas@verge.net.au \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=phil.edworthy@renesas.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).