From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC2B8C2D0DC for ; Thu, 2 Jan 2020 14:52:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A316B20848 for ; Thu, 2 Jan 2020 14:52:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=tronnes.org header.i=@tronnes.org header.b="FizrheWO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728544AbgABOwt (ORCPT ); Thu, 2 Jan 2020 09:52:49 -0500 Received: from smtp.domeneshop.no ([194.63.252.55]:39335 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728528AbgABOwt (ORCPT ); Thu, 2 Jan 2020 09:52:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tronnes.org ; s=ds201912; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OAnAY2vaA2S1dqxbsSKJAdvKdXR2aLsZd3RWqY191tg=; b=FizrheWOtuPgPxIwSY3pmaukdy qcfrcCXhyJ6PVkypQHNu5mFvM7XrDvPEzrrRKiP03hLsAO4G2L1HMc04Cs+33YWU69ig1HQEq7GYE VgAE5hlIs5s8Bb8B/SejLyUKV9MSeAKRNv9ip9q67BqI4tJ1kitg6OfFn91jLhphnhaAwjApOmuLc QY8lCXBNPPyLLstZX7rFpVPgvJHZMfZXrTF1X1uJQ2bhns7A9fXy+RNa0g/SPaBTyaREIBafz/D0v WPZceY2kEttZHY9NJvwcmHtHspH8Z+nSnudItDpyH92lAGSCTWE4ujempd9WWAn+juyKvfcmVH8C9 aDSiBFUQ==; Received: from 211.81-166-168.customer.lyse.net ([81.166.168.211]:57723 helo=[192.168.10.61]) by smtp.domeneshop.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1in1qA-0005O0-Jf; Thu, 02 Jan 2020 15:52:46 +0100 Subject: Re: [PATCH] drm/mipi_dbi: Fix off-by-one bugs in mipi_dbi_blank() To: Geert Uytterhoeven , Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Daniel Vetter Cc: Thierry Reding , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20191230130604.31006-1-geert+renesas@glider.be> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: <4702e72d-b452-2f87-6c5c-f46321eb071a@tronnes.org> Date: Thu, 2 Jan 2020 15:52:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20191230130604.31006-1-geert+renesas@glider.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Den 30.12.2019 14.06, skrev Geert Uytterhoeven: > When configuring the frame memory window, the last column and row > numbers are written to the column resp. page address registers. These > numbers are thus one less than the actual window width resp. height. > > While this is handled correctly in mipi_dbi_fb_dirty() since commit > 03ceb1c8dfd1e293 ("drm/tinydrm: Fix setting of the column/page end > addresses."), it is not in mipi_dbi_blank(). The latter still forgets > to subtract one when calculating the most significant bytes of the > column and row numbers, thus programming wrong values when the display > width or height is a multiple of 256. > > Fixes: 02dd95fe31693626 ("drm/tinydrm: Add MIPI DBI support") > Signed-off-by: Geert Uytterhoeven > --- Thanks, applied to drm-misc-next. Noralf.