From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7FCEC5ACBF for ; Fri, 13 Mar 2020 08:37:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8AF712074B for ; Fri, 13 Mar 2020 08:37:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=xs4all.nl header.i=@xs4all.nl header.b="VJFK31Pl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726365AbgCMIhZ (ORCPT ); Fri, 13 Mar 2020 04:37:25 -0400 Received: from lb1-smtp-cloud8.xs4all.net ([194.109.24.21]:38291 "EHLO lb1-smtp-cloud8.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726300AbgCMIhZ (ORCPT ); Fri, 13 Mar 2020 04:37:25 -0400 Received: from [192.168.2.10] ([46.9.234.233]) by smtp-cloud8.xs4all.net with ESMTPA id Cfokj1LVWhVf8CfoojOB6e; Fri, 13 Mar 2020 09:37:22 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s1; t=1584088642; bh=NPDVj0hDHGTudN6m2hDl5vDuc6roQ9SfR7NRCqmST08=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=VJFK31PlgtKdUTAxIara79MLK1CVGweGI7JNsxuMwfny6tUCzfmjwR/Ok+rBhCKm4 vp/K0TVQtSUjMWbHGxUDrQAFg7qn36l23L1SrvnibLCOJVEAiy0hPhG8AMB+eahLBa zBe/m0OAedra3RvsdPdODrLiTOW3jDKEcC/EpK0Q8d9B93ZuZGt2RhsIF/OzDtjWVj FIMNOITjFlfVHzTCZY99QEPe0KVgRhKor1Lg31JEZ7/mj4l1aWUv6jkWdC7zcu52cX 6H+m3TxXVjNJB49bjlSU+JZS/43x61R9UZfQ3u086crPMOhFkaelvXKp62VVnWtQA6 +irAiNbazUH4Q== Subject: Re: [PATCH 0/8] media: i2c: adv748x: add support for HDMI audio To: Alex Riesen , Kieran Bingham , Mauro Carvalho Chehab , Laurent Pinchart , Rob Herring , Mark Rutland , devel@driverdev.osuosl.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: <20200113141459.GA3606@pflmari> <20200313083107.GB3832@pflmari> From: Hans Verkuil Message-ID: <4ab3dd9f-26fb-ce38-170c-bba4b3777455@xs4all.nl> Date: Fri, 13 Mar 2020 09:37:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200313083107.GB3832@pflmari> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfEcFIdVlB9n0Nfwlt2moC+Rr0T6Ztdr9G19F2RB1eRFOSl2wOxKv/b8i6Fz/VKQa8SUmHLYTHSddHNm5REyThEuU4PFzEJRphQtUmiTZzUYoCoyecA3w +BVXVJyWIZrIZKDL8z9L1TKRYFZknkUQyQ49SMwmjXgVCW4xmoRqsX9rdGNHDMGRTUtODvQOlV2as0WcL9kKkaPO9suFLNN2HM061XgDf45b28+2X69DP51V WNRc6ARJs1Bv9pdWRHNTHVEg3pqd+pdo8nAQctf0AIlR7RzV7c2RSeuDVFwTUFoid+F/7XZaPTxrDH1j+C2P8nuQ87NdnuDSfJ6vNyjmGjbl2TW6jHfeWGRh JYcODhFG4JNDPDKexZmMwpUJzeuwmLQ8b1rDhNGXOFYGfSphmsMzNazI5OMqMuAU45q9BeIBFuYDZCGq8gmIfAVr1MYc/neBUfTmc6DPYAUOHHUuytXTLOXU RfrwpaDirMluhPP5UUgb7Vqn6kstrSTyRvV9R6EIRuJOu+sSXC/0tQgGdni3Fdoe/CpFGmI9TVCVpRDc3K91dCYoqvYoFGxxyYOuGoGpfFQr2qWrkIoCMsNs OMs= Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On 3/13/20 9:31 AM, Alex Riesen wrote: > Hi Hans, > > Hans Verkuil, Fri, Mar 13, 2020 09:21:05 +0100: >> As a general note for this series: it might be better to have two >> patch series: one for patches 1 and 3-6 (not sure whether 5 can be included >> or not), and one where the public API changes (i.e. new V4L2 audio controls) >> are added. The first can probably be merged fairly quickly, the second will >> likely require more iterations since public API patches always take much longer >> before they are mature. > > I see. After the discussion started, I started to have suspicions of my own > regarding the V4L2 ioctls. Except for log-status, which is a practical > diagnostics feature (even supported by v4l2-ctl), I'm thinking about dropping > them altogether in favor of audio soc DAI implementation. > The DAI implementation does all we ever needed from the device. Besides, > selecting a I2S protocol variant from user space (I2S vs I2S/TDM) never felt > right. That sounds like what everyone else does as well. > > Shall I submit the log-status separately? Yes please. In my experience, log status is a very nice and very useful feature. If you have other sensible cleanups, then feel free to add those as well. Regards, Hans > > Regards, > Alex > >> On 1/13/20 3:14 PM, Alex Riesen wrote: >>> This adds minimal support for controlling the audio output I2S port available >>> on ADV7481 and ADV7482 HDMI decoder devices by ADI. The port carries audio >>> signal from the decoded HDMI stream. >>> >>> An ADV7482 on the Renesas Salvator-X ES1.1 was used during development of this >>> code. >>> >>> Alex Riesen (8): >>> 1. media: adv748x: add a device-specific wrapper for register block read >>> 2. media: adv748x: add audio mute control and output selection ioctls >>> 3. media: adv748x: add log_status ioctl >>> 4. media: adv748x: reserve space for the audio (I2S) port in the driver >>> structures >>> 5. media: adv748x: add an ASoC DAI definition to the driver >>> 6. media: adv748x: reduce amount of code for bitwise modification of >>> device registers >>> 7. dt-bindings: adv748x: add information about serial audio interface >>> (I2S/TDM) >>> 8. arm64: dts: renesas: salvator: add a connection from adv748x codec >>> (HDMI input) to the R-Car SoC >>> >>> .../devicetree/bindings/media/i2c/adv748x.txt | 13 +- >>> .../dts/renesas/r8a7795-es1-salvator-x.dts | 24 +- >>> .../boot/dts/renesas/salvator-common.dtsi | 35 +- >>> drivers/media/i2c/adv748x/adv748x-core.c | 54 +++ >>> drivers/media/i2c/adv748x/adv748x-hdmi.c | 355 ++++++++++++++++++ >>> drivers/media/i2c/adv748x/adv748x.h | 53 ++- >>> 6 files changed, 523 insertions(+), 11 deletions(-) >>>