From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D29DBC433E0 for ; Thu, 14 May 2020 18:58:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACACA2074A for ; Thu, 14 May 2020 18:58:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="UIOgyXdw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729396AbgENS6a (ORCPT ); Thu, 14 May 2020 14:58:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728021AbgENS63 (ORCPT ); Thu, 14 May 2020 14:58:29 -0400 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF5E6C061A0C for ; Thu, 14 May 2020 11:58:28 -0700 (PDT) Received: by mail-lf1-x143.google.com with SMTP id a9so3544242lfb.8 for ; Thu, 14 May 2020 11:58:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=U/lybLQIQS2N1+og65uWDJh60FcJXGkTJn4UrO6Vxak=; b=UIOgyXdwOHqI5BVYlF4CN7E8PorgZfZJ0GquOGTe5W2w7PaCShZcmK8FqlKYtpsQJO fFqmhO9GGWQVDCVqcTWjPBB7Jn/pZ+0G+9e5YN1QbpFS43k1wS/lbdaQu98+CqwEoIDw xBLfxYyD2WalWsJTEmCLRFCB5MOE7OerylAScC/BkJQQVrTW4H+QInBvvDfyOtAxZtmI Dm2/X8Xp9QYfO/+ZFKHY8YaQVSZenTryiSx226MRBX0XPWPY/j+U7CZtFeX+kIv0oH1M cez/JPGeatRm0GHsK5WzRYPubOJSbytxT5M6DutoywCaKVODHf9rmpyTcFxp9Gwlp4iA 4JCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=U/lybLQIQS2N1+og65uWDJh60FcJXGkTJn4UrO6Vxak=; b=qiJhRaV+lxt9jBpINzhUglpEBkX13R/HGH/oSOQMeJdZNUQLMUAgKd7WMqa4KX8wLd +L7XyyzQm6eRmtW9u9QmCljntrGDCLafD/C7BU6FQD6RxpviaT+B45WmJwwZX0hWgh10 dMdsdS3O788+cUAwvB4WsHj1JLwMQO9/i7OEgNQI81YWuq8jK8eKa6GaXADdIdu6d/w9 ncm8faNvfDLj3FtEwe9dnV0Y6+FZVP260WfjJF5YP+OGjE3AqEac4JdMyxImmcZXZ1wu qmYn7obhUWQreMUPocSzEaxugeuQibGRG6nwcZ5ggA6WaXQITeEvBOm7gpJr4kZuvbTL fnXg== X-Gm-Message-State: AOAM530CNN6RqSZtTFWGWb1DQynA2QqP/tPaOUg4BjcLMdSMVcJ64PzW 8uF2x+7E0POvpbLJGwGN2tSOFw== X-Google-Smtp-Source: ABdhPJwZYzce8AsKOhdWURnrWFOZhe+a78b6XqOzjitXppSqy/Hkim6wQE4k3zGjcuz9p/OD6maLvg== X-Received: by 2002:a19:505b:: with SMTP id z27mr4003215lfj.123.1589482707299; Thu, 14 May 2020 11:58:27 -0700 (PDT) Received: from wasted.cogentembedded.com ([2a00:1fa0:2f8:8bbe:b636:a971:b06:8cbf]) by smtp.gmail.com with ESMTPSA id d28sm2311430lfe.76.2020.05.14.11.58.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 May 2020 11:58:26 -0700 (PDT) Subject: Re: [PATCH] [RFC] ravb: On timeout disable IRQs to stop processing To: Dirk Behme , linux-renesas-soc@vger.kernel.org Cc: geert+renesas@glider.be, Shashikant.Suguni@in.bosch.com References: <20200409075215.3808-1-dirk.behme@de.bosch.com> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <51290a4a-0f93-b421-6225-696c4660758c@cogentembedded.com> Date: Thu, 14 May 2020 21:58:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20200409075215.3808-1-dirk.behme@de.bosch.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On 04/09/2020 10:52 AM, Dirk Behme wrote: > Analyzing [1] it seems there is a race condition where ravb_start_xmit() > can be called from interrupt while tx skbuffs are being torn down in > the scheduled timeout handling. The actual timeout work is done in > ravb_tx_timeout_work() during which the tx skbuffs are torn down via > invocations of ravb_ring_free(). But there seems to be no flag to tell > the driver it is shutting down so it continues to use the ring buffer > when it should not. > > Fix this by disabling the interrupts in the timeout handler. > > [1] > > -- cut -- > ravb e6800000.ethernet ethernet: transmit timed out, status 00000000, resetting... > ravb e6800000.ethernet ethernet: failed to switch device to config mode > Unable to handle kernel NULL pointer dereference at virtual address 00000018 > Mem abort info: > Exception class = DABT (current EL), IL = 32 bits > SET = 0, FnV = 0 > EA = 0, S1PTW = 0 > Data abort info: > ISV = 0, ISS = 0x00000046 > CM = 0, WnR = 1 > user pgtable: 4k pages, 48-bit VAs, pgd = ffff80065622f000 > [0000000000000018] *pgd=00000006962a7003 > , *pud=00000006962a8003 > , *pmd=0000000000000000 > Internal error: Oops: 96000046 [#1] PREEMPT SMP > Modules linked in: > ... > Process Thread1 (pid: 3132, stack limit = 0xffff000027dd0000) > CPU: 2 PID: 3132 Comm: Thread1 Tainted: G WC 4.14.130-ltsi-g28acae87 #1 > Hardware name: Board based on r8a7796 (DT) > task: ffff80064f2aaa00 task.stack: ffff000027dd0000 > PC is at ravb_start_xmit+0x138/0x5a0 > LR is at ravb_start_xmit+0x40/0x5a0 > pc : [] lr : [] pstate: 600001c5 > sp : ffff000027dd3550 > x29: ffff000027dd3550 > x28: 0000000000000076 > x27: ffff80061035ff00 > x26: ffff000027dd3694 > x25: ffff80069624f800 > x24: ffff80069624f000 > x23: 0000000000000003 > x22: 0000000000000001 > x21: ffff80069624f000 > x20: 0000000000000000 > x19: ffff80069624f000 > x18: 0000000000000014 > x17: 0000ffff9b90ddb0 > x16: ffff00000867d07c > x15: 0000155107b31031 > x14: 000409000c000000 > x13: 0000000003000001 > x12: 0100050010000001 > x11: 0000000003000001 > x10: 0100010010000001 > x9 : 20000000000000c0 > x8 : 0000000000000000 > x7 : ffff8006656f9388 > x6 : 0000000000000002 > x5 : 0000000000000000 > x4 : ffff8006656f929c > x3 : ffff000027dd3694 > x2 : 0000000000000018 > x1 : 0000000000000000 > x0 : 0000000000000003 > Call trace: > Exception stack(0xffff000027dd3410 to 0xffff000027dd3550) > 3400: 0000000000000003 0000000000000000 > 3420: 0000000000000018 ffff000027dd3694 ffff8006656f929c 0000000000000000 > 3440: 0000000000000002 ffff8006656f9388 0000000000000000 20000000000000c0 > 3460: 0100010010000001 0000000003000001 0100050010000001 0000000003000001 > 3480: 000409000c000000 0000155107b31031 ffff00000867d07c 0000ffff9b90ddb0 > 34a0: 0000000000000014 ffff80069624f000 0000000000000000 ffff80069624f000 > 34c0: 0000000000000001 0000000000000003 ffff80069624f000 ffff80069624f800 > 34e0: ffff000027dd3694 ffff80061035ff00 0000000000000076 ffff000027dd3550 > 3500: ffff0000084d622c ffff000027dd3550 ffff0000084d6324 00000000600001c5 > 3520: ffff00000921d008 ffff8006159b0d00 0000ffffffffffff ffff0000084d622c > 3540: ffff000027dd3550 ffff0000084d6324 > [] ravb_start_xmit+0x138/0x5a0 > [] dev_hard_start_xmit+0xa8/0x24c > [] sch_direct_xmit+0xb0/0x1a8 > [] __qdisc_run+0x214/0x2ec > [] __dev_queue_xmit+0x35c/0x5b4 > [] dev_queue_xmit+0x10/0x18 > [] register_vlan_dev+0xc74/0x10f8 [8021q] > [] dev_hard_start_xmit+0xa8/0x24c > [] __dev_queue_xmit+0x44c/0x5b4 > [] dev_queue_xmit+0x10/0x18 > [] neigh_connected_output+0xc0/0xe4 > [] ip_finish_output2+0x3c0/0x3fc > [] ip_finish_output+0xf8/0x1c4 > [] ip_mc_output+0x258/0x308 > [] ip_local_out+0x44/0x54 > [] ip_send_skb+0x1c/0xa8 > [] udp_send_skb+0x11c/0x244 > [] udp_sendmsg+0x534/0x6bc > [] inet_sendmsg+0x40/0xe0 > [] sock_sendmsg+0x3c/0x58 > [] ___sys_sendmsg+0x228/0x278 > [] __sys_sendmsg+0x58/0x98 > [] SyS_sendmsg+0x10/0x20 > Exception stack(0xffff000027dd3ec0 to 0xffff000027dd4000) > 3ec0: 0000000000000012 0000ffff8a7fdf18 0000000000004000 0000000000000000 > 3ee0: 0000ffff8a7ff258 0000ffff8a7ff150 0000ffff8a7ff840 0000000000000000 > 3f00: 00000000000000d3 0100010010000001 0000000003000001 0100050010000001 > 3f20: 0000000003000001 000409000c000000 0000000000000047 0000155107b31031 > 3f40: 0000ffff9b67dfb8 0000ffff9b90ddb0 0000000000000014 0000000000004000 > 3f60: 0000000000000012 0000ffff8a7fdf18 0000ffff780017b0 0000000000004000 > 3f80: 0000000000000010 0000000000000001 0000ffff8a7fdf00 0000ffff9000b770 > 3fa0: 0000000000000012 0000ffff8a7fde60 0000ffff9b90de10 0000ffff8a7fde60 > 3fc0: 0000ffff9b90de28 0000000080000000 0000000000000012 00000000000000d3 > 3fe0: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > [] el0_svc_naked+0x34/0x38 > Code: d37d7c01 d37d7c02 f90037a1 f9445f01 (f822683b) > ---[ end trace eabda93d178d5bcb ]--- > Kernel panic - not syncing: Fatal exception in interrupt > SMP: stopping secondary CPUs > Kernel Offset: disabled > CPU features: 0x1802004 > Memory Limit: 6144 MB > -- cut -- > > Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper") > Signed-off-by: Dirk Behme Reviewed-by: Sergei Shtylyov Sorry for the long delay. :-< [...] MBR, Sergei