From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64C0EC43381 for ; Fri, 29 Mar 2019 10:50:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35C9720811 for ; Fri, 29 Mar 2019 10:50:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="BERLBaWo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729210AbfC2KuD (ORCPT ); Fri, 29 Mar 2019 06:50:03 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:41933 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729093AbfC2KuC (ORCPT ); Fri, 29 Mar 2019 06:50:02 -0400 Received: by mail-lf1-f67.google.com with SMTP id 10so1122910lfr.8 for ; Fri, 29 Mar 2019 03:50:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UyaLyfKCh/8+yGarYKysqxWvWj6HsjNnMDWd9jRPbjI=; b=BERLBaWoBAWy09JXSHLG2LC0a6riP65CkchwpU3WY05jPESMgnf1afU9TSPdZpKvP8 WSMaCbWJNONb+BxohIBP2pg4OiNtdRyz13AYiElOZA9R1949ALL8jJZnah5tEf5qGinP tU8EM3Rmk0GgkqWsmfdgCNIdHYgHPWB2DgDNlQ02U7dMeNaU7nXmARZUu03sKsd/9Ua6 TfxV6Z0ooqb8l54b7n6A2Zx0KUwzbQh7A9U/1T2bw3rVWE7NhbU6xaC4kY4XY0cRQiVE 20eYhcCYaQ49qRMDCUr1CK+Z3JAvRUJ5ZPrf28D8xRPbsjLOKbSoSMzejLsBCmehAjRa q3lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=UyaLyfKCh/8+yGarYKysqxWvWj6HsjNnMDWd9jRPbjI=; b=MjfPz6krDi+udAhxrz1F7nNrig4BuSE163BQl1FVSYHxQJJT6T/5RWDr8qLvFuUBTF IzIrc+ISWWjWCPXvfSx6KeaicI1MSpUPc2qalaPYxmu8AG7fiyvk86iox8ZLk+U0Z2yx +33lzET1DYfbynuFm5Vvl+mNk7fp5Qx6JOV7Vlzjfcxo3WCrqHbuWq6rNeqX+JBsMVdn u2ezxJfWmcXmYdo9UeCpn26ksR6h6BfD5n6/GaKX2PuvpNmuyG+oqAIdz8z0oykszwIy 24IpXq3yw+Omu7zMCs18yR5K6/2HR9yDjqwL9lGGu93vTCsJQBLMwMwGtSqsSv0v2afE 3P/w== X-Gm-Message-State: APjAAAWmzJvHqF9nllHkiQnPtTYJB0nxK/8rIItEvCsm4Ia9hOZfSvnj 8+31DiHjWrrdvhm6pHAWaxxPhw== X-Google-Smtp-Source: APXvYqxfKCnGnEYwgQtzauvdWeP4k66FI6q19DHWJq67shOtYNMTdbGf7aYV19R5cjiYepKYXM0EtQ== X-Received: by 2002:a19:f81a:: with SMTP id a26mr13987566lff.34.1553856600582; Fri, 29 Mar 2019 03:50:00 -0700 (PDT) Received: from wasted.cogentembedded.com ([31.173.84.183]) by smtp.gmail.com with ESMTPSA id r77sm293335ljb.29.2019.03.29.03.49.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Mar 2019 03:49:59 -0700 (PDT) Subject: Re: [PATCH v9 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF controller bindings To: Mason Yang , broonie@kernel.org, marek.vasut@gmail.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, bbrezillon@kernel.org, linux-renesas-soc@vger.kernel.org, Geert Uytterhoeven , devicetree@vger.kernel.org, mark.rutland@arm.com, robh+dt@kernel.org, lee.jones@linaro.org Cc: juliensu@mxic.com.tw, Simon Horman , zhengxunli@mxic.com.tw References: <1553847606-18122-1-git-send-email-masonccyang@mxic.com.tw> <1553847606-18122-4-git-send-email-masonccyang@mxic.com.tw> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <5e841334-7cd7-3b5f-77d2-bb39bf8ec8b7@cogentembedded.com> Date: Fri, 29 Mar 2019 13:49:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1553847606-18122-4-git-send-email-masonccyang@mxic.com.tw> Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hello! On 03/29/2019 11:20 AM, Mason Yang wrote: > Document the bindings used by the Renesas R-Car Gen3 RPC-IF MFD controller. > > Signed-off-by: Mason Yang > --- > .../devicetree/bindings/mfd/mfd-renesas-rpc.txt | 57 ++++++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt > > diff --git a/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt > new file mode 100644 > index 0000000..577986b > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt > @@ -0,0 +1,57 @@ > +Renesas R-Car Gen3 RPC-IF MFD controller Device Tree Bindings > +--------------------------------------------------------------------- Too many dashes. :-) > + > +Required properties: > +- compatible: should be an SoC-specific compatible value, followed by > + "renesas,rcar-gen3-rpc" as a fallback. > + supported SoC-specific values are: > + "renesas,r8a77995-rpc" (R-Car D3) > +- reg: should contain three register areas: > + first for the base address of rpc-if registers, > + second for the direct mapping read mode and > + third for the write buffer area. > +- reg-names: should contain "regs", "dirmap" and "wbuf" > +- clocks: should contain 1 entries for the module's clock > +- clock-names: should contain "rpc" What about the "power-domains" and "resets" props? > +- #address-cells: should be 1 > +- #size-cells: should be 0 Why? You don't have the "reg" props in the sub-devices... > + > +Required nodes: > + spi: > + Node for configuring the SPI controller driver. > + Required properties: > + compatible = "renesas,rcar-rpc-spi"; Sigh... you were supposed to only place the flash device sub-nodes under the "main" device node, we don't add the virtual devices to DT, there's no matching sub-device in the hardware. You don't have to describe these sub-devices in DT, you can register the simple platform devices. > + > + hf: > + Node for configuring the hyperflash controller driver. > + Required properties: > + compatible = "renesas,rcar-rpc-hf"; > + > +Example: > + > + rpc_mfd: rpc-mfd@ee200000 { Just "rpc: rpc-if@ee200000, please. [...] MBR, Sergei