From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Andrew Murray <andrew.murray@arm.com>,
Simon Horman <horms@verge.net.au>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] PCI: rcar: Remove unnecessary header include (../pci.h)
Date: Wed, 11 Sep 2019 23:33:03 +0100 [thread overview]
Message-ID: <67fb0f5a-1bf1-596a-4012-8ae881220096@ideasonboard.com> (raw)
In-Reply-To: <20190905150528.20417-1-andrew.murray@arm.com>
Hi Andy!
On 05/09/2019 16:05, Andrew Murray wrote:
> Remove unnecessary header include (../pci.h) since it doesn't
> provide any needed symbols.
This appears to have been added in 9e2aee80c78d ("PCI: Move private DT
related functions into private header")
Several other drivers were touched in that commit too.
Have you checked to see if any others can also be cleaned up?
(I only ask, because I only see this single patch on linux-renesas-soc,
my apologies if others are on different lists.)
Regardless of that, this looks fine to me, and passes a cursory compile
check.
And I've just tried with pcie-xilinx, and pcie-altera, but both still
need this header - so perhaps pcie-rcar was just the odd one out.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Signed-off-by: Andrew Murray <andrew.murray@arm.com>
> ---
> drivers/pci/controller/pcie-rcar.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-rcar.c b/drivers/pci/controller/pcie-rcar.c
> index f6a669a9af41..ee1c38c2fac9 100644
> --- a/drivers/pci/controller/pcie-rcar.c
> +++ b/drivers/pci/controller/pcie-rcar.c
> @@ -30,8 +30,6 @@
> #include <linux/pm_runtime.h>
> #include <linux/slab.h>
>
> -#include "../pci.h"
> -
> #define PCIECAR 0x000010
> #define PCIECCTLR 0x000018
> #define CONFIG_SEND_ENABLE BIT(31)
>
next prev parent reply other threads:[~2019-09-11 22:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 15:05 [PATCH] PCI: rcar: Remove unnecessary header include (../pci.h) Andrew Murray
2019-09-06 9:34 ` Simon Horman
2019-09-11 22:33 ` Kieran Bingham [this message]
2019-09-12 8:19 ` Andrew Murray
2019-09-12 8:38 ` Geert Uytterhoeven
2019-10-15 15:28 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67fb0f5a-1bf1-596a-4012-8ae881220096@ideasonboard.com \
--to=kieran.bingham+renesas@ideasonboard.com \
--cc=andrew.murray@arm.com \
--cc=bhelgaas@google.com \
--cc=horms@verge.net.au \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).