From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: airlied@linux.ie, daniel@ffwll.ch, koji.matsuoka.xm@renesas.com,
muroya@ksk.co.jp, VenkataRajesh.Kalakodima@in.bosch.com,
Harsha.ManjulaMallikarjun@in.bosch.com,
linux-renesas-soc@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 03/19] arm64: renesas: Update 'vsps' property
Date: Tue, 9 Jul 2019 14:10:05 +0100 [thread overview]
Message-ID: <6c62ed5e-fbfd-cf5e-7611-47577e78efe6@ideasonboard.com> (raw)
In-Reply-To: <20190708031121.GA5046@pendragon.ideasonboard.com>
Hi Jacopo,
On 08/07/2019 04:11, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Sat, Jul 06, 2019 at 04:07:30PM +0200, Jacopo Mondi wrote:
>> Update the 'vsps' property in the R-Car Gen3 SoC device tree files to
>> match what's in in the documentation example.
>>
>> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+1 from me too. This certainly improves readability/clarity IMO.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
>> ---
>> arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 2 +-
>> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 2 +-
>> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 +-
>> arch/arm64/boot/dts/renesas/r8a77990.dtsi | 2 +-
>> arch/arm64/boot/dts/renesas/r8a77995.dtsi | 2 +-
>> 5 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
>> index 3f86db199dbf..e643f9d3c102 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
>> @@ -1807,7 +1807,7 @@
>> clocks = <&cpg CPG_MOD 724>,
>> <&cpg CPG_MOD 723>;
>> clock-names = "du.0", "du.1";
>> - vsps = <&vspd0 0 &vspd1 0>;
>> + vsps = <&vspd0 0>, <&vspd1 0>;
>> status = "disabled";
>>
>> ports {
>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> index 097538cc4b1f..432f4036a8a8 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> @@ -3098,7 +3098,7 @@
>> <&cpg CPG_MOD 722>,
>> <&cpg CPG_MOD 721>;
>> clock-names = "du.0", "du.1", "du.2", "du.3";
>> - vsps = <&vspd0 0 &vspd1 0 &vspd2 0 &vspd0 1>;
>> + vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, <&vspd0 1>;
>> status = "disabled";
>>
>> ports {
>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> index 2554b1742dbf..b701aeb4f438 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> @@ -2456,7 +2456,7 @@
>> clock-names = "du.0", "du.1", "du.3";
>> status = "disabled";
>>
>> - vsps = <&vspd0 0 &vspd1 0 &vspd0 1>;
>> + vsps = <&vspd0 0>, <&vspd1 0>, <&vspd0 1>;
>>
>> ports {
>> #address-cells = <1>;
>> diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
>> index 56cb566ffa09..79db5441b7e7 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
>> @@ -1764,7 +1764,7 @@
>> clocks = <&cpg CPG_MOD 724>,
>> <&cpg CPG_MOD 723>;
>> clock-names = "du.0", "du.1";
>> - vsps = <&vspd0 0 &vspd1 0>;
>> + vsps = <&vspd0 0>, <&vspd1 0>;
>> status = "disabled";
>>
>> ports {
>> diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
>> index 5bf3af246e14..49a11b4f55bd 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
>> @@ -1001,7 +1001,7 @@
>> clocks = <&cpg CPG_MOD 724>,
>> <&cpg CPG_MOD 723>;
>> clock-names = "du.0", "du.1";
>> - vsps = <&vspd0 0 &vspd1 0>;
>> + vsps = <&vspd0 0>, <&vspd1 0>;
>> status = "disabled";
>>
>> ports {
>
next prev parent reply other threads:[~2019-07-09 13:10 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-06 14:07 [PATCH v2 00/19] drm: rcar-du: Add Color Management Module (CMM) Jacopo Mondi
2019-07-06 14:07 ` [PATCH v2 01/19] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation Jacopo Mondi
2019-07-08 7:58 ` Geert Uytterhoeven
2019-08-19 13:45 ` Geert Uytterhoeven
2019-08-20 7:48 ` Jacopo Mondi
2019-08-20 7:53 ` Geert Uytterhoeven
2019-08-20 8:05 ` Jacopo Mondi
2019-08-20 17:41 ` Laurent Pinchart
2019-08-20 18:08 ` Geert Uytterhoeven
2019-07-06 14:07 ` [PATCH v2 02/19] dt-bindings: display, renesas,du: Document cmms property Jacopo Mondi
2019-07-06 14:07 ` [PATCH v2 03/19] arm64: renesas: Update 'vsps' property Jacopo Mondi
2019-07-08 3:11 ` Laurent Pinchart
2019-07-09 13:10 ` Kieran Bingham [this message]
2019-08-21 12:16 ` Geert Uytterhoeven
2019-08-22 10:00 ` Jacopo Mondi
2019-08-22 15:02 ` Laurent Pinchart
2019-07-06 14:07 ` [PATCH v2 04/19] clk: renesas: r8a7796: Add CMM clocks Jacopo Mondi
2019-07-06 14:07 ` [PATCH v2 05/19] clk: renesas: r8a7795: " Jacopo Mondi
2019-07-06 14:07 ` [PATCH v2 06/19] clk: renesas: r8a77965: " Jacopo Mondi
2019-07-06 14:07 ` [PATCH v2 07/19] clk: renesas: r8a77990: " Jacopo Mondi
2019-07-06 14:07 ` [PATCH v2 08/19] clk: renesas: r8a77995: " Jacopo Mondi
2019-07-06 14:07 ` [PATCH v2 09/19] arm64: dts: renesas: r8a7796: Add CMM units Jacopo Mondi
2019-07-06 14:07 ` [PATCH v2 10/19] arm64: dts: renesas: r8a7795: " Jacopo Mondi
2019-07-06 14:07 ` [PATCH v2 11/19] arm64: dts: renesas: r8a77965: " Jacopo Mondi
2019-07-08 3:16 ` Laurent Pinchart
2019-07-06 14:07 ` [PATCH v2 12/19] arm64: dts: renesas: r8a77990: " Jacopo Mondi
2019-07-06 14:07 ` [PATCH v2 13/19] arm64: dts: renesas: r8a77995: " Jacopo Mondi
2019-07-06 14:07 ` [PATCH v2 14/19] drm: rcar-du: Add support for CMM Jacopo Mondi
2019-07-16 13:17 ` Ulrich Hecht
2019-08-20 17:37 ` Laurent Pinchart
2019-08-22 16:44 ` Jacopo Mondi
2019-08-20 17:34 ` Laurent Pinchart
2019-08-22 13:01 ` Jacopo Mondi
2019-08-22 15:10 ` Laurent Pinchart
2019-07-06 14:07 ` [PATCH v2 15/19] drm: rcar-du: Claim CMM support for Gen3 SoCs Jacopo Mondi
2019-07-16 13:18 ` Ulrich Hecht
2019-08-20 17:45 ` Laurent Pinchart
2019-07-06 14:07 ` [PATCH v2 16/19] drm: rcar-du: kms: Collect CMM instances Jacopo Mondi
2019-07-16 13:22 ` Ulrich Hecht
2019-08-20 17:54 ` Laurent Pinchart
2019-08-22 19:09 ` Jacopo Mondi
2019-07-06 14:07 ` [PATCH v2 17/19] drm: rcar-du: crtc: Enable and disable CMMs Jacopo Mondi
2019-07-16 13:31 ` Ulrich Hecht
2019-08-20 17:57 ` Laurent Pinchart
2019-07-06 14:07 ` [PATCH v2 18/19] drm: rcar-du: crtc: Register GAMMA_LUT properties Jacopo Mondi
2019-07-16 13:32 ` Ulrich Hecht
2019-08-20 18:02 ` Laurent Pinchart
2019-07-06 14:07 ` [PATCH v2 19/19] drm: rcar-du: kms: Update CMM in atomic commit tail Jacopo Mondi
2019-07-16 13:33 ` Ulrich Hecht
2019-08-20 18:42 ` Laurent Pinchart
2019-08-22 19:19 ` Jacopo Mondi
2019-08-22 19:54 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c62ed5e-fbfd-cf5e-7611-47577e78efe6@ideasonboard.com \
--to=kieran.bingham+renesas@ideasonboard.com \
--cc=Harsha.ManjulaMallikarjun@in.bosch.com \
--cc=VenkataRajesh.Kalakodima@in.bosch.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacopo+renesas@jmondi.org \
--cc=koji.matsuoka.xm@renesas.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=muroya@ksk.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).