From: Oleksandr <olekstysh@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Julien Grall <julien.grall@arm.com>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Subject: Re: [PATCH V5] ARM: mach-shmobile: Don't init CNTVOFF/counter if PSCI is available
Date: Tue, 28 May 2019 13:10:42 +0300 [thread overview]
Message-ID: <6d3160d2-ce36-980a-1054-03bdece5bbfc@gmail.com> (raw)
In-Reply-To: <CAMuHMdVC=aNQTZ0r+7qpiWEyEaoQ587pm1FxhWqR3pwHwv2ARg@mail.gmail.com>
On 28.05.19 11:27, Geert Uytterhoeven wrote:
> Hi Oleksandr,
Hi Geert, all
> Thanks for the update!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thank you for review!
Just FYI:
Required support for Gen2 Stout board has been already added to Xen [1].
What needs to be done next is to add support for handling device-tree
nodes with "interrupts-extended" property in Xen [2].
This is related to Gen3 as well.
[1]
https://www.mail-archive.com/xen-devel@lists.xenproject.org/msg44386.html
[2]
https://www.mail-archive.com/xen-devel@lists.xenproject.org/msg45951.html
>
> Two cosmetic comments below. I'll leave it to Simon to ignore them for
> applying ;-)
>
>> @@ -62,6 +63,21 @@ void __init rcar_gen2_timer_init(void)
>> {
>> void __iomem *base;
>> u32 freq;
>> + bool need_update = true;
> Some people like reverse Xmas tree declaration order...
>
>> +
>> + /*
>> + * If PSCI is available then most likely we are running on PSCI-enabled
>> + * U-Boot which, we assume, has already taken care of resetting CNTVOFF
>> + * and updating counter module before switching to non-secure mode
>> + * and we don't need to.
>> + */
>> +#if defined(CONFIG_ARM_PSCI_FW)
> #ifdef CONFIG_ARM_PSCI_FW ?
>
> Gr{oetje,eeting}s,
>
> Geert
>
--
Regards,
Oleksandr Tyshchenko
next prev parent reply other threads:[~2019-05-28 10:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 9:58 [PATCH V5] ARM: mach-shmobile: Don't init CNTVOFF/counter if PSCI is available Oleksandr Tyshchenko
2019-05-24 9:39 ` Oleksandr
2019-05-28 8:27 ` Geert Uytterhoeven
2019-05-28 10:10 ` Oleksandr [this message]
2019-05-28 16:05 ` Simon Horman
2019-05-28 16:17 ` Oleksandr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d3160d2-ce36-980a-1054-03bdece5bbfc@gmail.com \
--to=olekstysh@gmail.com \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=julien.grall@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=oleksandr_tyshchenko@epam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).