Linux-Renesas-SoC Archive on lore.kernel.org
 help / color / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: "Simon Horman" <horms@verge.net.au>,
	"Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Takeshi Saito <takeshi.saito.xv@renesas.com>
Subject: Re: [PATCH] mmc: renesas_sdhi: Change HW adjustment register according to speed mode
Date: Thu, 14 Feb 2019 16:25:53 +0100
Message-ID: <73936058-e7a4-462f-1550-f419b6b04364@gmail.com> (raw)
In-Reply-To: <20190214124648.qkr7p5qss4kdzigh@verge.net.au>

On 2/14/19 1:46 PM, Simon Horman wrote:
> On Wed, Feb 13, 2019 at 10:22:10AM +0100, Niklas Söderlund wrote:
>> Hi Marek,
>>
>> On 2019-02-10 17:39:34 +0100, Marek Vasut wrote:
>>> On 2/10/19 2:39 PM, Niklas Söderlund wrote:
>>>> Hi Wolfram,
>>>
>>> Hi,
>>>
>>>> Thanks for your patch.
>>>>
>>>> On 2019-02-08 20:30:02 +0100, Wolfram Sang wrote:
>>>>> From: Takeshi Saito <takeshi.saito.xv@renesas.com>
>>>>>
>>>>> SCC is used for SDR104/HS200/HS400. We need to change SCC_DT2FF
>>>>> according to the mode. If it is inappropriate, CRC error tends to occur.
>>>>>
>>>>> This adds variable "tap_hs400" for HS400 mode and configures SCC_DT2FF
>>>>> as needed.
>>>>>
>>>>> Signed-off-by: Takeshi Saito <takeshi.saito.xv@renesas.com>
>>>>> [wsa: rebased to upstream and updated commit message]
>>>>> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>>>>
>>>> I think this looks good.
>>>>
>>>> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
>>> Can you test this on E3 Ebisu (do you have a board) ?
>>
>> I do not have a E3 so I'm afraid I can not provide a tested by tag for 
>> that board.
> 
> I am happy to test. Is anything specific required?

Not anymore.

On E3 Ebisu 4D
Tested-by: Marek Vasut <marek.vasut@gmail.com>

-- 
Best regards,
Marek Vasut

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-08 19:30 Wolfram Sang
2019-02-10 13:39 ` Niklas Söderlund
2019-02-10 16:39   ` Marek Vasut
2019-02-13  9:22     ` Niklas Söderlund
2019-02-14 12:46       ` Simon Horman
2019-02-14 15:25         ` Marek Vasut [this message]
2019-02-14 15:53         ` Wolfram Sang
2019-02-26  8:18 ` Ulf Hansson

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73936058-e7a4-462f-1550-f419b6b04364@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=horms@verge.net.au \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=niklas.soderlund@ragnatech.se \
    --cc=takeshi.saito.xv@renesas.com \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org linux-renesas-soc@archiver.kernel.org
	public-inbox-index linux-renesas-soc


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/ public-inbox