From: Cao Van Dong <cv-dong@jinso.co.jp>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: linux-renesas-soc@vger.kernel.org, broonie@kernel.org,
geert+renesas@glider.be, horms+renesas@verge.net.au,
devicetree@vger.kernel.org, yoshihiro.shimoda.uh@renesas.com,
h-inayoshi@jinso.co.jp, nv-dung@jinso.co.jp, na-hoan@jinso.co.jp
Subject: Re: [PATCH 06/11] ARM: dts: r8a77470: Add Audio support
Date: Wed, 10 Apr 2019 09:51:38 +0900 [thread overview]
Message-ID: <73ad4c10-ed8e-7fdc-1c68-837786cfaf6d@jinso.co.jp> (raw)
In-Reply-To: <87o95e7lmp.wl-kuninori.morimoto.gx@renesas.com>
Dear Morimoto-san,
On 2019/04/10 9:37, Kuninori Morimoto wrote:
> Hi Dong-san
>
> Thank you for your patch
>
>> + rcar_sound: sound@ec500000 {
>> + /*
>> + * #sound-dai-cells is required
>> + *
>> + * Single DAI : #sound-dai-cells = <0>; <&rcar_sound>;
>> + * Multi DAI : #sound-dai-cells = <1>; <&rcar_sound N>;
>> + */
>> + compatible = "renesas,rcar_sound-r8a77470",
>> + "renesas,rcar_sound-gen2";
>> + reg = <0 0xec500000 0 0x1000>, /* SCU */
>> + <0 0xec5a0000 0 0x100>, /* ADG */
>> + <0 0xec540000 0 0x1000>, /* SSIU */
>> + <0 0xec541000 0 0x280>, /* SSI */
>> + <0 0xec740000 0 0x200>; /* Audio DMAC peri peri */
>> + reg-names = "scu", "adg", "ssiu", "ssi", "audmapp";
> I don't have r8a77470 datasheet, but does it have *extended* Audio DMAC peri peri
> address (= 0xec760000) ? If it has, please use it instead of normal address (= 0xec740000).
>
>> + rcar_sound,ssi {
>> + ssi0: ssi-0 {
>> + interrupts = <GIC_SPI 370 IRQ_TYPE_LEVEL_HIGH>;
>> + dmas = <&audma0 0x01>, <&audma0 0x02>,
>> + <&audma0 0x15>, <&audma0 0x16>;
>> + dma-names = "rx", "tx", "rxu", "txu";
>> + };
> Please add ssiu.
> And then, ssi doesn't need "rxu" and "txu" anymore.
> These can be good help for you.
>
> 0ec8e0a879b8d7eacbfbed9a7face8f97f9493a8
> ("arm64: dts: renesas: r8a7795: remove BUSIF0 settings from rcar_sound,ssi")
>
> da90dd849dc22e920388d18a0f877366bd4d2b7f
> ("arm64: dts: renesas: r8a7795: add SSIU support for sound")
>
>
> BTW, this patch-set is including SoC only.
> Do you have plan to post board support patch after this ?
> In other words, did you test these ?
Thanks for your feedback and help!
I will create a separate patch (add
rcar_sound-r8a77470toDocumentation/../sound/renesas,rsnd.txt)
and update this patch in version 2.
Thank you,
Dong
> Thank you for your help !!
>
> Best regards
> ---
> Kuninori Morimoto
next prev parent reply other threads:[~2019-04-10 0:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 8:51 [PATCH 00/11] Add more support to the RZ/G1C (r8a77470) SoC Cao Van Dong
2019-04-09 8:51 ` [PATCH 01/11] ARM: dts: r8a77470: Add HSCIF support Cao Van Dong
2019-04-09 11:51 ` Simon Horman
2019-04-09 12:15 ` Simon Horman
2019-04-10 0:16 ` Cao Van Dong
2019-04-09 8:51 ` [PATCH 02/11] ARM: dts: r8a77470: Add MSIOF support Cao Van Dong
2019-04-09 11:55 ` Simon Horman
2019-04-09 8:51 ` [PATCH 03/11] ARM: dts: r8a77470: Add PWM support Cao Van Dong
2019-04-09 11:59 ` Simon Horman
2019-04-09 8:51 ` [PATCH 04/11] ARM: dts: r8a77470: Add CAN support Cao Van Dong
2019-04-09 12:01 ` Simon Horman
2019-04-09 8:51 ` [PATCH 05/11] ARM: dts: r8a77470: Add VIN support Cao Van Dong
2019-04-09 12:04 ` Simon Horman
2019-04-09 13:01 ` Niklas Söderlund
2019-04-10 0:23 ` Cao Van Dong
2019-04-10 0:39 ` Kuninori Morimoto
2019-04-12 12:08 ` Simon Horman
2019-04-30 13:02 ` Geert Uytterhoeven
2019-04-09 8:51 ` [PATCH 06/11] ARM: dts: r8a77470: Add Audio support Cao Van Dong
2019-04-10 0:37 ` Kuninori Morimoto
2019-04-10 0:51 ` Cao Van Dong [this message]
2019-04-10 1:16 ` Kuninori Morimoto
2019-04-10 1:33 ` Cao Van Dong
2019-04-10 9:39 ` Simon Horman
2019-04-11 8:26 ` Cao Van Dong
2019-04-09 8:51 ` [PATCH 07/11] ARM: dts: r8a77470: Add Audio-DMAC support Cao Van Dong
2019-04-09 8:51 ` [PATCH 08/11] ARM: dts: r8a77470: Add Ether support Cao Van Dong
2019-04-09 8:51 ` [PATCH 09/11] ARM: dts: r8a77470: Add VSP support Cao Van Dong
2019-04-09 8:51 ` [PATCH 10/11] ARM: dts: r8a77470: Add FDP1 support Cao Van Dong
2019-04-09 8:51 ` [PATCH 11/11] ARM: dts: r8a77470: Add LVDS support Cao Van Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73ad4c10-ed8e-7fdc-1c68-837786cfaf6d@jinso.co.jp \
--to=cv-dong@jinso.co.jp \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=h-inayoshi@jinso.co.jp \
--cc=horms+renesas@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=na-hoan@jinso.co.jp \
--cc=nv-dung@jinso.co.jp \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).